- 06 Jul, 2012 3 commits
-
-
Bruce Momjian authored
-
Robert Haas authored
Bug spotted by Tom Lane.
-
Bruce Momjian authored
report from Tom. Backpatch to 9.2.
-
- 05 Jul, 2012 9 commits
-
-
Tom Lane authored
join_path_components() tried to remove leading ".." components from its tail argument, but it was not nearly bright enough to do so correctly unless the head argument was (a) absolute and (b) canonicalized. Rather than try to fix that logic, let's just get rid of it: there is no correctness reason to remove "..", and cosmetic concerns can be taken care of by a subsequent canonicalize_path() call. Per bug #6715 from Greg Davidson. Back-patch to all supported branches. It appears that pre-9.2, this function is only used with absolute paths as head arguments, which is why we'd not noticed the breakage before. However, third-party code might be expecting this function to work in more general cases, so it seems wise to back-patch. In HEAD and 9.2, also make some minor cosmetic improvements to callers.
-
Heikki Linnakangas authored
That caused the plpython_unicode regression test to fail on SQL_ASCII encoding, as evidenced by the buildfarm. The reason is that with the patch, you don't get the detail in the error message that you got before. That detail is actually very informative, so rather than just adjust the expected output, let's revert that part of the patch for now to make the buildfarm green again, and figure out some other way to avoid the recursion of PLy_elog() that doesn't lose the detail.
-
Heikki Linnakangas authored
Windows encodings, "win1252" and so forth, are named differently in Python, like "cp1252". Also, if the PyUnicode_AsEncodedString() function call fails for some reason, use a plain ereport(), not a PLy_elog(), to report that error. That avoids recursion and crash, if PLy_elog() tries to call PLyUnicode_Bytes() again. This fixes bug reported by Asif Naeem. Backpatch down to 9.0, before that plpython didn't even try these conversions. Jan Urbański, with minor comment improvements by me.
-
Tom Lane authored
All Unix-oid platforms that we currently support should have waitpid(), since it's in V2 of the Single Unix Spec. Our git history shows that the wait3 code was added to support NextStep, which we officially dropped support for as of 9.2. So get rid of the configure test, and simplify the macro spaghetti in reaper(). Per suggestion from Fujii Masao.
-
Alvaro Herrera authored
Currently only pg_clog is copied, but some other directories could need the same treatment as well, so create a subroutine to do it. Extracted from my (somewhat larger) FOR KEY SHARE patch.
-
Magnus Hagander authored
Dean Rasheed, reviewed by Josh Kupershmidt
-
Bruce Momjian authored
copyright.pl. Backpatch to 9.2.
-
Bruce Momjian authored
Run on HEAD and 9.2.
-
Robert Haas authored
Per recent discussion on pgsql-hackers, these messages are too chatty for most users.
-
- 04 Jul, 2012 14 commits
-
-
Bruce Momjian authored
extensions that might exist in the new empty cluster databases, like plpgsql. Backpatch to 9.2.
-
Robert Haas authored
Albe Laurenz, per a report by Greg Smith that our sample function doesn't quite match Oracle's behavior.
-
Robert Haas authored
This is infrastructure for Alexander Korotkov's work on indexing regular expression searches. Alexander Korotkov, with a bit of further hackery on the MULE conversion by me
-
Robert Haas authored
Josh Kupershmidt
-
Robert Haas authored
-
Robert Haas authored
The old value of 32MB has been around for a very long time, and in the meantime typical system memories have become vastly larger. Also, now that we no longer depend on being able to fit the entirety of our shared memory segment into the system's limit on System V shared memory, there's a much better chance of the higher limit actually proving productive. Per recent discussion on pgsql-hackers.
-
Robert Haas authored
Amit Kapila, reviewed by Shigeru Hanada and Peter Eisentraut, with some modifications by me.
-
Magnus Hagander authored
-
Magnus Hagander authored
This makes it possible for the master to track how much data has actually been written my pg_receivexlog - and not just how much has been sent towards it.
-
Magnus Hagander authored
This ensures that a standby such as pg_receivexlog will not be selected as sync standby - which would cause the master to block waiting for a location that could never happen. Fujii Masao
-
Magnus Hagander authored
This hasn't been true since 9.1, when the default was changed to -1. Remove the reference completely, keeping the discussion of the parameter and it's shared memory effects on the config page.
-
Magnus Hagander authored
pgfoundry is deprectaed and no longer accepting new projects, so we really shouldn't be directing people there.
-
Magnus Hagander authored
Also remove special references to downloads off pgfoundry since they are not correct - downloads are done through the main website.
-
Tom Lane authored
This commit improves the comments in pg_wchar.h and creates #define symbols for some formerly hard-coded values. No substantive code changes. Tatsuo Ishii and Tom Lane
-
- 03 Jul, 2012 4 commits
-
-
Alvaro Herrera authored
-
Alvaro Herrera authored
Per bug #6593, REASSIGN OWNED fails when the affected role has created an extension. Even though the user related to the extension is not nominally the owner, its OID appears on pg_shdepend and thus causes problems when the user is to be dropped. This commit adds code to change the "ownership" of the extension itself, not of the contained objects. This is fine because it's currently only called from REASSIGN OWNED, which would also modify the ownership of the contained objects. However, this is not sufficient for a working ALTER OWNER implementation extension. Back-patch to 9.1, where extensions were introduced. Bug #6593 reported by Emiliano Leporati.
-
Bruce Momjian authored
-
Robert Haas authored
Since the request size will now be ~48 bytes regardless of how shared_buffers et. al. are set, much of this advice is no longer relevant.
-
- 02 Jul, 2012 7 commits
-
-
Robert Haas authored
Commit f11e8be3 broke this; it was right in Peter's original patch, but I messed it up before committing.
-
Robert Haas authored
This avoids discriminating against wal_sync_method = open_sync or open_datasync. Fujii Masao, reviewed by Andres Freund
-
Peter Eisentraut authored
-
Robert Haas authored
Per gripe from Tom Lane.
-
Robert Haas authored
Instead of letting every backend participating in a group commit wait independently, have the first one that becomes ready to flush WAL wait for the configured delay, and let all the others wait just long enough for that first process to complete its flush. This greatly increases the chances of being able to configure a commit_delay setting that actually improves performance. As a side consequence of this change, commit_delay now affects all WAL flushes, rather than just commits. There was some discussion on pgsql-hackers about whether to rename the GUC to, say, wal_flush_delay, but in the absence of consensus I am leaving it alone for now. Peter Geoghegan, with some changes, mostly to the documentation, by me.
-
Robert Haas authored
Per testing by Andres Freund, this improves replication performance and reduces replication latency and latency jitter. I was a bit concerned about moving more work into XLogInsert, but testing seems to show that it's not a problem in practice. Along the way, improve comments for WaitLatchOrSocket. Andres Freund. Review and stylistic cleanup by me.
-
- 01 Jul, 2012 2 commits
-
-
Tom Lane authored
When (re) loading the typcache comparison cache for an enum type's values, use an up-to-date MVCC snapshot, not the transaction's existing snapshot. This avoids problems if we encounter an enum OID that was created since our transaction started. Per report from Andres Freund and diagnosis by Robert Haas. To ensure this is safe even if enum comparison manages to get invoked before we've set a transaction snapshot, tweak GetLatestSnapshot to redirect to GetTransactionSnapshot instead of throwing error when FirstSnapshotSet is false. The existing uses of GetLatestSnapshot (in ri_triggers.c) don't care since they couldn't be invoked except in a transaction that's already done some work --- but it seems just conceivable that this might not be true of enums, especially if we ever choose to use enums in system catalogs. Note that the comparable coding in enum_endpoint and enum_range_internal remains GetTransactionSnapshot; this is perhaps debatable, but if we changed it those functions would have to be marked volatile, which doesn't seem attractive. Back-patch to 9.1 where ALTER TYPE ADD VALUE was added.
-
Tom Lane authored
Commit 7357558f introduced "(void) token;" into the READ_TEMP_LOCALS() macro, to suppress complaints from gcc 4.6 when the value of token was not used anywhere in a particular node-read function. However, this just moved the warning around: inspection of buildfarm results shows that some compilers are now complaining that token is being read before it's set. Revert the READ_TEMP_LOCALS() macro change and instead put "(void) token;" into READ_NODE_FIELD(), which is the principal culprit for cases where the warning might occur. In principle we might need the same in READ_BITMAPSET_FIELD() and/or READ_LOCATION_FIELD(), but it seems unlikely that a node would consist only of such fields, so I'll leave them alone for now.
-
- 30 Jun, 2012 1 commit
-
-
Tom Lane authored
Solaris Studio warns about this, and some compilers might think it's an outright syntax error.
-