1. 07 Jul, 2012 1 commit
    • Tom Lane's avatar
      Simplify and document regex library's compact-NFA representation. · c6aae304
      Tom Lane authored
      The previous coding abused the first element of a cNFA state's arcs list
      to hold a per-state flag bit, which was confusing, undocumented, and not
      even particularly efficient.  Get rid of that in favor of a separate
      "stflags" vector.  Since there's only one bit in use, I chose to allocate a
      char per state; we could possibly replace this with a bitmap at some point,
      but that would make accesses a little slower.  It's already about 8X
      smaller than before, so let's not get overly tense.
      
      Also document the representation better than it was before, which is to say
      not at all.
      
      This patch is a byproduct of investigations towards extracting a "fixed
      prefix" string from the compact-NFA representation of regex patterns.
      Might need to back-patch it if we decide to back-patch that fix, but for
      now it's just code cleanup so I'll just put it in HEAD.
      c6aae304
  2. 06 Jul, 2012 10 commits
  3. 05 Jul, 2012 9 commits
    • Tom Lane's avatar
      Don't try to trim "../" in join_path_components(). · 85254199
      Tom Lane authored
      join_path_components() tried to remove leading ".." components from its
      tail argument, but it was not nearly bright enough to do so correctly
      unless the head argument was (a) absolute and (b) canonicalized.
      Rather than try to fix that logic, let's just get rid of it: there is no
      correctness reason to remove "..", and cosmetic concerns can be taken
      care of by a subsequent canonicalize_path() call.  Per bug #6715 from
      Greg Davidson.
      
      Back-patch to all supported branches.  It appears that pre-9.2, this
      function is only used with absolute paths as head arguments, which is why
      we'd not noticed the breakage before.  However, third-party code might be
      expecting this function to work in more general cases, so it seems wise
      to back-patch.
      
      In HEAD and 9.2, also make some minor cosmetic improvements to callers.
      85254199
    • Heikki Linnakangas's avatar
      Revert part of the previous patch that avoided using PLy_elog(). · de479e2e
      Heikki Linnakangas authored
      That caused the plpython_unicode regression test to fail on SQL_ASCII
      encoding, as evidenced by the buildfarm. The reason is that with the patch,
      you don't get the detail in the error message that you got before. That
      detail is actually very informative, so rather than just adjust the expected
      output, let's revert that part of the patch for now to make the buildfarm
      green again, and figure out some other way to avoid the recursion of
      PLy_elog() that doesn't lose the detail.
      de479e2e
    • Heikki Linnakangas's avatar
      Fix mapping of PostgreSQL encodings to Python encodings. · b66de4c6
      Heikki Linnakangas authored
      Windows encodings, "win1252" and so forth, are named differently in Python,
      like "cp1252". Also, if the PyUnicode_AsEncodedString() function call fails
      for some reason, use a plain ereport(), not a PLy_elog(), to report that
      error. That avoids recursion and crash, if PLy_elog() tries to call
      PLyUnicode_Bytes() again.
      
      This fixes bug reported by Asif Naeem. Backpatch down to 9.0, before that
      plpython didn't even try these conversions.
      
      Jan Urbański, with minor comment improvements by me.
      b66de4c6
    • Tom Lane's avatar
      Remove support for using wait3() in place of waitpid(). · fc548b22
      Tom Lane authored
      All Unix-oid platforms that we currently support should have waitpid(),
      since it's in V2 of the Single Unix Spec.  Our git history shows that
      the wait3 code was added to support NextStep, which we officially dropped
      support for as of 9.2.  So get rid of the configure test, and simplify the
      macro spaghetti in reaper().  Per suggestion from Fujii Masao.
      fc548b22
    • Alvaro Herrera's avatar
      pg_upgrade: abstract out copying of files from old cluster to new · 666d494d
      Alvaro Herrera authored
      Currently only pg_clog is copied, but some other directories could need
      the same treatment as well, so create a subroutine to do it.
      
      Extracted from my (somewhat larger) FOR KEY SHARE patch.
      666d494d
    • Magnus Hagander's avatar
      Fix function argument tab completion for schema-qualified or quoted function names · 3644a639
      Magnus Hagander authored
      Dean Rasheed, reviewed by Josh Kupershmidt
      3644a639
    • Bruce Momjian's avatar
      Fix missing regex slash that caused perltidy to get confused on · 539d3875
      Bruce Momjian authored
      copyright.pl.
      
      Backpatch to 9.2.
      539d3875
    • Bruce Momjian's avatar
      Run newly-configured perltidy script on Perl files. · 042d9ffc
      Bruce Momjian authored
      Run on HEAD and 9.2.
      042d9ffc
    • Robert Haas's avatar
      Reduce messages about implicit indexes and sequences to DEBUG1. · d7c73484
      Robert Haas authored
      Per recent discussion on pgsql-hackers, these messages are too
      chatty for most users.
      d7c73484
  4. 04 Jul, 2012 14 commits
  5. 03 Jul, 2012 4 commits
  6. 02 Jul, 2012 2 commits