1. 11 Jun, 2006 1 commit
    • Tom Lane's avatar
      Fix Assert failure when a fastpath function call is attempted inside an · bf64a379
      Tom Lane authored
      already-aborted transaction block.  GetSnapshotData throws an Assert if
      not in a valid transaction; hence we mustn't attempt to set a snapshot
      for the function until after checking for aborted transaction.  This is
      harmless AFAICT if Asserts aren't enabled (GetSnapshotData will compute
      a bogus snapshot, but it doesn't matter since HandleFunctionRequest will
      throw an error shortly anywy).  Hence, not a major bug.
      
      Along the way, add some ability to log fastpath calls when statement
      logging is turned on.  This could probably stand to be improved further,
      but not logging anything is clearly undesirable.
      
      Backpatched as far as 8.0; bug doesn't exist before that.
      bf64a379
  2. 10 Jun, 2006 2 commits
    • Bruce Momjian's avatar
      Remove pg_dump wording: · 807bfa58
      Bruce Momjian authored
      <   pg_get_tabledef(), pg_get_domaindef(), pg_get_functiondef(), and
      <   make use of them in pg_dump
      >   pg_get_tabledef(), pg_get_domaindef(), pg_get_functiondef()
      807bfa58
    • Bruce Momjian's avatar
      Add: · 0d001c86
      Bruce Momjian authored
      <   pg_get_tabledef(), pg_get_domaindef(), pg_get_functiondef()
      >   pg_get_tabledef(), pg_get_domaindef(), pg_get_functiondef(), and
      >   make use of them in pg_dump
      0d001c86
  3. 09 Jun, 2006 8 commits
    • Tom Lane's avatar
      Repair remarkably-inefficient query for dumping large object comments: it · b773987f
      Tom Lane authored
      was invoking obj_description() for each large object chunk, instead of once
      per large object.  This code is new as of 8.1, which may explain why the
      problem hadn't been noticed already.
      b773987f
    • Tom Lane's avatar
      Revert sampling patch for EXPLAIN ANALYZE; it turns out to be too unreliable · 5de0cbdf
      Tom Lane authored
      because node timing is much less predictable than the patch expects.  I kept
      the API change for InstrStopNode, however.
      5de0cbdf
    • Bruce Momjian's avatar
      Cleanups: · 91431449
      Bruce Momjian authored
      < 	* Allow a database in tablespace t1 with tables created in
      > 	o Allow a database in tablespace t1 with tables created in
      125c125
      < 	* Allow reporting of which objects are in which tablespaces
      > 	o Allow reporting of which objects are in which tablespaces
      593c593
      < 	* Allow GRANT/REVOKE permissions to be inherited by objects based on
      > 	o Allow GRANT/REVOKE permissions to be inherited by objects based on
      596c596
      < 	* Allow SERIAL sequences to inherit permissions from the base table?
      > 	o Allow SERIAL sequences to inherit permissions from the base table?
      91431449
    • Bruce Momjian's avatar
      Cleanup: · c0ba4829
      Bruce Momjian authored
      < * -%Allow pooled connections to list all prepared statements
      > * -Allow pooled connections to list all prepared statements
      c0ba4829
    • Teodor Sigaev's avatar
      Now ispell dictionary can eat dictionaries in MySpell format, · 04e9704b
      Teodor Sigaev authored
      used by OpenOffice. Dictionaries are placed at
      http://lingucomponent.openoffice.org/spell_dic.html
      Dictionary automatically recognizes format of files.
      
      Warning. MySpell's format has limitation with compound
      word support: it's impossible to mark affix as
      compound-only affix. So for norwegian, german etc
      languages it's recommended to use original ispell format.
      For that reason I don't want to remove my2ispell
      scripts, it's has workaround at least for norwegian language.
      04e9704b
    • Bruce Momjian's avatar
      Add URL. · 1a1326d6
      Bruce Momjian authored
      < 	  the insert.
      > 	  the insert.
      > 	  http://archives.postgresql.org/pgsql-patches/2005-07/msg00568.php
      1a1326d6
    • Bruce Momjian's avatar
      Update: · fa23204c
      Bruce Momjian authored
      < * Add SQL99 WITH RECURSIVE (hierarchical) queries to SELECT
      > * Add SQL:2003 WITH RECURSIVE (hierarchical) queries to SELECT
      fa23204c
    • Bruce Momjian's avatar
      Remove: · 2f12903e
      Bruce Momjian authored
      < * Rename some /contrib modules from pg* to pg_*
      2f12903e
  4. 08 Jun, 2006 16 commits
  5. 07 Jun, 2006 10 commits
  6. 06 Jun, 2006 3 commits
    • Bruce Momjian's avatar
      Update comment. · 6ca917ad
      Bruce Momjian authored
      6ca917ad
    • Bruce Momjian's avatar
      On Win32, return original patch if GetShortPathName() fails (no short · 62e7ad66
      Bruce Momjian authored
      name, path does not exist), rather than returning nothing.
      
      Backpatch to 8.1.X.
      62e7ad66
    • Tom Lane's avatar
      Make the planner estimate costs for nestloop inner indexscans on the basis · 8a30cc21
      Tom Lane authored
      that the Mackert-Lohmann formula applies across all the repetitions of the
      nestloop, not just each scan independently.  We use the M-L formula to
      estimate the number of pages fetched from the index as well as from the table;
      that isn't what it was designed for, but it seems reasonably applicable
      anyway.  This makes large numbers of repetitions look much cheaper than
      before, which accords with many reports we've received of overestimation
      of the cost of a nestloop.  Also, change the index access cost model to
      charge random_page_cost per index leaf page touched, while explicitly
      not counting anything for access to metapage or upper tree pages.  This
      may all need tweaking after we get some field experience, but in simple
      tests it seems to be giving saner results than before.  The main thing
      is to get the infrastructure in place to let cost_index() and amcostestimate
      functions take repeated scans into account at all.  Per my recent proposal.
      
      Note: this patch changes pg_proc.h, but I did not force initdb because
      the changes are basically cosmetic --- the system does not look into
      pg_proc to decide how to call an index amcostestimate function, and
      there's no way to call such a function from SQL at all.
      8a30cc21