1. 22 Feb, 2011 2 commits
    • Tom Lane's avatar
      Fix dangling-pointer problem in before-row update trigger processing. · a210be77
      Tom Lane authored
      ExecUpdate checked for whether ExecBRUpdateTriggers had returned a new
      tuple value by seeing if the returned tuple was pointer-equal to the old
      one.  But the "old one" was in estate->es_junkFilter's result slot, which
      would be scribbled on if we had done an EvalPlanQual update in response to
      a concurrent update of the target tuple; therefore we were comparing a
      dangling pointer to a live one.  Given the right set of circumstances we
      could get a false match, resulting in not forcing the tuple to be stored in
      the slot we thought it was stored in.  In the case reported by Maxim Boguk
      in bug #5798, this led to "cannot extract system attribute from virtual
      tuple" failures when trying to do "RETURNING ctid".  I believe there is a
      very-low-probability chance of more serious errors, such as generating
      incorrect index entries based on the original rather than the
      trigger-modified version of the row.
      
      In HEAD, change all of ExecBRInsertTriggers, ExecIRInsertTriggers,
      ExecBRUpdateTriggers, and ExecIRUpdateTriggers so that they continue to
      have similar APIs.  In the back branches I just changed
      ExecBRUpdateTriggers, since there is no bug in the ExecBRInsertTriggers
      case.
      a210be77
    • Bruce Momjian's avatar
      Move information_schema duplicate constraint note to the top of the · fee78027
      Bruce Momjian authored
      information schema documentation because it affects several tables.
      fee78027
  2. 21 Feb, 2011 4 commits
  3. 20 Feb, 2011 5 commits
  4. 19 Feb, 2011 7 commits
  5. 18 Feb, 2011 14 commits
  6. 17 Feb, 2011 8 commits
    • Tom Lane's avatar
      Fix upgrade of contrib/xml2 from 9.0. · de623f33
      Tom Lane authored
      Update script was being sloppy about two functions that have been changed
      since 9.0.
      de623f33
    • Tom Lane's avatar
      Fix upgrade of contrib/intarray and contrib/unaccent from 9.0. · 0024e348
      Tom Lane authored
      Take care of a couple of discrepancies between what you get from a fresh
      install and what the first-draft update-from-unpackaged scripts produced.
      0024e348
    • Tom Lane's avatar
      Fix upgrade of contrib/btree_gist from 9.0. · ec65a79d
      Tom Lane authored
      The initial version of the update-from-unpackaged script neglected to
      include the <> operators that were added to the opclasses during 9.1.
      To make this script produce the same final state as the regular install
      script, use the same ALTER OPERATOR FAMILY trick as in pg_trgm.
      ec65a79d
    • Robert Haas's avatar
      Add client_hostname field to pg_stat_activity. · 4a25bc14
      Robert Haas authored
      Peter Eisentraut, reviewed by Steve Singer, Alvaro Herrera, and me.
      4a25bc14
    • Robert Haas's avatar
      Prevent possible compiler warnings. · a3e8486d
      Robert Haas authored
      Simon Riggs reports that rnode.dbNode and rnode.spcNode were
      generating unused variable warnings on gcc 4.4.3 with CFLAGS=-O1
      a3e8486d
    • Bruce Momjian's avatar
      Typo fix · 4f2cfc5b
      Bruce Momjian authored
      Erik Rijkers
      4f2cfc5b
    • Tom Lane's avatar
      Fix contrib/pg_trgm to have smoother updates from 9.0. · 4eb49db7
      Tom Lane authored
      Take care of some loose ends in the update-from-unpackaged script, and
      apply some ugly hacks to ensure that it produces the same catalog state
      as the fresh-install script.  Per discussion, this seems like a safer
      plan than having two different catalog states that both call themselves
      "pg_trgm 1.0", even if it's not immediately clear that the subtle
      differences would ever matter.
      
      Also, fix the stub function gin_extract_trgm() so that it works instead
      of just bleating.  Needed because this function will get called during a
      regular dump and reload, if there are any indexes using its opclass.
      The user won't have an opportunity to update the extension till later,
      so telling him to do so is unhelpful.
      4eb49db7
    • Bruce Momjian's avatar