- 13 Aug, 2010 3 commits
-
-
Robert Haas authored
Since the only purpose of WAL-loggin SharedInvalidationMessages is to support Hot Standby operation, they needn't be included when wal_level < hot_standby. Back-patch to 9.0. Review by Heikki Linnakanagas and Fujii Masao.
-
Tom Lane authored
and input file name, per bug #5617 from Leo Shklovskii. Rearrange the corresponding code in pg_dump and pg_dumpall so that all three programs handle this in a consistent, straightforward fashion. Back-patch to 9.0, but no further. Although this is certainly a bug, it's possible that people have scripts that will be broken by the added error check, so it seems better not to change the behavior in stable branches.
-
Robert Haas authored
Thom Brown
-
- 12 Aug, 2010 5 commits
-
-
Robert Haas authored
Fujii Masao
-
Tom Lane authored
out immediately on any out-of-memory condition. It's rather pointless to imagine that pgbench will be able to continue usefully after a malloc failure, and in any case there were a number of unchecked mallocs.
-
Tom Lane authored
times) to pgbench. Florian Pflug, reviewed by Greg Smith
-
Bruce Momjian authored
-
Tom Lane authored
and the editor's cursor will be initially placed on that line. In \e the lines are counted with respect to the query buffer, while in \ef they are counted with line 1 = first line of function body. These choices are useful for positioning the cursor on the line of a previously-reported error. To avoid assumptions about what switch the user's editor takes for this purpose, invent a new psql variable EDITOR_LINENUMBER_SWITCH with (at present) no default value. One incompatibility from previous behavior is that "\e 1234" will now take "1234" as a line number not a file name. There are at least two ways to select a numerically-named file if you really want to. Pavel Stehule, reviewed by Jan Urbanski, with further editing by Robert Haas and Tom Lane
-
- 11 Aug, 2010 4 commits
-
-
Bruce Momjian authored
-
Heikki Linnakangas authored
continue to accept an empty array with dimension information. array_send() can output such arrays. Per report from Vladimir Shakhov.
-
Robert Haas authored
Again, back-patch all the way to 7.4.
-
Robert Haas authored
ecpgerrno.h hasn't materially changed since PostgreSQL 7.4, so this has been wrong for a very long time. Back-patch all the way. Satoshi Nagayasu
-
- 10 Aug, 2010 5 commits
-
-
Tom Lane authored
pairs that can be handled by xslt_process(). There is much else to do here, but this patch seems useful in its own right for as long as this code survives. Pavel Stehule, reviewed by Mike Fowler
-
Tom Lane authored
better handling of NULL elements within the arrays. The third parameter is a string that should be used to represent a NULL element, or should be translated into a NULL element, respectively. If the third parameter is NULL it behaves the same as the two-parameter form. There are two incompatible changes in the behavior of the two-parameter form of string_to_array. First, it will return an empty (zero-element) array rather than NULL when the input string is of zero length. Second, if the field separator is NULL, the function splits the string into individual characters, rather than returning NULL as before. These two changes make this form fully compatible with the behavior of the new three-parameter form. Pavel Stehule, reviewed by Brendan Jurd
-
Peter Eisentraut authored
-
Peter Eisentraut authored
surrounding text refers to the example inline.
-
Robert Haas authored
Per observation from Tom Lane that the previous patch to these files was not consistent with what is done elsewhere in the docs.
-
- 09 Aug, 2010 3 commits
-
-
Tom Lane authored
expressions. We need to deal with this when handling subscripts in an array assignment, and also when catching an exception. In an Assert-enabled build these omissions led to Assert failures, but I think in a normal build the only consequence would be short-term memory leakage; which may explain why this wasn't reported from the field long ago. Back-patch to all supported versions. 7.4 doesn't have exceptions, but otherwise these bugs go all the way back. Heikki Linnakangas and Tom Lane
-
Robert Haas authored
Daniele Varrazzo
-
Tom Lane authored
can be caught in the same places that could catch an ordinary RAISE ERROR in the same location. The previous coding insisted on throwing the error from the block containing the active exception handler; which is arguably more surprising, and definitely unlike Oracle's behavior. Not back-patching, since this is a pretty obscure corner case. The risk of breaking somebody's code in a minor version update seems to outweigh any possible benefit. Piyush Newe, reviewed by David Fetter
-
- 08 Aug, 2010 2 commits
-
-
Tom Lane authored
it offers support for namespace mapping. Mike Fowler, reviewed by David Fetter
-
Tom Lane authored
statistics counts. These numbers are being accumulated but haven't yet been transmitted to the collector (and won't be, until the transaction ends). For some purposes, though, it's handy to be able to look at them. Joel Jacobson, reviewed by Itagaki Takahiro
-
- 07 Aug, 2010 2 commits
-
-
Bruce Momjian authored
Peter Fokkinga
-
Tom Lane authored
other columns to be referenced without listing them in GROUP BY, so long as the primary key column(s) are listed in GROUP BY. Eventually we should also allow functional dependency on a UNIQUE constraint when the columns are marked NOT NULL, but that has to wait until NOT NULL constraints are represented in pg_constraint, because we need to have pg_constraint OIDs for all the conditions needed to ensure functional dependency. Peter Eisentraut, reviewed by Alex Hunsaker and Tom Lane
-
- 06 Aug, 2010 6 commits
-
-
Peter Eisentraut authored
-
Tom Lane authored
-
Tom Lane authored
-
Robert Haas authored
Josh Berkus
-
Tom Lane authored
-
Robert Haas authored
-
- 05 Aug, 2010 6 commits
-
-
Tom Lane authored
matching a call like f(x, ORDER BY y,z). It could be that what the user really wants is f(x,z ORDER BY y). We now have pretty conclusive evidence that many people won't understand this problem without concrete guidance, so give it to them. Per further discussion of the string_agg() problem.
-
Peter Eisentraut authored
-
Tom Lane authored
functionality, while creating an ambiguity in usage with ORDER BY that at least two people have already gotten seriously confused by. Also, add an opr_sanity test to check that we don't in future violate the newly minted policy of not having built-in aggregates with the same name and different numbers of parameters. Per discussion of a complaint from Thom Brown.
-
Robert Haas authored
- Rename TSParserGetPrsid to get_ts_parser_oid. - Rename TSDictionaryGetDictid to get_ts_dict_oid. - Rename TSTemplateGetTmplid to get_ts_template_oid. - Rename TSConfigGetCfgid to get_ts_config_oid. - Rename FindConversionByName to get_conversion_oid. - Rename GetConstraintName to get_constraint_oid. - Add new functions get_opclass_oid, get_opfamily_oid, get_rewrite_oid, get_rewrite_oid_without_relid, get_trigger_oid, and get_cast_oid. The name of each function matches the corresponding catalog. Thanks to KaiGai Kohei for the review.
-
Robert Haas authored
unqualified names. - Add a missing_ok parameter to get_tablespace_oid. - Avoid duplicating get_tablespace_od guts in objectNamesToOids. - Add a missing_ok parameter to get_database_oid. - Replace get_roleid and get_role_checked with get_role_oid. - Add get_namespace_oid, get_language_oid, get_am_oid. - Refactor existing code to use new interfaces. Thanks to KaiGai Kohei for the review.
-
Peter Eisentraut authored
by Mike Fowler, reviewed by Peter Eisentraut
-
- 04 Aug, 2010 4 commits
-
-
Robert Haas authored
The previous commit changed the function to say 'typmod' rather than 'typemod', but I forgot to update the header file.
-
Robert Haas authored
The old computation can sometimes underestimate the necessary space by 2 bytes; however we're not back-patching this, because this result isn't used for anything critical. Per discussion with Tom Lane, make the typmod test in this function match the ones in numeric() and apply_typmod() exactly.
-
Tom Lane authored
Noted by Dmitriy Igrishin.
-
Tom Lane authored
aggregates. People seem to not get this right without help.
-