1. 10 Feb, 2011 7 commits
    • Magnus Hagander's avatar
      Track last time for statistics reset on databases and bgwriter · 4c468b37
      Magnus Hagander authored
      Tracks one counter for each database, which is reset whenever
      the statistics for any individual object inside the database is
      reset, and one counter for the background writer.
      
      Tomas Vondra, reviewed by Greg Smith
      4c468b37
    • Magnus Hagander's avatar
      Use NOWAIT when including WAL in base backup · a2e61ec3
      Magnus Hagander authored
      Avoids warning and waiting for the last segment to be
      archived, which isn't necessary when we're including the
      required WAL in the backup itself.
      a2e61ec3
    • Heikki Linnakangas's avatar
      Allocate all entries in the serializable xid hash up-front, so that you don't · cecb5901
      Heikki Linnakangas authored
      run out of shared memory when you try to assign an xid to a transaction.
      
      Kevin Grittner
      cecb5901
    • Andrew Dunstan's avatar
    • Tom Lane's avatar
      Fix improper matching of resjunk column names for FOR UPDATE in subselect. · e617f0d7
      Tom Lane authored
      Flattening of subquery range tables during setrefs.c could lead to the
      rangetable indexes in PlanRowMark nodes not matching up with the column
      names previously assigned to the corresponding resjunk ctid (resp. tableoid
      or wholerow) columns.  Typical symptom would be either a "cannot extract
      system attribute from virtual tuple" error or an Assert failure.  This
      wasn't a problem before 9.0 because we didn't support FOR UPDATE below the
      top query level, and so the final flattening could never renumber an RTE
      that was relevant to FOR UPDATE.  Fix by using a plan-tree-wide unique
      number for each PlanRowMark to label the associated resjunk columns, so
      that the number need not change during flattening.
      
      Per report from David Johnston (though I'm darned if I can see how this got
      past initial testing of the relevant code).  Back-patch to 9.0.
      e617f0d7
    • Itagaki Takahiro's avatar
      Fix typo in the documentation. · 5478f991
      Itagaki Takahiro authored
      by Kevin Grittner
      5478f991
    • Tom Lane's avatar
      Fix pg_upgrade to handle extensions. · caddcb8f
      Tom Lane authored
      This follows my proposal of yesterday, namely that we try to recreate the
      previous state of the extension exactly, instead of allowing CREATE
      EXTENSION to run a SQL script that might create some entirely-incompatible
      on-disk state.  In --binary-upgrade mode, pg_dump won't issue CREATE
      EXTENSION at all, but instead uses a kluge function provided by
      pg_upgrade_support to recreate the pg_extension row (and extension-level
      pg_depend entries) without creating any member objects.  The member objects
      are then restored in the same way as if they weren't members, in particular
      using pg_upgrade's normal hacks to preserve OIDs that need to be preserved.
      Then, for each member object, ALTER EXTENSION ADD is issued to recreate the
      pg_depend entry that marks it as an extension member.
      
      In passing, fix breakage in pg_upgrade's enum-type support: somebody didn't
      fix it when the noise word VALUE got added to ALTER TYPE ADD.  Also,
      rationalize parsetree representation of COMMENT ON DOMAIN and fix
      get_object_address() to allow OBJECT_DOMAIN.
      caddcb8f
  2. 09 Feb, 2011 7 commits
  3. 08 Feb, 2011 13 commits
  4. 07 Feb, 2011 5 commits
    • Heikki Linnakangas's avatar
      Oops, forgot to bump catversion in the Serializable Snapshot Isolation patch. · 47082fa8
      Heikki Linnakangas authored
      I thought we didn't need that, but then I remembered that it added a new
      SLRU subdirectory, pg_serial. While we're at it, document what pg_serial is.
      47082fa8
    • Heikki Linnakangas's avatar
      Implement genuine serializable isolation level. · dafaa3ef
      Heikki Linnakangas authored
      Until now, our Serializable mode has in fact been what's called Snapshot
      Isolation, which allows some anomalies that could not occur in any
      serialized ordering of the transactions. This patch fixes that using a
      method called Serializable Snapshot Isolation, based on research papers by
      Michael J. Cahill (see README-SSI for full references). In Serializable
      Snapshot Isolation, transactions run like they do in Snapshot Isolation,
      but a predicate lock manager observes the reads and writes performed and
      aborts transactions if it detects that an anomaly might occur. This method
      produces some false positives, ie. it sometimes aborts transactions even
      though there is no anomaly.
      
      To track reads we implement predicate locking, see storage/lmgr/predicate.c.
      Whenever a tuple is read, a predicate lock is acquired on the tuple. Shared
      memory is finite, so when a transaction takes many tuple-level locks on a
      page, the locks are promoted to a single page-level lock, and further to a
      single relation level lock if necessary. To lock key values with no matching
      tuple, a sequential scan always takes a relation-level lock, and an index
      scan acquires a page-level lock that covers the search key, whether or not
      there are any matching keys at the moment.
      
      A predicate lock doesn't conflict with any regular locks or with another
      predicate locks in the normal sense. They're only used by the predicate lock
      manager to detect the danger of anomalies. Only serializable transactions
      participate in predicate locking, so there should be no extra overhead for
      for other transactions.
      
      Predicate locks can't be released at commit, but must be remembered until
      all the transactions that overlapped with it have completed. That means that
      we need to remember an unbounded amount of predicate locks, so we apply a
      lossy but conservative method of tracking locks for committed transactions.
      If we run short of shared memory, we overflow to a new "pg_serial" SLRU
      pool.
      
      We don't currently allow Serializable transactions in Hot Standby mode.
      That would be hard, because even read-only transactions can cause anomalies
      that wouldn't otherwise occur.
      
      Serializable isolation mode now means the new fully serializable level.
      Repeatable Read gives you the old Snapshot Isolation level that we have
      always had.
      
      Kevin Grittner and Dan Ports, reviewed by Jeff Davis, Heikki Linnakangas and
      Anssi Kääriäinen
      dafaa3ef
    • Itagaki Takahiro's avatar
      Fix a comment for MergeAttributes. · c18f51da
      Itagaki Takahiro authored
      We forgot to adjust it when we changed relistemp to relpersistence.
      c18f51da
    • Andrew Dunstan's avatar
    • Itagaki Takahiro's avatar
      Fix error messages for FreeFile in COPY command. · fb7355e0
      Itagaki Takahiro authored
      They are extracted from COPY API patch.
      
      suggested by Noah Misch
      fb7355e0
  5. 06 Feb, 2011 6 commits
  6. 05 Feb, 2011 2 commits