1. 14 Jul, 2012 3 commits
  2. 13 Jul, 2012 2 commits
    • Tom Lane's avatar
      Add fsync capability to initdb, and use sync_file_range() if available. · b966dd6c
      Tom Lane authored
      Historically we have not worried about fsync'ing anything during initdb
      (in fact, initdb intentionally passes -F to each backend launch to prevent
      it from fsync'ing).  But with filesystems getting more aggressive about
      caching data, that's not such a good plan anymore.  Make initdb do a pass
      over the finished data directory tree to fsync everything.  For testing
      purposes, the -N/--nosync flag can be used to restore the old behavior.
      
      Also, testing shows that on Linux, sync_file_range() is much faster than
      posix_fadvise() for hinting to the kernel that an fsync is coming,
      apparently because the latter blocks on a rather small request queue while
      the former doesn't.  So use this function if available in initdb, and also
      in the backend's pg_flush_data() (where it currently will affect only the
      speed of CREATE DATABASE's cloning step).
      
      We will later make pg_regress invoke initdb with the --nosync flag
      to avoid slowing down cases such as "make check" in contrib.  But
      let's not do so until we've shaken out any portability issues in this
      patch.
      
      Jeff Davis, reviewed by Andres Freund
      b966dd6c
    • Tom Lane's avatar
      Cosmetic cleanup of ginInsertValue(). · 1a9405d2
      Tom Lane authored
      Make it clearer that the passed stack mustn't be empty, and that we
      are not supposed to fall off the end of the stack in the main loop.
      Tighten the loop that extracts the root block number, too.
      
      Markus Wanner and Tom Lane
      1a9405d2
  3. 12 Jul, 2012 4 commits
  4. 11 Jul, 2012 3 commits
  5. 10 Jul, 2012 6 commits
    • Tatsuo Ishii's avatar
      Add comments about additional mule-internal charsets from emacs's · 1c7a7faa
      Tatsuo Ishii authored
      source code(lisp/international/mule-conf.el).  These charsets have not
      been supported up to now anyway, so this is just for adding
      commentary.  Also add mention that we follow emacs's implementation,
      not xemacs's.
      1c7a7faa
    • Tom Lane's avatar
      Fix ASCII case in pg_wchar2mule_with_len. · 60e9c224
      Tom Lane authored
      Also some cosmetic improvements for wchar-to-mblen patch.
      60e9c224
    • Alvaro Herrera's avatar
      plperl: Skip setting UTF8 flag when in SQL_ASCII encoding · 379607c9
      Alvaro Herrera authored
      When in SQL_ASCII encoding, strings passed around are not necessarily
      UTF8-safe.  We had already fixed this in some places, but it looks like
      we missed some.
      
      I had to backpatch Peter Eisentraut's a8b92b60 to 9.1 in order for this
      patch to cherry-pick more cleanly.
      
      Patch from Alex Hunsaker, tweaked by Kyotaro HORIGUCHI and myself.
      
      Some desultory cleanup and comment addition by me, during patch review.
      
      Per bug report from Christoph Berg in
      20120209102116.GA14429@msgid.df7cb.de
      379607c9
    • Alvaro Herrera's avatar
      perltidy adjustments to new file · fc4a8a6d
      Alvaro Herrera authored
      fc4a8a6d
    • Tom Lane's avatar
      Re-implement extraction of fixed prefixes from regular expressions. · 628cbb50
      Tom Lane authored
      To generate btree-indexable conditions from regex WHERE conditions (such as
      WHERE indexed_col ~ '^foo'), we need to be able to identify any fixed
      prefix that a regex might have; that is, find any string that must be a
      prefix of all strings satisfying the regex.  We used to do that with
      entirely ad-hoc code that looked at the source text of the regex.  It
      didn't know very much about regex syntax, which mostly meant that it would
      fail to identify some optimizable cases; but Viktor Rosenfeld reported that
      it would produce actively wrong answers for quantified parenthesized
      subexpressions, such as '^(foo)?bar'.  Rather than trying to extend the
      ad-hoc code to cover this, let's get rid of it altogether in favor of
      identifying prefixes by examining the compiled form of a regex.
      
      To do this, I've added a new entry point "pg_regprefix" to the regex library;
      hopefully it is defined in a sufficiently general fashion that it can remain
      in the library when/if that code gets split out as a standalone project.
      
      Since this bug has been there for a very long time, this fix needs to get
      back-patched.  However it depends on some other recent commits (particularly
      the addition of wchar-to-database-encoding conversion), so I'll commit this
      separately and then go to work on back-porting the necessary fixes.
      628cbb50
    • Tom Lane's avatar
      Refactor pattern_fixed_prefix() to avoid dealing in incomplete patterns. · 00dac600
      Tom Lane authored
      Previously, pattern_fixed_prefix() was defined to return whatever fixed
      prefix it could extract from the pattern, plus the "rest" of the pattern.
      That definition was sensible for LIKE patterns, but not so much for
      regexes, where reconstituting a valid pattern minus the prefix could be
      quite tricky (certainly the existing code wasn't doing that correctly).
      Since the only thing that callers ever did with the "rest" of the pattern
      was to pass it to like_selectivity() or regex_selectivity(), let's cut out
      the middle-man and just have pattern_fixed_prefix's subroutines do this
      directly.  Then pattern_fixed_prefix can return a simple selectivity
      number, and the question of how to cope with partial patterns is removed
      from its API specification.
      
      While at it, adjust the API spec so that callers who don't actually care
      about the pattern's selectivity (which is a lot of them) can pass NULL for
      the selectivity pointer to skip doing the work of computing a selectivity
      estimate.
      
      This patch is only an API refactoring that doesn't actually change any
      processing, other than allowing a little bit of useless work to be skipped.
      However, it's necessary infrastructure for my upcoming fix to regex prefix
      extraction, because after that change there won't be any simple way to
      identify the "rest" of the regex, not even to the low level of fidelity
      needed by regex_selectivity.  We can cope with that if regex_fixed_prefix
      and regex_selectivity communicate directly, but not if we have to work
      within the old API.  Hence, back-patch to all active branches.
      00dac600
  6. 09 Jul, 2012 1 commit
    • Tom Lane's avatar
      Fix planner to pass correct collation to operator selectivity estimators. · e7ef6d7e
      Tom Lane authored
      We can do this without creating an API break for estimation functions
      by passing the collation using the existing fmgr functionality for
      passing an input collation as a hidden parameter.
      
      The need for this was foreseen at the outset, but we didn't get around to
      making it happen in 9.1 because of the decision to sort all pg_statistic
      histograms according to the database's default collation.  That meant that
      selectivity estimators generally need to use the default collation too,
      even if they're estimating for an operator that will do something
      different.  The reason it's suddenly become more interesting is that
      regexp interpretation also uses a collation (for its LC_TYPE not LC_COLLATE
      property), and we no longer want to use the wrong collation when examining
      regexps during planning.  It's not that the selectivity estimate is likely
      to change much from this; rather that we are thinking of caching compiled
      regexps during planner estimation, and we won't get the intended benefit
      if we cache them with a different collation than the executor will use.
      
      Back-patch to 9.1, both because the regexp change is likely to get
      back-patched and because we might as well get this right in all
      collation-supporting branches, in case any third-party code wants to
      rely on getting the collation.  The patch turns out to be minuscule
      now that I've done it ...
      e7ef6d7e
  7. 07 Jul, 2012 1 commit
    • Tom Lane's avatar
      Simplify and document regex library's compact-NFA representation. · c6aae304
      Tom Lane authored
      The previous coding abused the first element of a cNFA state's arcs list
      to hold a per-state flag bit, which was confusing, undocumented, and not
      even particularly efficient.  Get rid of that in favor of a separate
      "stflags" vector.  Since there's only one bit in use, I chose to allocate a
      char per state; we could possibly replace this with a bitmap at some point,
      but that would make accesses a little slower.  It's already about 8X
      smaller than before, so let's not get overly tense.
      
      Also document the representation better than it was before, which is to say
      not at all.
      
      This patch is a byproduct of investigations towards extracting a "fixed
      prefix" string from the compact-NFA representation of regex patterns.
      Might need to back-patch it if we decide to back-patch that fix, but for
      now it's just code cleanup so I'll just put it in HEAD.
      c6aae304
  8. 06 Jul, 2012 10 commits
  9. 05 Jul, 2012 9 commits
    • Tom Lane's avatar
      Don't try to trim "../" in join_path_components(). · 85254199
      Tom Lane authored
      join_path_components() tried to remove leading ".." components from its
      tail argument, but it was not nearly bright enough to do so correctly
      unless the head argument was (a) absolute and (b) canonicalized.
      Rather than try to fix that logic, let's just get rid of it: there is no
      correctness reason to remove "..", and cosmetic concerns can be taken
      care of by a subsequent canonicalize_path() call.  Per bug #6715 from
      Greg Davidson.
      
      Back-patch to all supported branches.  It appears that pre-9.2, this
      function is only used with absolute paths as head arguments, which is why
      we'd not noticed the breakage before.  However, third-party code might be
      expecting this function to work in more general cases, so it seems wise
      to back-patch.
      
      In HEAD and 9.2, also make some minor cosmetic improvements to callers.
      85254199
    • Heikki Linnakangas's avatar
      Revert part of the previous patch that avoided using PLy_elog(). · de479e2e
      Heikki Linnakangas authored
      That caused the plpython_unicode regression test to fail on SQL_ASCII
      encoding, as evidenced by the buildfarm. The reason is that with the patch,
      you don't get the detail in the error message that you got before. That
      detail is actually very informative, so rather than just adjust the expected
      output, let's revert that part of the patch for now to make the buildfarm
      green again, and figure out some other way to avoid the recursion of
      PLy_elog() that doesn't lose the detail.
      de479e2e
    • Heikki Linnakangas's avatar
      Fix mapping of PostgreSQL encodings to Python encodings. · b66de4c6
      Heikki Linnakangas authored
      Windows encodings, "win1252" and so forth, are named differently in Python,
      like "cp1252". Also, if the PyUnicode_AsEncodedString() function call fails
      for some reason, use a plain ereport(), not a PLy_elog(), to report that
      error. That avoids recursion and crash, if PLy_elog() tries to call
      PLyUnicode_Bytes() again.
      
      This fixes bug reported by Asif Naeem. Backpatch down to 9.0, before that
      plpython didn't even try these conversions.
      
      Jan Urbański, with minor comment improvements by me.
      b66de4c6
    • Tom Lane's avatar
      Remove support for using wait3() in place of waitpid(). · fc548b22
      Tom Lane authored
      All Unix-oid platforms that we currently support should have waitpid(),
      since it's in V2 of the Single Unix Spec.  Our git history shows that
      the wait3 code was added to support NextStep, which we officially dropped
      support for as of 9.2.  So get rid of the configure test, and simplify the
      macro spaghetti in reaper().  Per suggestion from Fujii Masao.
      fc548b22
    • Alvaro Herrera's avatar
      pg_upgrade: abstract out copying of files from old cluster to new · 666d494d
      Alvaro Herrera authored
      Currently only pg_clog is copied, but some other directories could need
      the same treatment as well, so create a subroutine to do it.
      
      Extracted from my (somewhat larger) FOR KEY SHARE patch.
      666d494d
    • Magnus Hagander's avatar
      Fix function argument tab completion for schema-qualified or quoted function names · 3644a639
      Magnus Hagander authored
      Dean Rasheed, reviewed by Josh Kupershmidt
      3644a639
    • Bruce Momjian's avatar
      Fix missing regex slash that caused perltidy to get confused on · 539d3875
      Bruce Momjian authored
      copyright.pl.
      
      Backpatch to 9.2.
      539d3875
    • Bruce Momjian's avatar
      Run newly-configured perltidy script on Perl files. · 042d9ffc
      Bruce Momjian authored
      Run on HEAD and 9.2.
      042d9ffc
    • Robert Haas's avatar
      Reduce messages about implicit indexes and sequences to DEBUG1. · d7c73484
      Robert Haas authored
      Per recent discussion on pgsql-hackers, these messages are too
      chatty for most users.
      d7c73484
  10. 04 Jul, 2012 1 commit