Commit d1c96330 authored by Bruce Momjian's avatar Bruce Momjian

Back out LOCK A,B,C patch at Tom's suggestion.

parent eb610fb8
<!-- <!--
$Header: /cvsroot/pgsql/doc/src/sgml/ref/lock.sgml,v 1.25 2001/08/04 19:38:59 momjian Exp $ $Header: /cvsroot/pgsql/doc/src/sgml/ref/lock.sgml,v 1.26 2001/08/04 22:01:38 momjian Exp $
Postgres documentation Postgres documentation
--> -->
...@@ -15,7 +15,7 @@ Postgres documentation ...@@ -15,7 +15,7 @@ Postgres documentation
LOCK LOCK
</refname> </refname>
<refpurpose> <refpurpose>
Explicitly lock a table / tables inside a transaction Explicitly lock a table inside a transaction
</refpurpose> </refpurpose>
</refnamediv> </refnamediv>
<refsynopsisdiv> <refsynopsisdiv>
...@@ -23,8 +23,8 @@ Postgres documentation ...@@ -23,8 +23,8 @@ Postgres documentation
<date>2001-07-09</date> <date>2001-07-09</date>
</refsynopsisdivinfo> </refsynopsisdivinfo>
<synopsis> <synopsis>
LOCK [ TABLE ] <replaceable class="PARAMETER">name</replaceable> [,...] LOCK [ TABLE ] <replaceable class="PARAMETER">name</replaceable>
LOCK [ TABLE ] <replaceable class="PARAMETER">name</replaceable> [,...] IN <replaceable class="PARAMETER">lockmode</replaceable> MODE LOCK [ TABLE ] <replaceable class="PARAMETER">name</replaceable> IN <replaceable class="PARAMETER">lockmode</replaceable> MODE
where <replaceable class="PARAMETER">lockmode</replaceable> is one of: where <replaceable class="PARAMETER">lockmode</replaceable> is one of:
...@@ -373,7 +373,6 @@ ERROR <replaceable class="PARAMETER">name</replaceable>: Table does not exist. ...@@ -373,7 +373,6 @@ ERROR <replaceable class="PARAMETER">name</replaceable>: Table does not exist.
An example for this rule was given previously when discussing the An example for this rule was given previously when discussing the
use of SHARE ROW EXCLUSIVE mode rather than SHARE mode. use of SHARE ROW EXCLUSIVE mode rather than SHARE mode.
</para> </para>
</listitem> </listitem>
</itemizedlist> </itemizedlist>
...@@ -384,12 +383,6 @@ ERROR <replaceable class="PARAMETER">name</replaceable>: Table does not exist. ...@@ -384,12 +383,6 @@ ERROR <replaceable class="PARAMETER">name</replaceable>: Table does not exist.
</para> </para>
</note> </note>
<para>
When locking multiple tables, the command LOCK a, b; is equivalent to LOCK
a; LOCK b;. The tables are locked one-by-one in the order specified in the
<command>LOCK</command> command.
</para>
<refsect2 id="R2-SQL-LOCK-3"> <refsect2 id="R2-SQL-LOCK-3">
<refsect2info> <refsect2info>
<date>1999-06-08</date> <date>1999-06-08</date>
...@@ -413,7 +406,6 @@ ERROR <replaceable class="PARAMETER">name</replaceable>: Table does not exist. ...@@ -413,7 +406,6 @@ ERROR <replaceable class="PARAMETER">name</replaceable>: Table does not exist.
<para> <para>
<command>LOCK</command> works only inside transactions. <command>LOCK</command> works only inside transactions.
</para> </para>
</refsect2> </refsect2>
</refsect1> </refsect1>
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.137 2001/08/04 19:38:59 momjian Exp $ * $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.138 2001/08/04 22:01:38 momjian Exp $
* *
* NOTES * NOTES
* The PerformAddAttribute() code, like most of the relation * The PerformAddAttribute() code, like most of the relation
...@@ -1984,7 +1984,8 @@ needs_toast_table(Relation rel) ...@@ -1984,7 +1984,8 @@ needs_toast_table(Relation rel)
MAXALIGN(data_length); MAXALIGN(data_length);
return (tuple_length > TOAST_TUPLE_THRESHOLD); return (tuple_length > TOAST_TUPLE_THRESHOLD);
} }
/* /*
* *
* LOCK TABLE * LOCK TABLE
...@@ -1993,104 +1994,26 @@ needs_toast_table(Relation rel) ...@@ -1993,104 +1994,26 @@ needs_toast_table(Relation rel)
void void
LockTableCommand(LockStmt *lockstmt) LockTableCommand(LockStmt *lockstmt)
{ {
int relCnt; Relation rel;
int aclresult;
relCnt = length(lockstmt -> rellist);
/* Handle a single relation lock specially to avoid overhead on likely the
most common case */
if(relCnt == 1)
{
/* Locking a single table */
Relation rel;
int aclresult;
char *relname;
relname = strVal(lfirst(lockstmt->rellist));
freeList(lockstmt->rellist);
rel = heap_openr(relname, NoLock);
if (rel->rd_rel->relkind != RELKIND_RELATION)
elog(ERROR, "LOCK TABLE: %s is not a table", relname);
if (lockstmt->mode == AccessShareLock)
aclresult = pg_aclcheck(relname, GetUserId(),
ACL_SELECT);
else
aclresult = pg_aclcheck(relname, GetUserId(),
ACL_UPDATE | ACL_DELETE);
if (aclresult != ACLCHECK_OK)
elog(ERROR, "LOCK TABLE: permission denied");
LockRelation(rel, lockstmt->mode);
pfree(relname);
heap_close(rel, NoLock); /* close rel, keep lock */
}
else
{
List *p;
Relation *RelationArray;
Relation *pRel;
/* Locking multiple tables */
/* Create an array of relations */
RelationArray = palloc(relCnt * sizeof(Relation));
pRel = RelationArray;
/* Iterate over the list and populate the relation array */
foreach(p, lockstmt->rellist)
{
char* relname = strVal(lfirst(p));
int aclresult;
*pRel = heap_openr(relname, NoLock);
if ((*pRel)->rd_rel->relkind != RELKIND_RELATION)
elog(ERROR, "LOCK TABLE: %s is not a table",
relname);
if (lockstmt->mode == AccessShareLock)
aclresult = pg_aclcheck(relname, GetUserId(),
ACL_SELECT);
else
aclresult = pg_aclcheck(relname, GetUserId(),
ACL_UPDATE | ACL_DELETE);
if (aclresult != ACLCHECK_OK)
elog(ERROR, "LOCK TABLE: permission denied");
pRel++; rel = heap_openr(lockstmt->relname, NoLock);
pfree(relname);
}
/* Now, lock all the relations, closing each after it is locked if (rel->rd_rel->relkind != RELKIND_RELATION)
(Keeping the locks) elog(ERROR, "LOCK TABLE: %s is not a table", lockstmt->relname);
*/
for(pRel = RelationArray; if (lockstmt->mode == AccessShareLock)
pRel < RelationArray + relCnt; aclresult = pg_aclcheck(lockstmt->relname, GetUserId(), ACL_SELECT);
pRel++) else
{ aclresult = pg_aclcheck(lockstmt->relname, GetUserId(),
LockRelation(*pRel, lockstmt->mode); ACL_UPDATE | ACL_DELETE);
heap_close(*pRel, NoLock); if (aclresult != ACLCHECK_OK)
} elog(ERROR, "LOCK TABLE: permission denied");
/* Free the relation array */ LockRelation(rel, lockstmt->mode);
pfree(RelationArray); heap_close(rel, NoLock); /* close rel, keep lock */
}
} }
......
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/nodes/copyfuncs.c,v 1.149 2001/08/04 19:38:59 momjian Exp $ * $Header: /cvsroot/pgsql/src/backend/nodes/copyfuncs.c,v 1.150 2001/08/04 22:01:38 momjian Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -2425,8 +2425,8 @@ _copyLockStmt(LockStmt *from) ...@@ -2425,8 +2425,8 @@ _copyLockStmt(LockStmt *from)
{ {
LockStmt *newnode = makeNode(LockStmt); LockStmt *newnode = makeNode(LockStmt);
Node_Copy(from, newnode, rellist); if (from->relname)
newnode->relname = pstrdup(from->relname);
newnode->mode = from->mode; newnode->mode = from->mode;
return newnode; return newnode;
......
...@@ -20,7 +20,7 @@ ...@@ -20,7 +20,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/nodes/equalfuncs.c,v 1.97 2001/08/04 19:38:59 momjian Exp $ * $Header: /cvsroot/pgsql/src/backend/nodes/equalfuncs.c,v 1.98 2001/08/04 22:01:38 momjian Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -1283,7 +1283,7 @@ _equalDropUserStmt(DropUserStmt *a, DropUserStmt *b) ...@@ -1283,7 +1283,7 @@ _equalDropUserStmt(DropUserStmt *a, DropUserStmt *b)
static bool static bool
_equalLockStmt(LockStmt *a, LockStmt *b) _equalLockStmt(LockStmt *a, LockStmt *b)
{ {
if (!equal(a->rellist, b->rellist)) if (!equalstr(a->relname, b->relname))
return false; return false;
if (a->mode != b->mode) if (a->mode != b->mode)
return false; return false;
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.239 2001/08/04 19:38:59 momjian Exp $ * $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.240 2001/08/04 22:01:39 momjian Exp $
* *
* HISTORY * HISTORY
* AUTHOR DATE MAJOR EVENT * AUTHOR DATE MAJOR EVENT
...@@ -3280,11 +3280,11 @@ DeleteStmt: DELETE FROM relation_expr where_clause ...@@ -3280,11 +3280,11 @@ DeleteStmt: DELETE FROM relation_expr where_clause
} }
; ;
LockStmt: LOCK_P opt_table relation_name_list opt_lock LockStmt: LOCK_P opt_table relation_name opt_lock
{ {
LockStmt *n = makeNode(LockStmt); LockStmt *n = makeNode(LockStmt);
n->rellist = $3; n->relname = $3;
n->mode = $4; n->mode = $4;
$$ = (Node *)n; $$ = (Node *)n;
} }
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
* Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $Id: parsenodes.h,v 1.137 2001/08/04 19:38:59 momjian Exp $ * $Id: parsenodes.h,v 1.138 2001/08/04 22:01:39 momjian Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -760,7 +760,7 @@ typedef struct VariableResetStmt ...@@ -760,7 +760,7 @@ typedef struct VariableResetStmt
typedef struct LockStmt typedef struct LockStmt
{ {
NodeTag type; NodeTag type;
List *rellist; /* relations to lock */ char *relname; /* relation to lock */
int mode; /* lock mode */ int mode; /* lock mode */
} LockStmt; } LockStmt;
......
...@@ -2421,7 +2421,7 @@ DeleteStmt: DELETE FROM relation_expr where_clause ...@@ -2421,7 +2421,7 @@ DeleteStmt: DELETE FROM relation_expr where_clause
} }
; ;
LockStmt: LOCK_P opt_table relation_name_list opt_lock LockStmt: LOCK_P opt_table relation_name opt_lock
{ {
$$ = cat_str(4, make_str("lock"), $2, $3, $4); $$ = cat_str(4, make_str("lock"), $2, $3, $4);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment