Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
d1c96330
Commit
d1c96330
authored
Aug 04, 2001
by
Bruce Momjian
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Back out LOCK A,B,C patch at Tom's suggestion.
parent
eb610fb8
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
32 additions
and
117 deletions
+32
-117
doc/src/sgml/ref/lock.sgml
doc/src/sgml/ref/lock.sgml
+4
-12
src/backend/commands/command.c
src/backend/commands/command.c
+17
-94
src/backend/nodes/copyfuncs.c
src/backend/nodes/copyfuncs.c
+3
-3
src/backend/nodes/equalfuncs.c
src/backend/nodes/equalfuncs.c
+2
-2
src/backend/parser/gram.y
src/backend/parser/gram.y
+3
-3
src/include/nodes/parsenodes.h
src/include/nodes/parsenodes.h
+2
-2
src/interfaces/ecpg/preproc/preproc.y
src/interfaces/ecpg/preproc/preproc.y
+1
-1
No files found.
doc/src/sgml/ref/lock.sgml
View file @
d1c96330
<!--
$Header: /cvsroot/pgsql/doc/src/sgml/ref/lock.sgml,v 1.2
5 2001/08/04 19:38:59
momjian Exp $
$Header: /cvsroot/pgsql/doc/src/sgml/ref/lock.sgml,v 1.2
6 2001/08/04 22:01:38
momjian Exp $
Postgres documentation
-->
...
...
@@ -15,7 +15,7 @@ Postgres documentation
LOCK
</refname>
<refpurpose>
Explicitly lock a table
/ tables
inside a transaction
Explicitly lock a table inside a transaction
</refpurpose>
</refnamediv>
<refsynopsisdiv>
...
...
@@ -23,8 +23,8 @@ Postgres documentation
<date>2001-07-09</date>
</refsynopsisdivinfo>
<synopsis>
LOCK [ TABLE ] <replaceable class="PARAMETER">name</replaceable>
[,...]
LOCK [ TABLE ] <replaceable class="PARAMETER">name</replaceable>
[,...]
IN <replaceable class="PARAMETER">lockmode</replaceable> MODE
LOCK [ TABLE ] <replaceable class="PARAMETER">name</replaceable>
LOCK [ TABLE ] <replaceable class="PARAMETER">name</replaceable> IN <replaceable class="PARAMETER">lockmode</replaceable> MODE
where <replaceable class="PARAMETER">lockmode</replaceable> is one of:
...
...
@@ -373,7 +373,6 @@ ERROR <replaceable class="PARAMETER">name</replaceable>: Table does not exist.
An example for this rule was given previously when discussing the
use of SHARE ROW EXCLUSIVE mode rather than SHARE mode.
</para>
</listitem>
</itemizedlist>
...
...
@@ -384,12 +383,6 @@ ERROR <replaceable class="PARAMETER">name</replaceable>: Table does not exist.
</para>
</note>
<para>
When locking multiple tables, the command LOCK a, b; is equivalent to LOCK
a; LOCK b;. The tables are locked one-by-one in the order specified in the
<command>LOCK</command> command.
</para>
<refsect2 id="R2-SQL-LOCK-3">
<refsect2info>
<date>1999-06-08</date>
...
...
@@ -413,7 +406,6 @@ ERROR <replaceable class="PARAMETER">name</replaceable>: Table does not exist.
<para>
<command>LOCK</command> works only inside transactions.
</para>
</refsect2>
</refsect1>
...
...
src/backend/commands/command.c
View file @
d1c96330
...
...
@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.13
7 2001/08/04 19:38:59
momjian Exp $
* $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.13
8 2001/08/04 22:01:38
momjian Exp $
*
* NOTES
* The PerformAddAttribute() code, like most of the relation
...
...
@@ -1984,7 +1984,8 @@ needs_toast_table(Relation rel)
MAXALIGN
(
data_length
);
return
(
tuple_length
>
TOAST_TUPLE_THRESHOLD
);
}
/*
*
* LOCK TABLE
...
...
@@ -1993,104 +1994,26 @@ needs_toast_table(Relation rel)
void
LockTableCommand
(
LockStmt
*
lockstmt
)
{
int
relCnt
;
relCnt
=
length
(
lockstmt
->
rellist
);
/* Handle a single relation lock specially to avoid overhead on likely the
most common case */
if
(
relCnt
==
1
)
{
/* Locking a single table */
Relation
rel
;
int
aclresult
;
char
*
relname
;
relname
=
strVal
(
lfirst
(
lockstmt
->
rellist
));
freeList
(
lockstmt
->
rellist
);
rel
=
heap_openr
(
relname
,
NoLock
);
if
(
rel
->
rd_rel
->
relkind
!=
RELKIND_RELATION
)
elog
(
ERROR
,
"LOCK TABLE: %s is not a table"
,
relname
);
if
(
lockstmt
->
mode
==
AccessShareLock
)
aclresult
=
pg_aclcheck
(
relname
,
GetUserId
(),
ACL_SELECT
);
else
aclresult
=
pg_aclcheck
(
relname
,
GetUserId
(),
ACL_UPDATE
|
ACL_DELETE
);
if
(
aclresult
!=
ACLCHECK_OK
)
elog
(
ERROR
,
"LOCK TABLE: permission denied"
);
LockRelation
(
rel
,
lockstmt
->
mode
);
pfree
(
relname
);
heap_close
(
rel
,
NoLock
);
/* close rel, keep lock */
}
else
{
List
*
p
;
Relation
*
RelationArray
;
Relation
*
pRel
;
/* Locking multiple tables */
/* Create an array of relations */
RelationArray
=
palloc
(
relCnt
*
sizeof
(
Relation
));
pRel
=
RelationArray
;
/* Iterate over the list and populate the relation array */
foreach
(
p
,
lockstmt
->
rellist
)
{
char
*
relname
=
strVal
(
lfirst
(
p
));
int
aclresult
;
*
pRel
=
heap_openr
(
relname
,
NoLock
);
if
((
*
pRel
)
->
rd_rel
->
relkind
!=
RELKIND_RELATION
)
elog
(
ERROR
,
"LOCK TABLE: %s is not a table"
,
relname
);
if
(
lockstmt
->
mode
==
AccessShareLock
)
aclresult
=
pg_aclcheck
(
relname
,
GetUserId
(),
ACL_SELECT
);
else
aclresult
=
pg_aclcheck
(
relname
,
GetUserId
(),
ACL_UPDATE
|
ACL_DELETE
);
if
(
aclresult
!=
ACLCHECK_OK
)
elog
(
ERROR
,
"LOCK TABLE: permission denied"
);
Relation
rel
;
int
aclresult
;
pRel
++
;
pfree
(
relname
);
}
rel
=
heap_openr
(
lockstmt
->
relname
,
NoLock
);
/* Now, lock all the relations, closing each after it is locked
(Keeping the locks)
*/
if
(
rel
->
rd_rel
->
relkind
!=
RELKIND_RELATION
)
elog
(
ERROR
,
"LOCK TABLE: %s is not a table"
,
lockstmt
->
relname
);
for
(
pRel
=
RelationArray
;
pRel
<
RelationArray
+
relCnt
;
pRel
++
)
{
LockRelation
(
*
pRel
,
lockstmt
->
mode
);
if
(
lockstmt
->
mode
==
AccessShareLock
)
aclresult
=
pg_aclcheck
(
lockstmt
->
relname
,
GetUserId
(),
ACL_SELECT
)
;
else
aclresult
=
pg_aclcheck
(
lockstmt
->
relname
,
GetUserId
(),
ACL_UPDATE
|
ACL_DELETE
);
heap_close
(
*
pRel
,
NoLock
);
}
if
(
aclresult
!=
ACLCHECK_OK
)
elog
(
ERROR
,
"LOCK TABLE: permission denied"
);
/* Free the relation array */
LockRelation
(
rel
,
lockstmt
->
mode
);
pfree
(
RelationArray
);
}
heap_close
(
rel
,
NoLock
);
/* close rel, keep lock */
}
...
...
src/backend/nodes/copyfuncs.c
View file @
d1c96330
...
...
@@ -15,7 +15,7 @@
* Portions Copyright (c) 1994, Regents of the University of California
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/nodes/copyfuncs.c,v 1.1
49 2001/08/04 19:38:59
momjian Exp $
* $Header: /cvsroot/pgsql/src/backend/nodes/copyfuncs.c,v 1.1
50 2001/08/04 22:01:38
momjian Exp $
*
*-------------------------------------------------------------------------
*/
...
...
@@ -2425,8 +2425,8 @@ _copyLockStmt(LockStmt *from)
{
LockStmt
*
newnode
=
makeNode
(
LockStmt
);
Node_Copy
(
from
,
newnode
,
rellist
);
if
(
from
->
relname
)
newnode
->
relname
=
pstrdup
(
from
->
relname
);
newnode
->
mode
=
from
->
mode
;
return
newnode
;
...
...
src/backend/nodes/equalfuncs.c
View file @
d1c96330
...
...
@@ -20,7 +20,7 @@
* Portions Copyright (c) 1994, Regents of the University of California
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/nodes/equalfuncs.c,v 1.9
7 2001/08/04 19:38:59
momjian Exp $
* $Header: /cvsroot/pgsql/src/backend/nodes/equalfuncs.c,v 1.9
8 2001/08/04 22:01:38
momjian Exp $
*
*-------------------------------------------------------------------------
*/
...
...
@@ -1283,7 +1283,7 @@ _equalDropUserStmt(DropUserStmt *a, DropUserStmt *b)
static
bool
_equalLockStmt
(
LockStmt
*
a
,
LockStmt
*
b
)
{
if
(
!
equal
(
a
->
rellist
,
b
->
rellist
))
if
(
!
equal
str
(
a
->
relname
,
b
->
relname
))
return
false
;
if
(
a
->
mode
!=
b
->
mode
)
return
false
;
...
...
src/backend/parser/gram.y
View file @
d1c96330
...
...
@@ -11,7 +11,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.2
39 2001/08/04 19:38:5
9 momjian Exp $
* $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.2
40 2001/08/04 22:01:3
9 momjian Exp $
*
* HISTORY
* AUTHOR DATE MAJOR EVENT
...
...
@@ -3280,11 +3280,11 @@ DeleteStmt: DELETE FROM relation_expr where_clause
}
;
LockStmt: LOCK_P opt_table relation_name
_list
opt_lock
LockStmt: LOCK_P opt_table relation_name opt_lock
{
LockStmt *n = makeNode(LockStmt);
n->rel
list
= $3;
n->rel
name
= $3;
n->mode = $4;
$$ = (Node *)n;
}
...
...
src/include/nodes/parsenodes.h
View file @
d1c96330
...
...
@@ -7,7 +7,7 @@
* Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
* $Id: parsenodes.h,v 1.13
7 2001/08/04 19:38:5
9 momjian Exp $
* $Id: parsenodes.h,v 1.13
8 2001/08/04 22:01:3
9 momjian Exp $
*
*-------------------------------------------------------------------------
*/
...
...
@@ -760,7 +760,7 @@ typedef struct VariableResetStmt
typedef
struct
LockStmt
{
NodeTag
type
;
List
*
rellist
;
/* relations
to lock */
char
*
relname
;
/* relation
to lock */
int
mode
;
/* lock mode */
}
LockStmt
;
...
...
src/interfaces/ecpg/preproc/preproc.y
View file @
d1c96330
...
...
@@ -2421,7 +2421,7 @@ DeleteStmt: DELETE FROM relation_expr where_clause
}
;
LockStmt: LOCK_P opt_table relation_name
_list
opt_lock
LockStmt: LOCK_P opt_table relation_name opt_lock
{
$$ = cat_str(4, make_str("lock"), $2, $3, $4);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment