Commit c015ccb3 authored by Tom Lane's avatar Tom Lane

Make PostgresNode.pm's poll_query_until() more chatty about failures.

Reporting only the stderr is unhelpful when the problem is that the
server output we're getting doesn't match what was expected.  So we
should report the query output too; and just for good measure, let's
print the query we used and the output we expected.

Back-patch to 9.5 where poll_query_until was introduced.

Discussion: https://postgr.es/m/17913.1539634756@sss.pgh.pa.us
parent 17d6a8fb
...@@ -1369,9 +1369,18 @@ sub poll_query_until ...@@ -1369,9 +1369,18 @@ sub poll_query_until
$attempts++; $attempts++;
} }
# The query result didn't change in 180 seconds. Give up. Print the stderr # The query result didn't change in 180 seconds. Give up. Print the
# from the last attempt, hopefully that's useful for debugging. # output from the last attempt, hopefully that's useful for debugging.
diag $stderr; chomp($stderr);
$stderr =~ s/\r//g if $TestLib::windows_os;
diag qq(poll_query_until timed out executing this query:
$query
expecting this output:
$expected
last actual query output:
$stdout
with stderr:
$stderr);
return 0; return 0;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment