Skip to content

P
Postgres FD Implementation
Commit 329de9fa authored by Heikki Linnakangas's avatar Heikki Linnakangas
Browse files
Options

Don't leak memory after connection aborts in pg_recvlogical. 

Andres Freund, noticed by coverity.
parent c8345768
Hide whitespace changes
Inline Side-by-side
Showing with 5 additions and 3 deletions
src/bin/pg_basebackup/pg_recvlogical.c
View file @ 329de9fa
...@@ -547,9 +547,6 @@ StreamLog(void) ...@@ -547,9 +547,6 @@ StreamLog(void)
} }
PQclear(res); PQclear(res);
if (copybuf != NULL)
PQfreemem(copybuf);
if (outfd != -1 && strcmp(outfile, "-") != 0) if (outfd != -1 && strcmp(outfile, "-") != 0)
{ {
int64 t = feGetCurrentTimestamp(); int64 t = feGetCurrentTimestamp();
...@@ -563,6 +560,11 @@ StreamLog(void) ...@@ -563,6 +560,11 @@ StreamLog(void)
} }
outfd = -1; outfd = -1;
error: error:
if (copybuf != NULL)
{
PQfreemem(copybuf);
copybuf = NULL;
}
destroyPQExpBuffer(query); destroyPQExpBuffer(query);
PQfinish(conn); PQfinish(conn);
conn = NULL; conn = NULL;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment