Don't leak memory after connection aborts in pg_recvlogical.

Andres Freund, noticed by coverity.

Don't leak memory after connection aborts in pg_recvlogical.
Andres Freund, noticed by coverity.
329de9fa · Heikki Linnakangas · c8345768 · 329de9fa
Commit 329de9fa authored May 05, 2014 by Heikki Linnakangas
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

src/bin/pg_basebackup/pg_recvlogical.c src/bin/pg_basebackup/pg_recvlogical.c +5 -3

No files found.
--- a/src/bin/pg_basebackup/pg_recvlogical.c
+++ b/src/bin/pg_basebackup/pg_recvlogical.c
@@ -547,9 +547,6 @@ StreamLog(void)
 	}
 	PQclear(res);

-	if (copybuf != NULL)
-		PQfreemem(copybuf);
-
 	if (outfd != -1 && strcmp(outfile, "-") != 0)
 	{
 		int64 t = feGetCurrentTimestamp();
@@ -563,6 +560,11 @@ StreamLog(void)
 	}
 	outfd = -1;
 error:
+	if (copybuf != NULL)
+	{
+		PQfreemem(copybuf);
+		copybuf = NULL;
+	}
 	destroyPQExpBuffer(query);
 	PQfinish(conn);
 	conn = NULL;