Commit 1a3e82a7 authored by Alvaro Herrera's avatar Alvaro Herrera

Restore some comments lost during 15732b34

Michael Paquier
parent a3b4aeec
...@@ -1446,9 +1446,11 @@ index_drop(Oid indexId, bool concurrent) ...@@ -1446,9 +1446,11 @@ index_drop(Oid indexId, bool concurrent)
/* /*
* Now we must wait until no running transaction could be using the * Now we must wait until no running transaction could be using the
* index for a query. Note we do not need to worry about xacts that * index for a query. Use AccessExclusiveLock here to check for
* open the table for reading after this point; they will see the * running transactions that hold locks of any kind on the table.
* index as invalid when they open the relation. * Note we do not need to worry about xacts that open the table for
* reading after this point; they will see the index as invalid when
* they open the relation.
* *
* Note: the reason we use actual lock acquisition here, rather than * Note: the reason we use actual lock acquisition here, rather than
* just checking the ProcArray and sleeping, is that deadlock is * just checking the ProcArray and sleeping, is that deadlock is
......
...@@ -651,9 +651,10 @@ DefineIndex(IndexStmt *stmt, ...@@ -651,9 +651,10 @@ DefineIndex(IndexStmt *stmt,
* for an overview of how this works) * for an overview of how this works)
* *
* Now we must wait until no running transaction could have the table open * Now we must wait until no running transaction could have the table open
* with the old list of indexes. Note we do not need to worry about xacts * with the old list of indexes. Use ShareLock to consider running
* that open the table for writing after this point; they will see the new * transactions that hold locks that permit writing to the table. Note we
* index when they open it. * do not need to worry about xacts that open the table for writing after
* this point; they will see the new index when they open it.
* *
* Note: the reason we use actual lock acquisition here, rather than just * Note: the reason we use actual lock acquisition here, rather than just
* checking the ProcArray and sleeping, is that deadlock is possible if * checking the ProcArray and sleeping, is that deadlock is possible if
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment