Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
1a3e82a7
Commit
1a3e82a7
authored
Jan 03, 2014
by
Alvaro Herrera
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Restore some comments lost during
15732b34
Michael Paquier
parent
a3b4aeec
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
6 deletions
+9
-6
src/backend/catalog/index.c
src/backend/catalog/index.c
+5
-3
src/backend/commands/indexcmds.c
src/backend/commands/indexcmds.c
+4
-3
No files found.
src/backend/catalog/index.c
View file @
1a3e82a7
...
...
@@ -1446,9 +1446,11 @@ index_drop(Oid indexId, bool concurrent)
/*
* Now we must wait until no running transaction could be using the
* index for a query. Note we do not need to worry about xacts that
* open the table for reading after this point; they will see the
* index as invalid when they open the relation.
* index for a query. Use AccessExclusiveLock here to check for
* running transactions that hold locks of any kind on the table.
* Note we do not need to worry about xacts that open the table for
* reading after this point; they will see the index as invalid when
* they open the relation.
*
* Note: the reason we use actual lock acquisition here, rather than
* just checking the ProcArray and sleeping, is that deadlock is
...
...
src/backend/commands/indexcmds.c
View file @
1a3e82a7
...
...
@@ -651,9 +651,10 @@ DefineIndex(IndexStmt *stmt,
* for an overview of how this works)
*
* Now we must wait until no running transaction could have the table open
* with the old list of indexes. Note we do not need to worry about xacts
* that open the table for writing after this point; they will see the new
* index when they open it.
* with the old list of indexes. Use ShareLock to consider running
* transactions that hold locks that permit writing to the table. Note we
* do not need to worry about xacts that open the table for writing after
* this point; they will see the new index when they open it.
*
* Note: the reason we use actual lock acquisition here, rather than just
* checking the ProcArray and sleeping, is that deadlock is possible if
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment