• Tom Lane's avatar
    Fix multiple crasher bugs in partitioned-table replication logic. · ab55d742
    Tom Lane authored
    apply_handle_tuple_routing(), having detected and reported that
    the tuple it needed to update didn't exist, tried to update that
    tuple anyway, leading to a null-pointer dereference.
    
    logicalrep_partition_open() failed to ensure that the
    LogicalRepPartMapEntry it built for a partition was fully
    independent of that for the partition root, leading to
    trouble if the root entry was later freed or rebuilt.
    
    Meanwhile, on the publisher's side, pgoutput_change() sometimes
    attempted to apply execute_attr_map_tuple() to a NULL tuple.
    
    The first of these was reported by Sergey Bernikov in bug #17055;
    I found the other two while developing some test cases for this
    sadly under-tested code.
    
    Diagnosis and patch for the first issue by Amit Langote; patches
    for the others by me; new test cases by me.  Back-patch to v13
    where this logic came in.
    
    Discussion: https://postgr.es/m/17055-9ba800ec8522668b@postgresql.org
    ab55d742
worker.c 86.6 KB