• Andres Freund's avatar
    Fix transient mdsync() errors of truncated relations due to 72a98a63. · a7124870
    Andres Freund authored
    Unfortunately the segment size checks from 72a98a63 had the negative
    side-effect of breaking a corner case in mdsync(): When processing a
    fsync request for a truncated away segment mdsync() could fail with
    "could not fsync file" (if previous segment < RELSEG_SIZE) because
    _mdfd_getseg() now wouldn't return the relevant segment anymore.
    
    The cleanest fix seems to be to allow the caller of _mdfd_getseg() to
    specify whether checks for RELSEG_SIZE are performed. To allow doing so,
    change the ExtensionBehavior enum into a bitmask. Besides allowing for
    the addition of EXTENSION_DONT_CHECK_SIZE, this makes for a nicer
    implementation of EXTENSION_REALLY_RETURN_NULL.
    
    Besides mdsync() the only callsite that should change behaviour due to
    this is mdprefetch() which now doesn't create segments anymore, even in
    recovery. Given the uses of mdprefetch() that seems better.
    
    Reported-By: Thom Brown
    Discussion: CAA-aLv72QazLvPdKZYpVn4a_Eh+i4_cxuB03k+iCuZM_xjc+6Q@mail.gmail.com
    a7124870
md.c 58.4 KB