• Alvaro Herrera's avatar
    Revise attribute handling code on partition creation · 705d433f
    Alvaro Herrera authored
    The original code to propagate NOT NULL and default expressions
    specified when creating a partition was mostly copy-pasted from
    typed-tables creation, but not being a great match it contained some
    duplicity, inefficiency and bugs.
    
    This commit fixes the bug that NOT NULL constraints declared in the
    parent table would not be honored in the partition.  One reported issue
    that is not fixed is that a DEFAULT declared in the child is not used
    when inserting through the parent.  That would amount to a behavioral
    change that's better not back-patched.
    
    This rewrite makes the code simpler:
    
    1. instead of checking for duplicate column names in its own block,
    reuse the original one that already did that;
    
    2. instead of concatenating the list of columns from parent and the one
    declared in the partition and scanning the result to (incorrectly)
    propagate defaults and not-null constraints, just scan the latter
    searching the former for a match, and merging sensibly.  This works
    because we know the list in the parent is already correct and there can
    only be one parent.
    
    This rewrite makes ColumnDef->is_from_parent unused, so it's removed
    on branch master; on released branches, it's kept as an unused field in
    order not to cause ABI incompatibilities.
    
    This commit also adds a test case for creating partitions with
    collations mismatching that on the parent table, something that is
    closely related to the code being patched.  No code change is introduced
    though, since that'd be a behavior change that could break some (broken)
    working applications.
    
    Amit Langote wrote a less invasive fix for the original
    NOT NULL/defaults bug, but while I kept the tests he added, I ended up
    not using his original code.  Ashutosh Bapat reviewed Amit's fix.  Amit
    reviewed mine.
    
    Author: Álvaro Herrera, Amit Langote
    Reviewed-by: Ashutosh Bapat, Amit Langote
    Reported-by: Jürgen Strobel (bug #15212)
    Discussion: https://postgr.es/m/152746742177.1291.9847032632907407358@wrigleys.postgresql.org
    705d433f
outfuncs.c 102 KB