Commit 140778d4 authored by Yuxin Wu's avatar Yuxin Wu

update docs

parent c9fde630
...@@ -226,6 +226,7 @@ class DistributedTrainerBase(SingleCostTrainer): ...@@ -226,6 +226,7 @@ class DistributedTrainerBase(SingleCostTrainer):
get_distributed_session_creator(self.server), session_init) get_distributed_session_creator(self.server), session_init)
# This is slow. deprecated in favor of horovod
class DistributedTrainerParameterServer(DistributedTrainerBase): class DistributedTrainerParameterServer(DistributedTrainerBase):
__doc__ = DistributedParameterServerBuilder.__doc__ __doc__ = DistributedParameterServerBuilder.__doc__
...@@ -253,6 +254,7 @@ class DistributedTrainerParameterServer(DistributedTrainerBase): ...@@ -253,6 +254,7 @@ class DistributedTrainerParameterServer(DistributedTrainerBase):
return [] return []
# This is slow. deprecated in favor of horovod
class DistributedTrainerReplicated(DistributedTrainerBase): class DistributedTrainerReplicated(DistributedTrainerBase):
__doc__ = DistributedReplicatedBuilder.__doc__ __doc__ = DistributedReplicatedBuilder.__doc__
...@@ -275,7 +277,7 @@ class DistributedTrainerReplicated(DistributedTrainerBase): ...@@ -275,7 +277,7 @@ class DistributedTrainerReplicated(DistributedTrainerBase):
def _setup_input(self, input_signature, input): def _setup_input(self, input_signature, input):
with override_to_local_variable(): with override_to_local_variable():
get_global_step_var() # gs should be local get_global_step_var() # gs should be local
# input source may create variable (queue size summary) # input source may create variables (queue size summary)
# TODO This is not good because we don't know from here # TODO This is not good because we don't know from here
# whether something should be global or local. We now assume # whether something should be global or local. We now assume
# they should be local. # they should be local.
......
...@@ -237,7 +237,7 @@ def start_proc_mask_signal(proc): ...@@ -237,7 +237,7 @@ def start_proc_mask_signal(proc):
if isinstance(p, mp.Process): if isinstance(p, mp.Process):
if sys.version_info < (3, 4) or mp.get_start_method() == 'fork': if sys.version_info < (3, 4) or mp.get_start_method() == 'fork':
log_once( log_once(
"Starting a process with 'fork' method is not safe and may consume unnecessary extra memory." "Starting a process with 'fork' method is not safe and may consume unnecessary extra CPU memory."
" Use 'forkserver/spawn' method (available after Py3.4) instead if you run into any issues. " " Use 'forkserver/spawn' method (available after Py3.4) instead if you run into any issues. "
"See https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods", "See https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods",
'warn') # noqa 'warn') # noqa
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment