bug fixes

rss-email.py

@@ -13,7 +13,7 @@ from bs4 import BeautifulSoup
 import rssemailconfig
 
 feed            = {'file': 'feed.pickle'}
-mail            = {'from': 'Murukesh Mohanan <murukesh@cse.iitb.ac.in>'}
+mail            = {'from': 'Murukesh Mohanan <murukesh@cse.iitb.ac.in>', 'title': ''}
 smtp            = {}
 old_entries     = set()
 
@@ -27,8 +27,9 @@ def get_new_posts ():
     post_ids = [post.id for post in current_entries]
 
     try:
-        old_entries = pickle.load (open(feed['file'], 'br'))
+        old_entries = pickle.load (open(feed['file'], 'rb'))
     except (EOFError, FileNotFoundError):
+        print ("No old posts.\n")
         old_entries = set()
 
     new_post_ids = set (id for id in post_ids if id not in old_entries)
@@ -37,33 +38,34 @@ def get_new_posts ():
 
 def convert_post_to_email (post):
     msg = MIMEMultipart('alternative')
-    msg['Subject'] = mail['prefix'] + post.title
+    msg['Subject'] = ': '.join([mail['prefix'], post.title])
     msg['From'] = mail['from']
     msg['To'] = mail['to']
     part1 = MIMEText(BeautifulSoup(post['summary']).get_text(), 'plain')
-    html_email = post['summary'] + '<br><hr><a target="_blank" href="' + post['id'] + '">' + post['id'] + '</a>'
+    html_email = '{:s}<br><hr><a,target="_blank",href="{:s}">{:s}</a>'.format (post['summary'], post['id'], post['id'])
     part2 = MIMEText(html_email, 'html')
     msg.attach(part1)
     msg.attach(part2)
     return msg
 
-def mail_feed (feed):
-    smtp = SMTP(smtp_url)
-    smtp.starttls()
-    smtp.login(*smtp_creds)
+def mail_posts (posts):
+    smtp_server = SMTP(smtp['url'])
+    smtp_server.starttls()
+    smtp_server.login(*smtp['creds'])
     bad_posts = set()
-    for post in feed:
+    for post in posts:
         msg = convert_post_to_email (post)
         try:
-            smtp.send_message(msg)
+            smtp_server.send_message(msg)
         except:
             bad_posts.add(post.id)
     return bad_posts
 
-def save_sent_posts (feed, bad_posts):
-    old_entries.update(post.id for post in feed if post.id not in bad_posts)
-    with open (feed_file, 'bw') as f:
+def save_sent_posts (new_posts, bad_posts):
+    old_entries.update (post.id for post in new_posts if post.id not in bad_posts)
+    with open (feed['file'], 'wb') as f:
         pickle.dump (old_entries, f)
+        print (old_entries)
     return
 
 if __name__ == "__main__":
@@ -71,5 +73,5 @@ if __name__ == "__main__":
     if len(new_posts) == 0:
         print ("No new posts.")
         sys.exit(0)
-    bad_posts =  mail_feed (new_posts)
+    bad_posts =  mail_posts (new_posts)
     save_sent_posts (new_posts, bad_posts)

rssemailconfig.example.py

@@ -14,4 +14,4 @@ smtp['url']	= 'smtp-auth.iitb.ac.in'
 smtp['creds'] = ['murukesh', 'password']
 
 mail['to'] = 'murukesh.mohanan@gmail.com'
-
+mail['prefix'] = 'IITB Placement Blog'