1. 24 May, 2009 1 commit
    • Tom Lane's avatar
      Fix LIKE's special-case code for % followed by _. I'm not entirely sure that · fc2660fc
      Tom Lane authored
      this case is worth a special code path, but a special code path that gets
      the boundary condition wrong is definitely no good.  Per bug #4821 from
      Andrew Gierth.
      
      In passing, clean up some minor code formatting issues (excess parentheses
      and blank lines in odd places).
      
      Back-patch to 8.3, where the bug was introduced.
      fc2660fc
  2. 21 May, 2009 3 commits
  3. 20 May, 2009 5 commits
  4. 19 May, 2009 3 commits
  5. 18 May, 2009 5 commits
  6. 16 May, 2009 4 commits
  7. 15 May, 2009 2 commits
  8. 14 May, 2009 7 commits
  9. 13 May, 2009 3 commits
    • Tom Lane's avatar
      Add checks to DefineQueryRewrite() to prohibit attaching rules to relations · a7107136
      Tom Lane authored
      that aren't RELKIND_RELATION or RELKIND_VIEW, and to disallow attaching rules
      to system relations unless allowSystemTableMods is on.  This is to make the
      behavior of CREATE RULE more like CREATE TRIGGER, which disallows the
      comparable cases.  Per discussion of bug #4808.
      a7107136
    • Tom Lane's avatar
    • Tom Lane's avatar
      Rewrite xml.c's memory management (yet again). Give up on the idea of · 23543c73
      Tom Lane authored
      redirecting libxml's allocations into a Postgres context.  Instead, just let
      it use malloc directly, and add PG_TRY blocks as needed to be sure we release
      libxml data structures in error recovery code paths.  This is ugly but seems
      much more likely to play nicely with third-party uses of libxml, as seen in
      recent trouble reports about using Perl XML facilities in pl/perl and bug
      #4774 about contrib/xml2.
      
      I left the code for allocation redirection in place, but it's only
      built/used if you #define USE_LIBXMLCONTEXT.  This is because I found it
      useful to corral libxml's allocations in a palloc context when hunting
      for libxml memory leaks, and we're surely going to have more of those
      in the future with this type of approach.  But we don't want it turned on
      in a normal build because it breaks exactly what we need to fix.
      
      I have not re-indented most of the code sections that are now wrapped
      by PG_TRY(); that's for ease of review.  pg_indent will fix it.
      
      This is a pre-existing bug in 8.3, but I don't dare back-patch this change
      until it's gotten a reasonable amount of field testing.
      23543c73
  10. 12 May, 2009 5 commits
    • Tom Lane's avatar
      Update release notes for changes through 2009-05-11. Also some minor · db6e0b2d
      Tom Lane authored
      copy-editing and reordering of items.
      db6e0b2d
    • Tom Lane's avatar
      Fix intratransaction memory leaks in xml_recv, xmlconcat, xmlroot, and · 546454f8
      Tom Lane authored
      xml_parse, all arising from the same sloppy usage of parse_xml_decl.
      The original coding had that function returning its output string
      parameters in the libxml context, which is long-lived, and all but one
      of its callers neglected to free the strings afterwards.  The easiest
      and most bulletproof fix is to return the strings in the local palloc
      context instead, since that's short-lived.  This was only costing a
      dozen or two bytes per function call, but that adds up fast if the
      function is called repeatedly ...
      
      Noted while poking at the more general problem of what to do with our
      libxml memory allocation hooks.  Back-patch to 8.3, which has the
      identical coding.
      546454f8
    • Tom Lane's avatar
      Fix LOCK TABLE to eliminate the race condition that could make it give weird · f23bdda3
      Tom Lane authored
      errors when tables are concurrently dropped.  To do this we must take lock
      on each relation before we check its privileges.  The old code was trying
      to do that the other way around, which is a bit pointless when there are lots
      of other commands that lock relations before checking privileges.  I did keep
      it checking each relation's privilege before locking the next relation, which
      is a detail that ALTER TABLE isn't too picky about.
      f23bdda3
    • Tom Lane's avatar
      Modify find_inheritance_children() and find_all_inheritors() to add the · d4a363cd
      Tom Lane authored
      ability to lock relations as they scan pg_inherits, and to ignore any
      relations that have disappeared by the time we get lock on them.  This
      makes uses of these functions safe against concurrent DROP operations
      on child tables: we will effectively ignore any just-dropped child,
      rather than possibly throwing an error as in recent bug report from
      Thomas Johansson (and similar past complaints).  The behavior should
      not change otherwise, since the code was acquiring those same locks
      anyway, just a little bit later.
      
      An exception is LockTableCommand(), which is still behaving unsafely;
      but that seems to require some more discussion before we change it.
      d4a363cd
    • Tom Lane's avatar
      Do some minor code refactoring in preparation for changing the APIs of · 0ada5591
      Tom Lane authored
      find_inheritance_children() and find_all_inheritors().  I got annoyed that
      these are buried inside the planner but mostly used elsewhere.  So, create
      a new file catalog/pg_inherits.c and put them there, along with a couple
      of other functions that search pg_inherits.
      
      The code that modifies pg_inherits is (still) in tablecmds.c --- it's
      kind of entangled with unrelated code that modifies pg_depend and other
      stuff, so pulling it out seemed like a bigger change than I wanted to make
      right now.  But this file provides a natural home for it if anyone ever
      gets around to that.
      
      This commit just moves code around; it doesn't change anything, except
      I succumbed to the temptation to make a couple of trivial optimizations
      in typeInheritsFrom().
      0ada5591
  11. 11 May, 2009 2 commits
    • Tom Lane's avatar
      Partially revert my patch of 2008-11-12 that installed a limit on the number · 6480c143
      Tom Lane authored
      of AND/OR clause branches that predtest.c would attempt to deal with.  As
      noted in bug #4721, that change disabled proof attempts for sizes of problems
      that people are actually expecting it to work for.  The original complaint
      it was trying to solve was O(N^2) behavior for long IN-lists, so let's try
      applying the limit to just ScalarArrayOpExprs rather than everything.
      Another case of "foolish consistency" I fear.
      
      Back-patch to 8.2, same as the previous patch was.
      6480c143
    • Magnus Hagander's avatar
      Move crypt auth comment to proper section. · e54ec923
      Magnus Hagander authored
      Add some details about the name=value format of auth options.
      e54ec923