1. 27 May, 2009 2 commits
  2. 26 May, 2009 4 commits
  3. 24 May, 2009 2 commits
  4. 21 May, 2009 3 commits
  5. 20 May, 2009 5 commits
  6. 19 May, 2009 3 commits
  7. 18 May, 2009 5 commits
  8. 16 May, 2009 4 commits
  9. 15 May, 2009 2 commits
  10. 14 May, 2009 7 commits
  11. 13 May, 2009 3 commits
    • Tom Lane's avatar
      Add checks to DefineQueryRewrite() to prohibit attaching rules to relations · a7107136
      Tom Lane authored
      that aren't RELKIND_RELATION or RELKIND_VIEW, and to disallow attaching rules
      to system relations unless allowSystemTableMods is on.  This is to make the
      behavior of CREATE RULE more like CREATE TRIGGER, which disallows the
      comparable cases.  Per discussion of bug #4808.
      a7107136
    • Tom Lane's avatar
    • Tom Lane's avatar
      Rewrite xml.c's memory management (yet again). Give up on the idea of · 23543c73
      Tom Lane authored
      redirecting libxml's allocations into a Postgres context.  Instead, just let
      it use malloc directly, and add PG_TRY blocks as needed to be sure we release
      libxml data structures in error recovery code paths.  This is ugly but seems
      much more likely to play nicely with third-party uses of libxml, as seen in
      recent trouble reports about using Perl XML facilities in pl/perl and bug
      #4774 about contrib/xml2.
      
      I left the code for allocation redirection in place, but it's only
      built/used if you #define USE_LIBXMLCONTEXT.  This is because I found it
      useful to corral libxml's allocations in a palloc context when hunting
      for libxml memory leaks, and we're surely going to have more of those
      in the future with this type of approach.  But we don't want it turned on
      in a normal build because it breaks exactly what we need to fix.
      
      I have not re-indented most of the code sections that are now wrapped
      by PG_TRY(); that's for ease of review.  pg_indent will fix it.
      
      This is a pre-existing bug in 8.3, but I don't dare back-patch this change
      until it's gotten a reasonable amount of field testing.
      23543c73