1. 11 Jul, 2006 6 commits
  2. 10 Jul, 2006 15 commits
  3. 08 Jul, 2006 1 commit
  4. 06 Jul, 2006 5 commits
    • Bruce Momjian's avatar
      Add index information to /contrib/pgstattuple: · dab42382
      Bruce Momjian authored
      This is an extension of pgstattuple to query information from indexes.
      It supports btree, hash and gist. Gin is not supported. It scans only
      index pages and does not read corresponding heap tuples. Therefore,
      'dead_tuple' means the number of tuples with LP_DELETE flag.
      
      Also, I added an experimental feature for btree indexes. It checks
      fragmentation factor of indexes. If an leaf has the right link on the
      next adjacent page in the file, it is assumed to be continuous (not
      fragmented). It will help us to decide when to REINDEX.
      
      ITAGAKI Takahiro
      dab42382
    • Bruce Momjian's avatar
      WIN32 fixes: · 591e90a4
      Bruce Momjian authored
      I take out patch for this as a promise. This is client-build support of
      MS-VC6+.
      
      Fix for different getaddrinfo structure ordering on Win32 for IPv6.
      
      Hiroshi Saito
      591e90a4
    • Bruce Momjian's avatar
      Backpatch dbmirror fix for escape handling. · a7aa0b81
      Bruce Momjian authored
      > Upstream confirmed my reply in the last mail in [1]: the complete
      > escaping logic in DBMirror.pl is seriously screwew.
      >
      > [1] http://archives.postgresql.org/pgsql-bugs/2006-06/msg00065.php
      
      I finally found some time to debug this, and I think I found a better
      patch than the one you proposed. Mine is still hackish and is still a
      workaround around a proper quoting solution, but at least it repairs
      the parsing without introducing the \' quoting again.
      
      I consider this a band-aid patch to fix the recent security update.
      PostgreSQL gurus, would you consider applying this until a better
      solution is found for DBMirror.pl?
      
      Olivier, can you please confirm that the patch works for you, too?
      
      Backpatched to 8.0.X.
      
      Martin Pitt
      a7aa0b81
    • Bruce Momjian's avatar
      Attached patch is required ot build with the CRT that comes with Visual · 4f4d62a5
      Bruce Momjian authored
      Studio 2005. Basically MS defined errcode in the headers with a typedef,
      so we have to #define it out of the way.
      
      While at it, fix a function declaration in plpython that didn't match
      the implementation (volatile missing).
      
      Magnus Hagander
      4f4d62a5
    • Bruce Momjian's avatar
      Please find attached two patches for documentation and regression tests · a77275fe
      Bruce Momjian authored
      for the usage of full time zone names.
      
      Joachim Wieland
      a77275fe
  5. 05 Jul, 2006 1 commit
  6. 04 Jul, 2006 4 commits
  7. 03 Jul, 2006 2 commits
    • Tom Lane's avatar
      Code review for FILLFACTOR patch. Change WITH grammar as per earlier · b7b78d24
      Tom Lane authored
      discussion (including making def_arg allow reserved words), add missed
      opt_definition for UNIQUE case.  Put the reloptions support code in a less
      random place (I chose to make a new file access/common/reloptions.c).
      Eliminate header inclusion creep.  Make the index options functions safely
      user-callable (seems like client apps might like to be able to test validity
      of options before trying to make an index).  Reduce overhead for normal case
      with no options by allowing rd_options to be NULL.  Fix some unmaintainably
      klugy code, including getting rid of Natts_pg_class_fixed at long last.
      Some stylistic cleanup too, and pay attention to keeping comments in sync
      with code.
      
      Documentation still needs work, though I did fix the omissions in
      catalogs.sgml and indexam.sgml.
      b7b78d24
    • Tom Lane's avatar
      Fix broken markup. · feed0735
      Tom Lane authored
      feed0735
  8. 02 Jul, 2006 5 commits
    • Neil Conway's avatar
      Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep · 7fb9090e
      Neil Conway authored
      the read lock we hold on the table's parent relation until commit.
      Update equalfuncs.c for the new field in AlterTableCmd. Various
      improvements to comments, variable names, and error reporting.
      
      There is room for further improvement here, but this is at least
      a step in the right direction.
      7fb9090e
    • Bruce Momjian's avatar
      Add FILLFACTOR to CREATE INDEX. · 277807bd
      Bruce Momjian authored
      ITAGAKI Takahiro
      277807bd
    • Bruce Momjian's avatar
      Done: · 5d5c1416
      Bruce Momjian authored
      > * -Add fillfactor to control reserved free space during index creation
      5d5c1416
    • Bruce Momjian's avatar
      Done: · ff3003e5
      Bruce Momjian authored
      < 	o Add ALTER TABLE tab ADD/DROP INHERITS parent
      <
      < 	  This allows tables to be added/removed from an inheritance
      < 	  hierarchy.  This is particularly useful for table partitioning.
      < 	  http://archives.postgresql.org/pgsql-hackers/2006-05/msg00988.php
      <
      > 	o -Add ALTER TABLE tab INHERIT / NO INHERIT  parent
      ff3003e5
    • Bruce Momjian's avatar
      ALTER TABLE ... ADD/DROPS INHERIT (actually INHERIT / NO INHERIT) · 8c092781
      Bruce Momjian authored
      Open items:
      
      There were a few tangentially related issues that have come up that I think
      are TODOs. I'm likely to tackle one or two of these next so I'm interested in
      hearing feedback on them as well.
      
      . Constraints currently do not know anything about inheritance. Tom suggested
        adding a coninhcount and conislocal like attributes have to track their
        inheritance status.
      
      . Foreign key constraints currently do not get copied to new children (and
        therefore my code doesn't verify them). I don't think it would be hard to
        add them and treat them like CHECK constraints.
      
      . No constraints at all are copied to tables defined with LIKE. That makes it
        hard to use LIKE to define new partitions. The standard defines LIKE and
        specifically says it does not copy constraints. But the standard already has
        an option called INCLUDING DEFAULTS; we could always define a non-standard
        extension LIKE table INCLUDING CONSTRAINTS that gives the user the option to
        request a copy including constraints.
      
      . Personally, I think the whole attislocal thing is bunk. The decision about
        whether to drop a column from children tables or not is something that
        should be up to the user and trying to DWIM based on whether there was ever
        a local definition or the column was acquired purely through inheritance is
        hardly ever going to match up with user expectations.
      
      . And of course there's the whole unique and primary key constraint issue. I
        think to get any traction at all on this you have a prerequisite of a real
        partitioned table implementation where the system knows what the partition
        key is so it can recognize when it's a leading part of an index key.
      
      Greg Stark
      8c092781
  9. 01 Jul, 2006 1 commit
    • Tom Lane's avatar
      Fix oversight in planning for multiple indexscans driven by · 08ccdf02
      Tom Lane authored
      ScalarArrayOpExpr index quals: we were estimating the right total
      number of rows returned, but treating the index-access part of the
      cost as if a single scan were fetching that many consecutive index
      tuples.  Actually we should treat it as a multiple indexscan, and
      if there are enough of 'em the Mackert-Lohman discount should kick in.
      08ccdf02