1. 12 Feb, 2006 5 commits
    • Bruce Momjian's avatar
      I've created a new shared catalog table pg_shdescription to store · f9a726aa
      Bruce Momjian authored
      comments on cluster global objects like databases, tablespaces, and
      roles.
      
      It touches a lot of places, but not much in the way of big changes.  The
      only design decision I made was to duplicate the query and manipulation
      functions rather than to try and have them handle both shared and local
      comments.  I believe this is simpler for the code and not an issue for
      callers because they know what type of object they are dealing with.
      This has resulted in a shobj_description function analagous to
      obj_description and backend functions [Create/Delete]SharedComments
      mirroring the existing [Create/Delete]Comments functions.
      
      pg_shdescription.h goes into src/include/catalog/
      
      Kris Jurka
      f9a726aa
    • Tom Lane's avatar
      Undo changes of trailing space in recently-committed expected files. · 95dbf9c0
      Tom Lane authored
      This is mostly just over-compulsiveness on my part, but the exercise
      did reveal one real bug: errors.out has a space difference now where
      it should not.
      95dbf9c0
    • Tom Lane's avatar
      Restore previous psql behavior of not printing useless trailing spaces · 3f9d2edd
      Tom Lane authored
      after the data in the last column on a line.
      3f9d2edd
    • Bruce Momjian's avatar
      Please find enclosed a patch that lets you use \c to connect · 07bae9c0
      Bruce Momjian authored
      (optionally) to a new host and port without exiting psql.  This
      eliminates, IMHO, a surprise in that you can now connect to PostgreSQL
      on a differnt machine from the one where you started your session. This
      should help people who use psql as an administrative tool.
      
      David Fetter
      07bae9c0
    • Tom Lane's avatar
      Actually there's a better way to do this, which is to count tuples · d52a57fc
      Tom Lane authored
      during the vacuumcleanup scan that we're going to do anyway.  Should
      save a few cycles (one calculation per page, not per tuple) as well
      as not having to depend on assumptions about heap and index being
      in step.
      I think this could probably be made to work for GIST too, but that
      code looks messy enough that I'm disinclined to try right now.
      d52a57fc
  2. 11 Feb, 2006 11 commits
  3. 10 Feb, 2006 13 commits
  4. 09 Feb, 2006 7 commits
  5. 08 Feb, 2006 1 commit
    • Michael Meskes's avatar
      Added just another test case. · e3740d2c
      Michael Meskes authored
       Fixed missing continuation line character.
       Do not translate $-quoting.
       Bit field notation belongs to a variable not a variable list.
       Output of line number only done by one function.
      e3740d2c
  6. 07 Feb, 2006 3 commits
    • Tom Lane's avatar
      Remove ancient hack to work around a peculiarity of libcurses on HPUX. · 115e5dd5
      Tom Lane authored
      Since we now use libtermcap in preference to libcurses, no need for hack
      anymore.
      115e5dd5
    • Bruce Momjian's avatar
      Source code cleanup. · ad177f10
      Bruce Momjian authored
      ad177f10
    • Bruce Momjian's avatar
      I think that NUMERIC datatype has a problem in the performance that · e7a9ccdb
      Bruce Momjian authored
      the format on Tuple(Numeric) and the format to calculate(NumericVar)
      are different. I understood that to reduce I/O. However, when many
      comparisons or calculations of NUMERIC are executed, the conversion
      of Numeric and NumericVar becomes a bottleneck.
      
      It is profile result when "create index on NUMERIC column" is executed:
      
        %   cumulative   self              self     total
       time   seconds   seconds    calls   s/call   s/call  name
       17.61     10.27    10.27 34542006     0.00     0.00  cmp_numerics
       11.90     17.21     6.94 34542006     0.00     0.00  comparetup_index
        7.42     21.54     4.33 71102587     0.00     0.00  AllocSetAlloc
        7.02     25.64     4.09 69084012     0.00     0.00  set_var_from_num
        4.87     28.48     2.84 69084012     0.00     0.00  alloc_var
        4.79     31.27     2.79 142205745     0.00     0.00  AllocSetFreeIndex
        4.55     33.92     2.65 34542004     0.00     0.00  cmp_abs
        4.07     36.30     2.38 71101189     0.00     0.00  AllocSetFree
        3.83     38.53     2.23 69084012     0.00     0.00  free_var
      
      The create index command executes many comparisons of Numeric values.
      Functions other than comparetup_index spent a lot of cycles for
      conversion from Numeric to NumericVar.
      
      An attached patch enables the comparison of Numeric values without
      executing conversion to NumericVar. The execution time of that SQL
      becomes half.
      
      o Test SQL (index_test table has 1,000,000 tuples)
       create index index_test_idx on index_test(num_col);
      
      o Test results (executed the test five times)
      (1)PentiumIII
       original: 39.789s  36.823s  36.737s  37.752s  37.019s
       patched : 18.560s  19.103s  18.830s  18.408s  18.853s
        4.07     36.30     2.38 71101189     0.00     0.00  AllocSetFree
        3.83     38.53     2.23 69084012     0.00     0.00  free_var
      
      The create index command executes many comparisons of Numeric values.
      Functions other than comparetup_index spent a lot of cycles for
      conversion from Numeric to NumericVar.
      
      An attached patch enables the comparison of Numeric values without
      executing conversion to NumericVar. The execution time of that SQL
      becomes half.
      
      o Test SQL (index_test table has 1,000,000 tuples)
       create index index_test_idx on index_test(num_col);
      
      o Test results (executed the test five times)
      (1)PentiumIII
       original: 39.789s  36.823s  36.737s  37.752s  37.019s
       patched : 18.560s  19.103s  18.830s  18.408s  18.853s
      
      (2)Pentium4
       original: 16.349s  14.997s  12.979s  13.169s  12.955s
       patched :  7.005s   6.594s   6.770s   6.740s   6.828s
      
      (3)Itanium2
       original: 15.392s  15.447s  15.350s  15.370s  15.417s
       patched :  7.413s   7.330s   7.334s   7.339s   7.339s
      
      (4)Ultra Sparc
       original: 64.435s  59.336s  59.332s  58.455s  59.781s
       patched : 28.630s  28.666s  28.983s  28.744s  28.595s
      
      Atsushi Ogawa
      e7a9ccdb