1. 05 May, 2006 5 commits
  2. 04 May, 2006 4 commits
    • Tom Lane's avatar
      Don't try to compile SSL CRL support if local SSL installation hasn't · 1e3496f2
      Tom Lane authored
      got it.  Per buildfarm failure on 'canary'.
      1e3496f2
    • Tom Lane's avatar
      Code review for contrib/pg_freespacemap. Add a storedpages column to · a43974c6
      Tom Lane authored
      pg_freespacemap_relations --- while one could theoretically get that
      number by counting rows in pg_freespacemap_pages, it's surely the hard
      way to do it.  Avoid expensive and inconvenient conversion to and from
      text format.  Minor code and docs cleanup.
      a43974c6
    • Tom Lane's avatar
      Simplify relcache startup sequence. With the new design of InitPostgres · 46287bd6
      Tom Lane authored
      it's not necessary to have three separate calls anymore.  This patch also
      fixes things so we don't try to read pg_internal.init until after we've
      obtained lock on the target database; which was fairly harmless, but it's
      certainly cleaner this way.
      46287bd6
    • Tom Lane's avatar
      Rethink the locking mechanisms used for CREATE/DROP/RENAME DATABASE. · 52667d56
      Tom Lane authored
      The former approach used ExclusiveLock on pg_database, which being a
      cluster-wide lock meant only one of these operations could proceed at
      a time; worse, it also blocked all incoming connections in ReverifyMyDatabase.
      Now that we have LockSharedObject(), we can use locks of different types
      applied to databases considered as objects.  This allows much more
      flexible management of the interlocking: two CREATE DATABASEs need not
      block each other, and need not block connections except to the template
      database being used.  Similarly DROP DATABASE doesn't block unrelated
      operations.  The locking used in flatfiles.c is also much narrower in
      scope than before.  Per recent proposal.
      52667d56
  3. 03 May, 2006 4 commits
    • Tom Lane's avatar
      Create a syscache for pg_database-indexed-by-oid, and make use of it · cb98e6fb
      Tom Lane authored
      in various places that were previously doing ad hoc pg_database searches.
      This may speed up database-related privilege checks a little bit, but
      the main motivation is to eliminate the performance reason for having
      ReverifyMyDatabase do such a lot of stuff (viz, avoiding repeat scans
      of pg_database during backend startup).  The locking reason for having
      that routine is about to go away, and it'd be good to have the option
      to break it up.
      cb98e6fb
    • Teodor Sigaev's avatar
      5320c6cf
    • Teodor Sigaev's avatar
      Fix typo noticed by Alvaro Herrera · 2a58f3bf
      Teodor Sigaev authored
      2a58f3bf
    • Tom Lane's avatar
      Fix calculation of plan node extParams to account for the possibility that one · f4923880
      Tom Lane authored
      initPlan sets a parameter for another.  This could not (I think) happen before
      8.1, but it's possible now because the initPlans generated by MIN/MAX
      optimization might themselves use initPlans.  We attach those initPlans as
      siblings of the MIN/MAX ones, not children, to avoid duplicate computation
      when multiple MIN/MAX aggregates are present; so this leads to the case of an
      initPlan needing the result of a sibling initPlan, which is not possible with
      ordinary query nesting.  Hadn't been noticed because in most contexts having
      too much stuff listed in extParam is fairly harmless.  Fixes "plan should not
      reference subplan's variable" bug reported by Catalin Pitis.
      f4923880
  4. 02 May, 2006 7 commits
  5. 01 May, 2006 1 commit
    • Tom Lane's avatar
      Provide a namespace.c function for lookup of an operator with exact · a65a4942
      Tom Lane authored
      input datatypes given, and use this before trying OpernameGetCandidates.
      This is faster than the old method when there's an exact match, and it
      does not seem materially slower when there's not.  And it definitely
      makes some of the callers cleaner, because they didn't really want to
      know about a list of candidates anyway.  Per discussion with Atsushi Ogawa.
      a65a4942
  6. 30 Apr, 2006 6 commits
  7. 29 Apr, 2006 8 commits
  8. 28 Apr, 2006 5 commits
    • Bruce Momjian's avatar
      a1ee6215
    • Tom Lane's avatar
      Remove the restriction originally coded into optimize_minmax_aggregates() that · 53ee9f52
      Tom Lane authored
      MIN/MAX not be converted to use an index if the query WHERE clause contains
      any volatile functions or subplans.
      
      I had originally feared that the conversion might alter the behavior of such a
      query with respect to a volatile function.  Well, so it might, but only in the
      sense that the function would get evaluated at a subset of the table rows
      rather than all of them --- and we have never made any such guarantee anyway.
      (For instance, we don't refuse to use an index for an ordinary non-aggregate
      query when one of the non-indexable filter conditions contains a volatile
      function.)
      
      The prohibition against subplans was because of worry that that case wasn't
      adequately tested, which it wasn't, but it turns out to be possible to make
      8.1 fail anyway:
      
      regression=# select o.ten, (select max(unique2) from tenk1 i where ten = o.ten
      or ten = (select f1 from int4_tbl limit 1)) from tenk1 o;
      ERROR:  direct correlated subquery unsupported as initplan
      
      This is due to bogus code in SS_make_initplan_from_plan (it's an initplan,
      ergo it can't have any parParams).  Having fixed that, we might as well allow
      subplans as well as initplans.
      53ee9f52
    • Bruce Momjian's avatar
    • Bruce Momjian's avatar
      Darin -> Darwin. · 83b692d9
      Bruce Momjian authored
      83b692d9
    • Bruce Momjian's avatar
      e81b7b1d