Submitted by: wieck@sapserv.debis.de (Jan Wieck)

              relations and transaction is aborted

Submitted by: wieck@sapserv.debis.de (Jan Wieck)

It's bug in nodeAgg.c on lines 241, 242:

                null_array = malloc(nagg);
                for (i=0;i<nagg;i++)
                    null_array[i] = 'n';
                oneTuple = heap_formtuple(tupType, tupValue, null_array);

- your query has not only aggregates but also 'group by-ed' fields and so
null_array should contain tupType->natts elements (tupType->natts > nagg in
your case).

Patch follows and it's very simple.

VAdim

My guess is that the thing had bugs, and the pfree was commented out.
The thing is probabally free'ed anyway at the end, so it was not a bad
thing.

If it does cause a bug, it will generate an error when hit, so I say
unless someone else knows, let's remove it and run the regression test.

-Bruce

|
|  1. Set default variables
|  2. Include Makefile.custom to override defaults
|  3. Set CFLAGS, etc. with variables
|
|This fixes the problem of Makefile.custom changes not taking effect.

Submitted by: D'Arcy Cain

Suggested by: Randy Terbush <randy@zyzzyva.com>

That finishes access/*

there because it's in config.h, which is cleaner).

	- cleaned out unused variables
	- added missing prototype headers

One outstanding -Werror failure:

/home/staff/scrappy/postgres/2.0/cvs/postgres95/src/backend/access/gist/giststra
t.c:117: warning: missing braces around initializer for `GISTEvaluationData.expr
ession'

indextuple.c:159: warning: `bp' might be used uninitialized in this function

this directory passes -Wall -Werror under FreeBSD

of it

Once access/* is cleaned out, will redo using -Wall on compile to
make sure that all prototyping is correct

Mainly...fix up the includes I removed, as well as prototypes

Pointed out by D'Arcy

FreeBSD/NetBSD both ship with gcc 2.7.x

that allows one to compile libpq++

this should be set on a port-by-port basis

files

access/common...how many more directories to go? :)