- 27 Jun, 2008 7 commits
-
-
Tom Lane authored
of any lower outer join, even if it also references the non-nullable side and so could not get pushed below the outer join anyway. We need this in case the clause is an OR clause: if it doesn't get marked outerjoin_delayed, create_or_index_quals() could pull an indexable restriction for the nullable side out of it, leading to wrong results as demonstrated by today's bug report from toruvinn. (See added regression test case for an example.) In principle this has been wrong for quite a while. In practice I don't think any branch before 8.3 can really show the failure, because create_or_index_quals() will only pull out indexable conditions, and before 8.3 those were always strict. So though we might have improperly generated null-extended rows in the outer join, they'd get discarded from the result anyway. The gating factor that makes the failure visible is that 8.3 considers "col IS NULL" to be indexable. Hence I'm not going to risk back-patching further than 8.3.
-
Magnus Hagander authored
Hiroshi Saito
-
Tom Lane authored
taking the maximum of any child rel's width, we should weight the widths proportionally to the number of rows expected from each child. In hindsight this is obviously correct because row width is really a proxy for the total physical size of the relation. Per discussion with Scott Carey (bug #4264).
-
Bruce Momjian authored
values to libpq.
-
Bruce Momjian authored
> > * Fix system views like pg_stat_all_tables to use set-returning > functions, rather than views of per-column functions
-
Tom Lane authored
truly distinct version of IF. Per suggestion from Marko Kreen.
-
Tom Lane authored
vintage Linux is even more broken than we realized: a link to libreadline will succeed, and fail only at runtime. It seems that an AC_TRY_RUN test is the only reliable way to check whether this is really safe. Per report from Tatsuo.
-
- 26 Jun, 2008 13 commits
-
-
Bruce Momjian authored
appear in a paragraph. Andy Anderson
-
-
Bruce Momjian authored
wasn't working.
-
Teodor Sigaev authored
and non-C locale. Fix is just to use correct source's length for char2wchar call.
-
Michael Meskes authored
-
Bruce Momjian authored
* Improve server security options http://archives.postgresql.org/pgsql-hackers/2008-04/msg01875.php http://archives.postgresql.org/pgsql-hackers/2008-05/msg00000.php
-
Bruce Momjian authored
-
Bruce Momjian authored
postmaster.opts.
-
Bruce Momjian authored
-
Bruce Momjian authored
> > * Improve LDAP authentication configuration options > > http://archives.postgresql.org/pgsql-hackers/2008-04/msg01745.php
-
Bruce Momjian authored
-
Bruce Momjian authored
patterns, for clarity.
-
Bruce Momjian authored
-
- 24 Jun, 2008 3 commits
-
-
Tom Lane authored
to suppress zero-padding of "name" entries in indexes. The alignment change is unlikely to save any space, but it is really needed anyway to make the world safe for our widespread practice of passing plain old C strings to functions that are declared as taking Name. In the previous coding, the C compiler was entitled to assume that a Name pointer was word-aligned; but we were failing to guarantee that. I think the reason we'd not seen failures is that usually the only thing that gets done with such a pointer is strcmp(), which is hard to optimize in a way that exploits word-alignment. Still, some enterprising compiler guy will probably think of a way eventually, or we might change our code in a way that exposes more-obvious optimization opportunities. The padding change is accomplished in one-liner fashion by declaring the "name" index opclasses to use storage type "cstring" in pg_opclass.h. Normally btree and hash don't allow a nondefault storage type, because they don't have any provisions for converting the input datum to another type. However, because name and cstring are effectively the same thing except for padding, no conversion is needed --- we only need index_form_tuple() to treat the datum as being cstring not name, and this is sufficient. This seems to make for about a one-third reduction in the typical sizes of system catalog indexes that involve "name" columns, of which we have many. These two changes are only weakly related, but the alignment change makes me feel safer that the padding change won't introduce problems, so I'm committing them together.
-
Bruce Momjian authored
< o Prevent pg_dump/pg_restore from being affected by > o -Prevent pg_dump/pg_restore from being affected by
-
Tom Lane authored
Per buildfarm results.
-
- 23 Jun, 2008 9 commits
-
-
Bruce Momjian authored
> > o Allow COPY to report errors sooner > > http://archives.postgresql.org/pgsql-hackers/2008-04/msg01169.php
-
Bruce Momjian authored
-
Bruce Momjian authored
Joshua D. Drake
-
Bruce Momjian authored
> * Allow custom variables to appear in pg_settings()
-
Bruce Momjian authored
* Implement a module capability for loading /contrib-style extensions http://archives.postgresql.org/pgsql-patches/2008-04/msg00164.php
-
Bruce Momjian authored
binary values. Add comments to libpq C function for parameter passing.
-
Bruce Momjian authored
* Consider whether duplicate keys should be sorted by block/offset http://archives.postgresql.org/pgsql-hackers/2008-03/msg00558.php Create new "Sorting" TODO section.
-
Bruce Momjian authored
formatting.c to use common code; remove duplicate functions and support routines that are no longer needed.
-
Tom Lane authored
in pg_proc. Also make it not emit duplicate extern declarations, and make it a bit more bulletproof in some other small ways. Likewise fix the equally hard-wired, and utterly undocumented, knowledge in the MSVC build scripts. For testing purposes and perhaps other uses in future, pull out that portion of the MSVC scripts into a standalone perl script equivalent to Gen_fmgrtab.sh, and make it generate actually identical output, rather than just more-or-less-the-same output. Motivated by looking at Pavel's variadic function patch. Whether or not that gets accepted, we can be sure that pg_proc's column set will change again in the future; it's time to not have to deal with this gotcha.
-
- 20 Jun, 2008 1 commit
-
-
Tom Lane authored
read and written without a lock. The value itself is atomic, sure, but on processors with weak memory ordering it's possible for a reader to see the value change before it sees the associated message written into the buffer array. Fix by introducing a spinlock that's used just to read and write maxMsgNum. (We could do this with less overhead if we recognized a concept of "memory access barrier"; is it worth introducing such a thing? At the moment probably not --- I can't measure any clear slowdown from adding the spinlock, so this solution is probably fine.) Per buildfarm results.
-
- 19 Jun, 2008 4 commits
-
-
Tom Lane authored
unnecessary cache resets. The major changes are: * When the queue overflows, we only issue a cache reset to the specific backend or backends that still haven't read the oldest message, rather than resetting everyone as in the original coding. * When we observe backend(s) falling well behind, we signal SIGUSR1 to only one backend, the one that is furthest behind and doesn't already have a signal outstanding for it. When it finishes catching up, it will in turn signal SIGUSR1 to the next-furthest-back guy, if there is one that is far enough behind to justify a signal. The PMSIGNAL_WAKEN_CHILDREN mechanism is removed. * We don't attempt to clean out dead messages after every message-receipt operation; rather, we do it on the insertion side, and only when the queue fullness passes certain thresholds. * Split SInvalLock into SInvalReadLock and SInvalWriteLock so that readers don't block writers nor vice versa (except during the infrequent queue cleanout operations). * Transfer multiple sinval messages for each acquisition of a read or write lock.
-
Tom Lane authored
parsing. Per bug #4253 from Giorgio Valoti.
-
Bruce Momjian authored
o Allow pg_hba.conf to specify host names along with IP addresses > http://archives.postgresql.org/pgsql-hackers/2008-06/msg00569.php
-
Alvaro Herrera authored
corresponding struct definitions. This allows other headers to avoid including certain highly-loaded headers such as rel.h and relscan.h, instead using just relcache.h, heapam.h or genam.h, which are more lightweight and thus cause less unnecessary dependencies.
-
- 18 Jun, 2008 3 commits
-
-
Tom Lane authored
-
Tom Lane authored
by installing an error context subroutine that will provide the file name and line number for all errors detected while reading a config file. Some of the reader routines were already doing that in an ad-hoc way for errors detected directly in the reader, but it didn't help for problems detected in subroutines, such as encoding violations. Back-patch to 8.3 because 8.3 is where people will be trying to debug configuration files.
-
Bruce Momjian authored
use for other modules; also move pnstrdup(). Clean up code slightly.
-