1. 26 Jan, 2001 3 commits
  2. 25 Jan, 2001 16 commits
  3. 24 Jan, 2001 21 commits
    • Bruce Momjian's avatar
      Update TODO list. · 9aab097d
      Bruce Momjian authored
      9aab097d
    • Bruce Momjian's avatar
      Attached is a revised patch that removes the static SimpleDateFormat · 26e56644
      Bruce Momjian authored
      objects that Thomas pointed out might be a problem.
      
      PPS.  I have included and updated the comments from the original patch
      request to reflect the changes made in this revised patch.
      
      > Attached is a set of patches for a couple of bugs dealing with
      > timestamps in JDBC.
      >
      > Bug#1) Incorrect timestamp stored in DB if client timezone different
      > than DB.
      > The buggy implementation of setTimestamp() in PreparedStatement simply
      > used the toString() method of the java.sql.Timestamp object to convert
      > to a string to send to the database.  The format of this is yyyy-MM-dd
      > hh:mm:ss.SSS which doesn't include any timezone information.  Therefore
      > the DB assumes its timezone since none is specified.  That is OK if the
      > timezone of the client and server are the same, however if they are
      > different the wrong timestamp is received by the server.  For example if
      > the client is running in timezone GMT and wants to send the timestamp
      > for noon to a server running in PST (GMT-8 hours), then the server will
      > receive 2000-01-12 12:00:00.0 and interprete it as 2000-01-12
      > 12:00:00-08 which is 2000-01-12 04:00:00 in GMT.  The fix is to send a
      > format to the server that includes the timezone offset.  For simplicity
      > sake the fix uses a SimpleDateFormat object with its timezone set to GMT
      > so that '+00' can be used as the timezone for postgresql.  This is done
      > as SimpleDateFormat doesn't support formating timezones in the way
      > postgresql expects.
      >
      > Bug#2) Incorrect handling of partial seconds in getting timestamps from
      > the DB
      >
      > When the SimpleDateFormat object parses a string with a format like
      > yyyy-MM-dd hh:mm:ss.SS it expects the fractional seconds to be three
      > decimal places (time precision in java is miliseconds = three decimal
      > places).  This seems like a bug in java to me, but it is unlikely to be
      > fixed anytime soon, so the postgresql code needed modification to
      > support the java behaviour.  So for example a string of '2000-01-12
      > 12:00:00.12-08' coming from the database was being converted to a
      > timestamp object with a value of 2000-01-12 12:00:00.012GMT-08:00.  The
      > fix was to check for a '.' in the string and if one is found append on
      > an extra zero to the fractional seconds part.
      >
      >
      > I also did some cleanup in ResultSet.getTimestamp().  This method has
      > had multiple patches applied some of which resulted in code that was no
      > longer needed.  For example the ISO timestamp format that postgresql
      > uses specifies the timezone as an offset like '-08'.  Code was added at
      > one point to convert the postgresql format to the java one which is
      > GMT-08:00, however the old code was left around which did nothing.  So
      > there was code that looked for yyyy-MM-dd hh:mm:sszzzzzzzzz and
      > yyyy-MM-dd hh:mm:sszzz.  This second format would never be encountered
      > because zzz (i.e. -08) would be converted into the former (also note
      > that the SimpleDateFormat object treats zzzzzzzzz and zzz the same, the
      > number of z's does not matter).
      >
      >
      > There was another problem/fix mentioned on the email lists today by
      > mcannon@internet.com which is also fixed by this patch:
      >
      > Bug#3) Fractional seconds lost when getting timestamp from the DB
      > A patch by Jan Thomea handled the case of yyyy-MM-dd hh:mm:sszzzzzzzzz
      > but not the fractional seconds version yyyy-MM-dd hh:mm:ss.SSzzzzzzzzz.
      > The code is fixed to handle this case as well.
      
      Barry Lind
      26e56644
    • Peter Eisentraut's avatar
    • Peter Eisentraut's avatar
    • Bruce Momjian's avatar
    • Bruce Momjian's avatar
      Update TODO list. · ae22682f
      Bruce Momjian authored
      ae22682f
    • Peter Eisentraut's avatar
      Fix bogus pattern for STRING. · 718fc7e0
      Peter Eisentraut authored
      718fc7e0
    • Bruce Momjian's avatar
      Add all possible config file options. · 7df3bb50
      Bruce Momjian authored
      7df3bb50
    • Bruce Momjian's avatar
      3347fbad
    • Bruce Momjian's avatar
      Add "idle in transaction" status message · 0843ec08
      Bruce Momjian authored
      0843ec08
    • Bruce Momjian's avatar
      It looks Ok, but it has one unnecessary step. There is no need to do the "mv · 87070ccc
      Bruce Momjian authored
      privkey.pem cert.pem.pw" if you just use "privkey.pem" in the following
      openssl command (e.g. openssl rsa -in privkey.pem -out cert.pem".
      But there is nothing wrong with it as it is now, as far as I can see.
      
      
      //Magnus
      87070ccc
    • Bruce Momjian's avatar
      Fix formatting of db crash. · ab372244
      Bruce Momjian authored
      ab372244
    • Bruce Momjian's avatar
      Add. · eb0eadb9
      Bruce Momjian authored
      eb0eadb9
    • Bruce Momjian's avatar
      Add file. · d2c25518
      Bruce Momjian authored
      d2c25518
    • Bruce Momjian's avatar
      Update TODO list. · dd479643
      Bruce Momjian authored
      dd479643
    • Peter Mount's avatar
      b869f45d
    • Bruce Momjian's avatar
      Oops, got binary in there too. · 92681e97
      Bruce Momjian authored
      92681e97
    • Bruce Momjian's avatar
      Add comment for getpwid() safety. · 3f0f30d1
      Bruce Momjian authored
      3f0f30d1
    • Bruce Momjian's avatar
      Oops, had .o file in there. · 80d24370
      Bruce Momjian authored
      80d24370
    • Bruce Momjian's avatar
      Update TODO list. · 64b53d74
      Bruce Momjian authored
      64b53d74
    • Bruce Momjian's avatar
      attached is take-2 of a patch which fixes a bug related · 843657b0
      Bruce Momjian authored
      to the use of getpwuid when running in standalone mode.
      this patch allocates some persistent storage (using
      strdup) to store the username obtained with getpwuid
      in src/backend/main/main.c.  this is necessary because
      later on, getpwuid is called again (in ValidateBinary).
      
      the man pages for getpwuid on SCO OpenServer, FreeBSD,
      and Darwin all have words to this effect (this is from
      the SCO OpenServer man page):
      
        Note
        ====
        All information is contained in a static area, so it must
        be copied if it is to be saved. Otherwise, it may be
        overwritten on subsequent calls to these routines.
      
      in particular, on my platform, the storage used to hold
      the pw_name from the first call is overwritten such that
      it looks like an empty username.  this causes a problem
      later on in SetSessionUserIdFromUserName.
      
      i'd assume this isn't a problem on most platforms because
      getpwuid is called with the same UID both times, and the
      same thing ends up happening to that static storage each
      time.  however, that's not guaranteed, and is _not_ what
      happens on my platform (at least :).
      
      this is for the version of 7.1 available via anon cvs as
      of Tue Jan 23 15:14:00 2001 PST:
        .../src/backend/main/main.c,v 1.37 2000/12/31 18:04:35 tgl Exp
      
      -michael thornburgh, zenomt@armory.com
      843657b0