1. 15 Jul, 2014 9 commits
    • Alvaro Herrera's avatar
      Add missing doc changes for ee80f043 · da6ac4a6
      Alvaro Herrera authored
      Per note from Tom Lane
      da6ac4a6
    • Alvaro Herrera's avatar
      Fix REASSIGN OWNED for text search objects · 6bdf4b9c
      Alvaro Herrera authored
      Trying to reassign objects owned by a user that had text search
      dictionaries or configurations used to fail with:
      ERROR:  unexpected classid 3600
      or
      ERROR:  unexpected classid 3602
      
      Fix by adding cases for those object types in a switch in pg_shdepend.c.
      
      Both REASSIGN OWNED and text search objects go back all the way to 8.1,
      so backpatch to all supported branches.  In 9.3 the alter-owner code was
      made generic, so the required change in recent branches is pretty
      simple; however, for 9.2 and older ones we need some additional
      reshuffling to enable specifying objects by OID rather than name.
      
      Text search templates and parsers are not owned objects, so there's no
      change required for them.
      
      Per bug #9749 reported by Michal Novotný
      6bdf4b9c
    • Magnus Hagander's avatar
      Detect presence of SSL_get_current_compression · c9e1ad7f
      Magnus Hagander authored
      Apparently we still build against OpenSSL so old that it doesn't
      have this function, so add an autoconf check for it to make the
      buildfarm happy. If the function doesn't exist, always return
      that compression is disabled, since presumably the actual
      compression functionality is always missing.
      
      For now, hardcode the function as present on MSVC, since we should
      hopefully be well beyond those old versions on that platform.
      c9e1ad7f
    • Peter Eisentraut's avatar
      Add missing source files to nls.mk · f9ddcf75
      Peter Eisentraut authored
      These are files under common/ that have been moved around.  Updating
      these manually is not satisfactory, but it's the only solution at the
      moment.
      f9ddcf75
    • Magnus Hagander's avatar
      Include SSL compression status in psql banner and connection logging · c93bf8c6
      Magnus Hagander authored
      Both the psql banner and the connection logging already included
      SSL status, cipher and bitlength, this adds the information about
      compression being on or off.
      c93bf8c6
    • Peter Eisentraut's avatar
      Small spelling fix · d90ad5d8
      Peter Eisentraut authored
      d90ad5d8
    • Peter Eisentraut's avatar
      Add missing serial commas · d38228fe
      Peter Eisentraut authored
      Also update one place where the wal_level "logical" was not added to an
      error message.
      d38228fe
    • Magnus Hagander's avatar
      Remove dependency on wsock32.lib in favor of ws2_32 · a16bac36
      Magnus Hagander authored
      ws2_32 is the new version of the library that should be used, as
      it contains the require functionality from wsock32 as well as some
      more (which is why some binaries were already using ws2_32).
      
      Michael Paquier, reviewed by MauMau
      a16bac36
    • Peter Eisentraut's avatar
      doc: small fixes for REINDEX reference page · f162fb75
      Peter Eisentraut authored
      From: Josh Kupershmidt <schmiddy@gmail.com>
      f162fb75
  2. 14 Jul, 2014 10 commits
  3. 12 Jul, 2014 4 commits
    • Magnus Hagander's avatar
      Support --with-extra-version equivalent functionality in MSVC build · 8d9a0e85
      Magnus Hagander authored
      Adds a configuration parameter, extraver, that is appended to the
      version number when built.
      
      Michael Paquier, reviewed by Muhammad Asif Naeem
      8d9a0e85
    • Andres Freund's avatar
      Minimal psql tab completion support for SET search_path. · bd409519
      Andres Freund authored
      Complete SET search_path = ... to non-temporary and non-toast
      schemas. Since there pretty much is no use case to add those to the
      search path and there can be many it's helpful to exclude them.
      
      It'd be nicer to complete multiple search path elements, but that's
      not easy.
      
      Jeff Janes
      bd409519
    • Andres Freund's avatar
      Fix decoding of consecutive MULTI_INSERTs emitted by one heap_multi_insert(). · 626bfad6
      Andres Freund authored
      Commit 1b86c81d fixed the decoding of toasted columns for the rows
      contained in one xl_heap_multi_insert record. But that's not actually
      enough, because heap_multi_insert() will actually first toast all
      passed in rows and then emit several *_multi_insert records; one for
      each page it fills with tuples.
      
      Add a XLOG_HEAP_LAST_MULTI_INSERT flag which is set in
      xl_heap_multi_insert->flag denoting that this multi_insert record is
      the last emitted by one heap_multi_insert() call. Then use that flag
      in decode.c to only set clear_toast_afterwards in the right situation.
      
      Expand the number of rows inserted via COPY in the corresponding
      regression test to make sure that more than one heap page is filled
      with tuples by one heap_multi_insert() call.
      
      Backpatch to 9.4 like the previous commit.
      626bfad6
    • Magnus Hagander's avatar
      Add autocompletion of locale keywords for CREATE DATABASE · deee42ab
      Magnus Hagander authored
      Adds support for autocomplete of LC_COLLATE and LC_CTYPE to
      the CREATE DATABASE command in psql.
      deee42ab
  4. 11 Jul, 2014 2 commits
    • Tom Lane's avatar
      Fix bug with whole-row references to append subplans. · d6858148
      Tom Lane authored
      ExecEvalWholeRowVar incorrectly supposed that it could "bless" the source
      TupleTableSlot just once per query.  But if the input is coming from an
      Append (or, perhaps, other cases?) more than one slot might be returned
      over the query run.  This led to "record type has not been registered"
      errors when a composite datum was extracted from a non-blessed slot.
      
      This bug has been there a long time; I guess it escaped notice because when
      dealing with subqueries the planner tends to expand whole-row Vars into
      RowExprs, which don't have the same problem.  It is possible to trigger
      the problem in all active branches, though, as illustrated by the added
      regression test.
      d6858148
    • Peter Eisentraut's avatar
      Fix whitespace · 80ddd04b
      Peter Eisentraut authored
      80ddd04b
  5. 10 Jul, 2014 3 commits
    • Tom Lane's avatar
      Implement IMPORT FOREIGN SCHEMA. · 59efda3e
      Tom Lane authored
      This command provides an automated way to create foreign table definitions
      that match remote tables, thereby reducing tedium and chances for error.
      In this patch, we provide the necessary core-server infrastructure and
      implement the feature fully in the postgres_fdw foreign-data wrapper.
      Other wrappers will throw a "feature not supported" error until/unless
      they are updated.
      
      Ronan Dunklau and Michael Paquier, additional work by me
      59efda3e
    • Bruce Momjian's avatar
      Adjust blank lines around PG_MODULE_MAGIC defines, for consistency · 6a605cd6
      Bruce Momjian authored
      Report by Robert Haas
      6a605cd6
    • Fujii Masao's avatar
      Add new ECHO mode 'errors' that displays only failed commands in psql. · 5b214c5d
      Fujii Masao authored
      When the psql variable ECHO is set to 'erros', only failed SQL commands
      are printed to standard error output. Also this patch adds -b option into psql.
      This is equivalent to setting the variable ECHO to 'errors'.
      
      Pavel Stehule, reviewed by Fabrízio de Royes Mello, Samrat Revagade,
      Kumar Rajeev Rastogi, Abhijit Menon-Sen, and me.
      5b214c5d
  6. 09 Jul, 2014 3 commits
  7. 08 Jul, 2014 5 commits
  8. 07 Jul, 2014 3 commits
    • Tom Lane's avatar
      In pg_dump, show server and pg_dump versions with or without --verbose. · 7700597b
      Tom Lane authored
      We used to print this information only in verbose mode, but it's argued
      that it's useful enough to print always; one reason being that this
      provides some documentation about which Postgres versions the dump is
      meant to reload into.
      
      Jing Wang, reviewed by Jeevan Chalke
      7700597b
    • Bruce Momjian's avatar
      pg_upgrade: allow upgrades for new-only TOAST tables · 3088cc37
      Bruce Momjian authored
      Previously, when calculations on the need for toast tables changed,
      pg_upgrade could not handle cases where the new cluster needed a TOAST
      table and the old cluster did not.  (It already handled the opposite
      case.)  This fixes the "OID mismatch" error typically generated in this
      case.
      
      Backpatch through 9.2
      3088cc37
    • Fujii Masao's avatar
      Fix typos in comments. · 4cbd1283
      Fujii Masao authored
      4cbd1283
  9. 06 Jul, 2014 1 commit
    • Robert Haas's avatar
      Remove swpb-based spinlock implementation for ARMv5 and earlier. · 4893ccd0
      Robert Haas authored
      Per recent analysis by Andres Freund, this implementation is in fact
      unsafe, because ARMv5 has weak memory ordering, which means tha the
      CPU could move loads or stores across the volatile store performed by
      the default S_UNLOCK.  We could try to fix this, but have no ARMv5
      hardware to test on, so removing support seems better.  We can still
      support ARMv5 systems on GCC versions new enough to have built-in
      atomics support for this platform, and can also re-add support for
      the old way if someone has hardware that can be used to test a fix.
      However, since the requirement to use a relatively-new GCC hasn't
      been an issue for ARMv6 or ARMv7, which lack the swpb instruction
      altogether, perhaps it won't be an issue for ARMv5 either.
      4893ccd0