1. 13 Mar, 2009 1 commit
    • Tom Lane's avatar
      Restore previous ordering of BUFFER_FLUSH_START probe. I had wanted to · d287c9ef
      Tom Lane authored
      make it include the time for the possible smgropen() call, but that
      results in a null pointer dereference :-(.
      
      An alternative solution would be to fetch the buffer tag instead of
      looking at *reln, but I'll just put it back as it was for the moment.
      
      BTW, this indicates that DTrace probes evaluate their arguments even
      when nominally inactive.  What was that about "zero cost", again?
      d287c9ef
  2. 12 Mar, 2009 2 commits
  3. 11 Mar, 2009 4 commits
  4. 10 Mar, 2009 4 commits
    • Tom Lane's avatar
      Make SubPlan nodes carry the result's typmod as well as datatype OID. This is · dcf3902f
      Tom Lane authored
      for consistency with the (relatively) recent addition of typmod to SubLink.
      An example of why it's a good idea is to be seen in the recent "failed to
      locate grouping columns" bug, which wouldn't have happened if a SubPlan
      exposed the same typmod info as the SubLink it was derived from.
      
      This could be back-patched, since it doesn't affect any on-disk data format,
      but for the moment it doesn't seem necessary to do so.
      dcf3902f
    • Tom Lane's avatar
      Fix set_subquery_pathlist() to copy the RTE's subquery before it gets mangled · 4886dc92
      Tom Lane authored
      by the planning process.  This prevents the "failed to locate grouping columns"
      error recently reported by Dickson Guedes.  That happens because planning
      replaces SubLinks by SubPlans in the subquery's targetlist, and exprTypmod()
      is smarter about the former than the latter, causing the apparent type of
      the subquery's output columns to change.  This seems to be a deficiency we
      should fix in exprTypmod(), but that will be a much more invasive patch
      with possible side-effects elsewhere, so I'll do that only in HEAD.
      
      Back-patch to 8.3.  Arguably the lack of a copying step is broken/dangerous
      all the way back, but in the absence of known problems I'll refrain from
      making the older branches pay the extra cost.  (The reason this particular
      symptom didn't appear before is that exprTypmod() wasn't smart about SubLinks
      either, until 8.3.)
      4886dc92
    • Teodor Sigaev's avatar
      Prevent recursion during parse of email-like string with multiple '@'. · 42831729
      Teodor Sigaev authored
      Patch by Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
      42831729
    • Bruce Momjian's avatar
      Doc patch for the recently added probes. · b0c68c24
      Bruce Momjian authored
      Robert Lor
      b0c68c24
  5. 09 Mar, 2009 5 commits
  6. 08 Mar, 2009 4 commits
  7. 07 Mar, 2009 3 commits
  8. 05 Mar, 2009 5 commits
  9. 04 Mar, 2009 9 commits
  10. 03 Mar, 2009 2 commits
  11. 02 Mar, 2009 1 commit
    • Tom Lane's avatar
      When we are in error recursion trouble, arrange to suppress translation and · fd9e2acc
      Tom Lane authored
      encoding conversion of any elog/ereport message being sent to the frontend.
      This generalizes a patch that I put in last October, which suppressed
      translation of only specific messages known to be associated with recursive
      can't-translate-the-message behavior.  As shown in bug #4680, we need a more
      general answer in order to have some hope of coping with broken encoding
      conversion setups.  This approach seems a good deal less klugy anyway.
      
      Patch in all supported branches.
      fd9e2acc