- 25 Jan, 2006 1 commit
-
-
Bruce Momjian authored
-
- 24 Jan, 2006 2 commits
-
-
Tom Lane authored
provided by configure, instead. Per bug #2205.
-
Michael Meskes authored
- Added another test case.
-
- 23 Jan, 2006 6 commits
-
-
Tom Lane authored
and non-required keys in a btree index scan, mark the required scankeys with private flag bits SK_BT_REQFWD and/or SK_BT_REQBKWD. This seems at least marginally clearer to me, and it eliminates a wired-into-the- data-structure assumption that required keys are consecutive. Even though that assumption will remain true for the foreseeable future, having it in there makes the code seem more complex than necessary.
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Tom Lane authored
suggestion a couple days ago. Fix some cases in which the documentation neglected to mention any restriction on when a parameter can be set. Try to be consistent about calling parameters parameters; use the term option only for command-line switches.
-
Teodor Sigaev authored
-
Bruce Momjian authored
< o Allow an alias to be provided for the target table in < UPDATE/DELETE < < This is not SQL-spec but many DBMSs allow it. < > o -Allow an alias to be provided for the target table in > UPDATE/DELETE (Neil)
-
- 22 Jan, 2006 4 commits
-
-
Tom Lane authored
It's not related to whether an alias is used or not.
-
Tom Lane authored
be any ColId other than 'SET', rather than only IDENT as originally. Per discussion.
-
Neil Conway authored
and DELETE. If specified, the alias must be used instead of the full table name. Also, the alias currently cannot be used in the SET clause of UPDATE. Patch from Atsushi Ogawa, various editorialization by Neil Conway. Along the way, make the rowtypes regression test pass if add_missing_from is enabled, and add a new (skeletal) regression test for DELETE.
-
Neil Conway authored
-
- 21 Jan, 2006 4 commits
-
-
Tom Lane authored
be consistent about whether it's called a daemon or a subprocess, and don't describe the autovacuum setting in exactly the same way as the stats_start_collector setting, because that leaves people thinking (if they aren't paying close attention) that autovacuum can't be changed on the fly.
-
Tom Lane authored
-
Tom Lane authored
to try to create a log segment file concurrently, but the code erroneously specified O_EXCL to open(), resulting in a needless failure. Before 7.4, it was even a PANIC condition :-(. Correct code is actually simpler than what we had, because we can just say O_CREAT to start with and not need a second open() call. I believe this accounts for several recent reports of hard-to-reproduce "could not create file ...: File exists" errors in both pg_clog and pg_subtrans.
-
Bruce Momjian authored
Continue to support GRANT ON [TABLE] for sequences for backward compatibility; issue warning for invalid sequence permissions. [Backward compatibility warning message.] Add USAGE permission for sequences that allows only currval() and nextval(), not setval(). Mention object name in grant/revoke warnings because of possible multi-object operations.
-
- 20 Jan, 2006 3 commits
-
-
Tom Lane authored
sizebitvec of tsearch2, as well as identical code in several other contrib modules. This provided about a 20X speedup in building a large tsearch2 index ... didn't try to measure its effects for other operations. Thanks to Stephan Vollmer for providing a test case.
-
Bruce Momjian authored
-
Tom Lane authored
temp table not only our own process' tables. It's not real important since vacuum.c will skip temp tables anyway, but might as well make the code do what it claims to do.
-
- 19 Jan, 2006 9 commits
-
-
Bruce Momjian authored
David Fetter
-
Bruce Momjian authored
can be optimized.
-
Tom Lane authored
mean stress ... system is orders of magnitude slower with this enabled).
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Tom Lane authored
index's support-function cache (in index_getprocinfo). Since none of that data can change for an index that's in active use, it seems sufficient to treat all open indexes the same way we were treating "nailed" system indexes --- that is, just re-read the pg_class row and leave the rest of the relcache entry strictly alone. The pg_class re-read might not be strictly necessary either, but since the reltablespace and relfilenode can change in normal operation it seems safest to do it. (We don't support changing any of the other info about an index at all, at the moment.) Back-patch as far as 8.0. It might be possible to adapt the patch to 7.4, but it would take more work than I care to expend for such a low-probability problem. 7.3 is out of luck for sure.
-
Bruce Momjian authored
now /lib.
-
Tom Lane authored
occurs when it tries to heap_open pg_tablespace. When control returns to smgrcreate, that routine will be holding a dangling pointer to a closed SMgrRelation, resulting in mayhem. This is of course a consequence of the violation of proper module layering inherent in having smgr.c call a tablespace command routine, but the simplest fix seems to be to change the locking mechanism. There's no real need for TablespaceCreateDbspace to touch pg_tablespace at all --- it's only opening it as a way of locking against a parallel DROP TABLESPACE command. A much better answer is to create a special-purpose LWLock to interlock these two operations. This drops TablespaceCreateDbspace quite a few layers down the food chain and makes it something reasonably safe for smgr to call.
-
Tom Lane authored
This is utterly insignificant in normal operation, but it becomes a problem during cache inval stress testing. The original coding in fact had no leak --- the 8.0 List rewrite created the issue. I wonder whether list_concat should pfree the discarded header?
-
- 18 Jan, 2006 5 commits
-
-
Bruce Momjian authored
-
Bruce Momjian authored
column, OUT and INOUT added. Guillaume LELARGE
-
Tom Lane authored
files: avoid creating stats hashtable entries for tables that aren't being touched except by vacuum/analyze, ensure that entries for dropped tables are removed promptly, and tweak the data layout to avoid storing useless struct padding. Also improve the performance of pgstat_vacuum_tabstat(), and make sure that autovacuum invokes it exactly once per autovac cycle rather than multiple times or not at all. This should cure recent complaints about 8.1 showing much higher stats I/O volume than was seen in 8.0. It'd still be a good idea to revisit the design with an eye to not re-writing the entire stats dataset every half second ... but that would be too much to backpatch, I fear.
-
Bruce Momjian authored
> o -Allow pooled connections to list all open WITH HOLD cursors
-
Neil Conway authored
cursors. Patch from Joachim Wieland, review and ediorialization by Neil Conway. The view lists cursors defined by DECLARE CURSOR, using SPI, or via the Bind message of the frontend/backend protocol. This means the view does not list the unnamed portal or the portal created to implement EXECUTE. Because we do list SPI portals, there might be more rows in this view than you might expect if you are using SPI implicitly (e.g. via a procedural language). Per recent discussion on -hackers, the query string included in the view for cursors defined by DECLARE CURSOR is based on debug_query_string. That means it is not accurate if multiple queries separated by semicolons are submitted as one query string. However, there doesn't seem a trivial fix for that: debug_query_string is better than nothing. I also changed SPI_cursor_open() to include the source text for the portal it creates: AFAICS there is no reason not to do this. Update the documentation and regression tests, bump the catversion.
-
- 17 Jan, 2006 3 commits
-
-
Tom Lane authored
assuming it always is on Darwin. Per report from Neil Brandt.
-
Michael Meskes authored
Also added a test case for a binary cursor.
-
Tom Lane authored
are two basically different kinds of scankeys, and we ought to try harder to indicate which is used in each place in the code. I've chosen the names "search scankey" and "insertion scankey", though you could make about as good an argument for "operator scankey" and "comparison function scankey".
-
- 16 Jan, 2006 3 commits
-
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Bruce Momjian authored
can convey information to clients on constraint violation.
-