of XLogInsert had the same sort of checkpoint interlock problem as
RecordTransactionCommit, and indeed I found some.  Btree index build
and ALTER TABLE SET TABLESPACE write data outside the friendly confines
of the buffer manager, and therefore they have to take their own
responsibility for checkpoint interlock.  The easiest solution seems to
be to force smgrimmedsync at the end of the index build or table copy,
even when the operation is being WAL-logged.  This is sufficient since
the new index or table will be of interest to no one if we don't get
as far as committing the current transaction.

therefore starting with GetCurrentTransactionId is wrong.  Fixes
miscomputation of RecentGlobalXmin leading to bizarre behavior
reported by Gavin Sherry.

Oliver Jowett.

mode isn't really serializable.  I had thought this was covered already
in our docs, but I sure can't find it.

>
> * Allow buffered WAL writes and fsync
>
>   Instead of guaranteeing recovery of all committed transactions, this
>   would provide improved performance by delaying WAL writes and fsync
>   so an abrupt operating system restart might lose a few seconds of
>   committed transactions but still be consistent.  We could perhaps
>   remove the 'fsync' parameter (which results in an an inconsistent
>   database) in favor of this capability.

Andrew Dunstan, some further hacking by Tom Lane.

logic a little bit.

in plpgsql, particularly trying to begin/end/rollback a transaction.

back branches later.

patches.

don't hold an open file reference to the original table at the end.
This is a good thing in any case, particularly so on Windows which
cannot drop the table file otherwise.

> 	o Add ALTER INDEX that works just like ALTER TABLE already does
> 	  on an index

by the SQL standard.  For backwards compatibility, however, continue to
accept the syntax without.  Minor editorialization in the reference pages
for these commands, too.

> * Allow finer control over the caching of prepared query plans
>
>   Currently, queries prepared via the libpq API are planned on first
>   execute using the supplied parameters --- allow SQL PREPARE to do the
>   same.  Also, allow control over replanning prepared queries either
>   manually or automatically when statistics for execute parameters
>   differ dramatically from those used during planning.
>

Gavin Sherry

compliance with SQL2003 spec syntax.

Oliver Jowett

and doesn't process forward slashes in the same way as external
commands.  Quoting the first argument to COPY does not convert forward
to backward slashes, but COPY does properly process quoted forward
slashes in the second argument.

Win32 COPY works with quoted forward slashes in the first argument only if the
current directory is the same as the directory of the first argument.

test only tests for building a binary, not building a shared library.

On Linux, you can build a binary with -pthread, but you can't build a
binary that uses a threaded shared library unless you also use -pthread
when building the binary, or adding -lpthread to the shared library
build.  This patch has the effect of doing the later by adding both
-pthread and -lpthread when building libpq.

a comment.

Jon Jensen

parser).

that refers to a now-deleted userid.  Per gripe from Chris Ochs.

the server version number.  This commit also removes bogus DOS line
endings from libpqddll.def.

Greg Sabino Mullane

Thanks to Michael Fuhr for identifying the problem.

it with previous prototype to suppress complaints from picky compilers,
per report from Scott Bailey.  Also, remove substitute strerror
definition --- not needed, since we link this with libpgport.