existing Windows-only switch.

some of the bugs exposed thereby.  The remaining 'might be used uninitialized'
warnings look like live bugs, but I am not familiar enough with Perl/C hacking
to tell how to fix them.

avoid repalloc'ing twice when once is sufficient.

of minus zero.  Per Andrew Dunstan.

Fabien COELHO

Reini Urban

parameters differently from their default values.  Matthew T. O'Connor

Just paranoia ...

Rather than using ReadBuffer() to increment the reference count on an
already-pinned buffer, we should use IncrBufferRefCount() as it is
faster and does not require acquiring the BufMgrLock.

Dunstan, editorializing by Neil Conway.

been defined. Patch from Gavin Sherry, editorializing by Neil Conway.

even uglier than it was already :-(.  Also, on Windows only, use temporary
shared memory segments instead of ordinary files to pass over critical
variable values from postmaster to child processes.  Magnus Hagander

more than 65K columns, or when the created table has more than 65K columns
due to adding inherited columns from parent relations. Fix a similar
crash when processing SELECT queries with more than 65K target list
entries. In all three cases we would eventually detect the error and
elog, but the check was being made too late.

patch, but allow srand and disallow sprintf as per subsequent discussion.

Andrew Dunstan

Magnus Hagander

We don't really want to start a new SPI connection, just keep using the old
one; otherwise we have memory management problems as illustrated by
John Kennedy's bug report of today.  This requires a bit of a hack to
ensure the SPI stack state is properly restored, but then again what we
were doing before was a hack too, strictly speaking.  Add a regression
test to cover this case.

output.

plain SUSET instead.  Also delay processing of options received in
client connection request until after we know if the user is a superuser,
so that SUSET values can be set that way by legitimate superusers.
Per recent discussion.

improvements by Neil Conway.

buffer is valid, as ReadBuffer() will elog on error. Most of the call
sites of ReadBuffer() got this right, but this patch fixes those call
sites that did not.

lacking pqsignal which is now required. This was found and fixed for
VC++ by Shachar Shemesh, I simply duplicated the fix for the Borland
makefile (untested, as I don't have that compiler).

Dave Page

< * Eliminate WAL logging for CREATE INDEX/REINDEX/CREATE TABLE AS when
<   not doing WAL archiving
> * Eliminate WAL logging for CREATE TABLE AS when not doing WAL archiving