- 21 Jun, 2007 4 commits
-
-
Tom Lane authored
parse_int() and with itself (strtod allows leading whitespace, so it seems odd not to allow trailing whitespace). parse_bool remains not-whitespace-friendly, but this is generically true for non-numeric GUC variables, so I'll desist from changing it.
-
Tom Lane authored
contain a wrong unit specification, per discussion. In passing, fix the code to avoid unnecessary integer overflows when converting units, and to detect overflows when they do occur.
-
Peter Eisentraut authored
-
Peter Eisentraut authored
-
- 20 Jun, 2007 7 commits
-
-
Tom Lane authored
constraints the planner is unable to disprove, hence simple btree-compatible conditions should be used. We've seen people try to get cute with stuff like date_part(something) = something at least twice now. Even if we wanted to try to teach predtest.c about the properties of date_part, most of the useful variants aren't immutable so nothing could be proved.
-
Neil Conway authored
SGML docs.
-
Tom Lane authored
actually works sanely, viz not 0 and not more than INT_MAX/1000 (else TimestampTzPlusMilliseconds can overflow). Per discussion with Greg Stark. Since this is a superuser-only setting and there was not previously any big reason to change it, not worth back-patching.
-
Tom Lane authored
create table foo (bar int default null default 3); due to not thinking about the special-case handling of DEFAULT NULL. Problem noticed while investigating bug #3396.
-
Tom Lane authored
NULL and DefineDomain didn't. Bug goes all the way back to original coding of domains. Per bug #3396 from Sergey Burladyan.
-
Andrew Dunstan authored
-
Neil Conway authored
necessary, since files opened via AllocateFile() are closed automatically as part of error recovery.
-
- 19 Jun, 2007 3 commits
-
-
Tom Lane authored
test seems inessential right now since the only control path for not getting the lock is via CHECK_FOR_INTERRUPTS which won't return control to ProcSleep, but it would be important if we ever allow the deadlock code to kill someone else's transaction instead of our own.
-
Neil Conway authored
-
Tom Lane authored
within a signal handler (this might be safe given the relatively narrow code range in which the interrupt is enabled, but it seems awfully risky); do issue more informative log messages that tell what is being waited for and the exact length of the wait; minor other code cleanup. Greg Stark and Tom Lane
-
- 18 Jun, 2007 3 commits
-
-
Tom Lane authored
unreserved according to the grammar. The list of unreserved words has gotten extensive enough that the unnecessary quoting is becoming a bit of an eyesore. To do this, add knowledge of the keyword category to keywords.c's table. (Someday we might be able to generate keywords.c's table and the keyword lists in gram.y from a common source.) For the moment, lie about WITH's status in the table so it will still get quoted --- this is because of the expectation that WITH will become reserved when the SQL recursive-queries patch gets done. I didn't force initdb because this affects nothing on-disk; but note that a few regression tests have changed expected output.
-
Magnus Hagander authored
Simon Riggs
-
Tom Lane authored
reads beyond EOF, except by special coercion.
-
- 17 Jun, 2007 2 commits
-
-
Tom Lane authored
profiling that CopyAttributeOutText was taking an unreasonable fraction of the backend run time (like 66%!) on the following trivial test case: $ time psql -c "copy (select repeat('xyzzy',50) from generate_series(1,10000000)) to stdout" regression >/dev/null The time is all being spent on scanning the string for characters to be escaped, which most of the time there aren't any of. Some tweaking to take as many tests as possible out of the inner loop reduced the runtime of this example by more than 10%. In a real-world case it wouldn't be as useful a speedup, but it still seems worth adding a few lines here.
-
Tom Lane authored
few lines in sql_exec_error_callback() by using the function source string field that the patch added to SQL function cache entries. This doesn't work because the fn_extra field isn't filled in yet during init_sql_fcache(). Probably it could be made to work, but it doesn't seem appropriate to contort the main code paths to make an error-reporting path a tad faster. Per report from Pavel Stehule.
-
- 15 Jun, 2007 2 commits
-
-
Tom Lane authored
an array of strings rather than an array of integers, and allow any simple constant or identifier to be used in typmods; for example create table foo (f1 widget(42,'23skidoo',point)); Of course the typmodin function has still got to pack this info into a non-negative int32 for storage, but it's still a useful improvement in flexibility, especially considering that you can do nearly anything if you are willing to keep the info in a side table. We can get away with this change since we have not yet released a version providing user-definable typmods. Per discussion.
-
Michael Meskes authored
-
- 14 Jun, 2007 4 commits
-
-
Alvaro Herrera authored
to prevent possible deadlock problems. Per request from Tom Lane.
-
Magnus Hagander authored
-
Magnus Hagander authored
options to deal with strange line endings.
-
Andrew Dunstan authored
reassembled in the syslogger before writing to the log file. This prevents partial messages from being written, which mucks up log rotation, and messages from different backends being interleaved, which causes garbled logs. Backport as far as 8.0, where the syslogger was introduced. Tom Lane and Andrew Dunstan
-
- 13 Jun, 2007 3 commits
-
-
Neil Conway authored
avoid mistakenly calling a function of the same name that might happen to appear earlier in the schema search path.
-
Bruce Momjian authored
< * Allow EXPLAIN output to be more easily processed by scripts > * Allow EXPLAIN output to be more easily processed by scripts, perhaps XML
-
Alvaro Herrera authored
-
- 12 Jun, 2007 12 commits
-
-
Tom Lane authored
comments noting that there's an alignment assumption now that the data field could be in 1-byte-header format. Per discussion with Greg Stark.
-
Magnus Hagander authored
Add ability to add "prefix include directories", and use it... With this, ecpg regression tests now pass on MSVC builds.
-
Magnus Hagander authored
-
Tom Lane authored
the normal heap_getattr() machinery. Per Greg Stark.
-
Tom Lane authored
-
Tom Lane authored
historically worked in some but not all cases, but as of 8.2 it failed for all timezone formats. Fix, and add regression test cases to catch future regressions in this area. Per gripe from Adam Witney.
-
Alvaro Herrera authored
-
Magnus Hagander authored
Fixes buildfarm failures on contribcheck.
-
Magnus Hagander authored
-
Magnus Hagander authored
-
Michael Meskes authored
-
Magnus Hagander authored
regression driver into two parts and reusing half of it. Required to run ECPG tests without a shell on MSVC builds. Fix ECPG thread tests for MSVC build (incl output files). Joachim Wieland and Magnus Hagander
-