1. 26 Nov, 2011 7 commits
  2. 25 Nov, 2011 7 commits
    • Alvaro Herrera's avatar
      Fix unvalidated check constraints on domains, too · f717f4bc
      Alvaro Herrera authored
      Same bug as reported by Thom Brown for check constraints on tables: the
      constraint must be dumped separately from the domain, otherwise it is
      restored before the data and thus prevents potentially-violating data
      from being loaded in the first place.
      
      Per Dean Rasheed
      f717f4bc
    • Bruce Momjian's avatar
      Modify pg_dump to use error-free memory allocation macros. This avoids · 3c0afde1
      Bruce Momjian authored
      ignoring errors and call-site error checking.
      3c0afde1
    • Bruce Momjian's avatar
      Allow pg_upgrade to upgrade clusters that use exclusion contraints by · 35e27226
      Bruce Momjian authored
      fixing pg_dump to properly preserve such indexes.
      
      Backpatch to 9.1 and 9.0 (where the bug was introduced).
      35e27226
    • Alvaro Herrera's avatar
      Improve logging of autovacuum I/O activity · 9d3b5024
      Alvaro Herrera authored
      This adds some I/O stats to the logging of autovacuum (when the
      operation takes long enough that log_autovacuum_min_duration causes it
      to be logged), so that it is easier to tune.  Notably, it adds buffer
      I/O counts (hits, misses, dirtied) and read and write rate.
      
      Authors: Greg Smith and Noah Misch
      9d3b5024
    • Tom Lane's avatar
      Fix erroneous replay of GIN_UPDATE_META_PAGE WAL records. · 877b67c3
      Tom Lane authored
      A simple thinko in ginRedoUpdateMetapage, namely failing to increment a
      loop counter, led to inserting records into the last pending-list page in
      the wrong order (the opposite of that intended).  So far as I can tell,
      this would not upset the code that eventually flushes pending items into
      the main part of the GIN index.  But it did break the code that searched
      the pending list for matches, resulting in transient failure to find
      matching entries during index lookups, as illustrated in bug #6307 from
      Maksym Boguk.
      
      Back-patch to 8.4 where the incorrect code was introduced.
      877b67c3
    • Robert Haas's avatar
      Move "hot" members of PGPROC into a separate PGXACT array. · ed0b409d
      Robert Haas authored
      This speeds up snapshot-taking and reduces ProcArrayLock contention.
      Also, the PGPROC (and PGXACT) structures used by two-phase commit are
      now allocated as part of the main array, rather than in a separate
      array, and we keep ProcArray sorted in pointer order.  These changes
      are intended to minimize the number of cache lines that must be pulled
      in to take a snapshot, and testing shows a substantial increase in
      performance on both read and write workloads at high concurrencies.
      
      Pavan Deolasee, Heikki Linnakangas, Robert Haas
      ed0b409d
    • Tom Lane's avatar
      Fix unsupported options in CREATE TABLE ... AS EXECUTE. · 9ed439a9
      Tom Lane authored
      The WITH [NO] DATA option was not supported, nor the ability to specify
      replacement column names; the former limitation wasn't even documented, as
      per recent complaint from Naoya Anzai.  Fix by moving the responsibility
      for supporting these options into the executor.  It actually takes less
      code this way ...
      
      catversion bump due to change in representation of IntoClause, which might
      affect stored rules.
      9ed439a9
  3. 24 Nov, 2011 4 commits
  4. 23 Nov, 2011 4 commits
    • Tom Lane's avatar
      Adjust range_adjacent to support different canonicalization rules. · b7056b83
      Tom Lane authored
      The original coding would not work for discrete ranges in which the
      canonicalization rule is to produce symmetric boundaries (either [] or ()
      style), as noted by Jeff Davis.  Florian Pflug pointed out that we could
      fix that by invoking the canonicalization function to see if the range
      "between" the two given ranges normalizes to empty.  This implementation
      of Florian's idea is a tad slower than the original code, but only in the
      case where there actually is a canonicalization function --- if not, it's
      essentially the same logic as before.
      b7056b83
    • Tom Lane's avatar
      Creator of a range type must have permission to call support functions. · a912a278
      Tom Lane authored
      Since range types can be created by non-superusers, we need to consider
      their permissions.  Ideally we'd check this when the type is used, not
      when it's created, but that seems like much more trouble than it's worth.
      The existing restriction that the support functions be immutable already
      prevents most cases where an unauthorized call to a function might be
      thought a security issue, and the fact that the user has no access to
      the results of the system's calls to subtype_diff closes off the other
      plausible reason for concern.  So this check is basically pro-forma,
      but let's make it anyway.
      a912a278
    • Tom Lane's avatar
      Remove user-selectable ANALYZE option for range types. · 74c1723f
      Tom Lane authored
      It's not clear that a per-datatype typanalyze function would be any more
      useful than a generic typanalyze for ranges.  What *is* clear is that
      letting unprivileged users select typanalyze functions is a crash risk or
      worse.  So remove the option from CREATE TYPE AS RANGE, and instead put in
      a generic typanalyze function for ranges.  The generic function does
      nothing as yet, but hopefully we'll improve that before 9.2 release.
      74c1723f
    • Tom Lane's avatar
      Remove zero- and one-argument range constructor functions. · df735844
      Tom Lane authored
      Per discussion, the zero-argument forms aren't really worth the catalog
      space (just write 'empty' instead).  The one-argument forms have some use,
      but they also have a serious problem with looking too much like functional
      cast notation; to the point where in many real use-cases, the parser would
      misinterpret what was wanted.
      
      Committing this as a separate patch, with the thought that we might want
      to revert part or all of it if we can think of some way around the cast
      ambiguity.
      df735844
  5. 22 Nov, 2011 5 commits
    • Tom Lane's avatar
      Improve implementation of range-contains-element tests. · cddc819e
      Tom Lane authored
      Implement these tests directly instead of constructing a singleton range
      and then applying range-contains.  This saves a range serialize/deserialize
      cycle as well as a couple of redundant bound-comparison steps, and adds
      very little code on net.
      
      Remove elem_contained_by_range from the GiST opclass: it doesn't belong
      there because there is no way to use it in an index clause (where the
      indexed column would have to be on the left).  Its commutator is in the
      opclass, and that's what counts.
      cddc819e
    • Robert Haas's avatar
      Check for INSERT privileges in SELECT INTO / CREATE TABLE AS. · f1b4aa2a
      Robert Haas authored
      In the normal course of events, this matters only if ALTER DEFAULT
      PRIVILEGES has been used to revoke default INSERT permission.  Whether
      or not the new behavior is more or less likely to be what the user wants
      when dealing only with the built-in privilege facilities is arguable,
      but it's clearly better when using a loadable module such as sepgsql
      that may use the hook in ExecCheckRTPerms to enforce additional
      permissions checks.
      
      KaiGai Kohei, reviewed by Albe Laurenz
      f1b4aa2a
    • Tom Lane's avatar
      Still more review for range-types patch. · 766948be
      Tom Lane authored
      Per discussion, relax the range input/construction rules so that the
      only hard error is lower bound > upper bound.  Cases where the lower
      bound is <= upper bound, but the range nonetheless normalizes to empty,
      are now permitted.
      
      Fix core dump in range_adjacent when bounds are infinite.  Marginal
      cleanup of regression test cases, some more code commenting.
      766948be
    • Peter Eisentraut's avatar
      Small markup and wording improvement · 024ea25c
      Peter Eisentraut authored
      024ea25c
    • Simon Riggs's avatar
      Continue to allow VACUUM to mark last block of index dirty · 2d2841a5
      Simon Riggs authored
      even when there is no work to do. Further analysis required.
      Revert of patch c1458cc4
      2d2841a5
  6. 21 Nov, 2011 3 commits
    • Tom Lane's avatar
      More code review for rangetypes patch. · a4ffcc8e
      Tom Lane authored
      Fix up some infelicitous coding in DefineRange, and add some missing error
      checks.  Rearrange operator strategy number assignments for GiST anyrange
      opclass so that they don't make such a mess of opr_sanity's table of
      operator names associated with different strategy numbers.  Assign
      hopefully-temporary selectivity estimators to range operators that didn't
      have one --- poor as the estimates are, they're still a lot better than the
      default 0.5 estimate, and they'll shut up the opr_sanity test that wants to
      see selectivity estimators on all built-in operators.
      a4ffcc8e
    • Tom Lane's avatar
      Fix citext upgrade script to update derived copies of pg_type.typcollation. · 9b97b7f8
      Tom Lane authored
      If the existing citext type has not merely been created, but used in any
      tables, then the upgrade script wasn't doing enough.  We have to update
      attcollation for each citext table column, and indcollation for each citext
      index column, as well.  Per report from Rudolf van der Leeden.
      9b97b7f8
    • Tom Lane's avatar
      Further code review for range types patch. · b985d487
      Tom Lane authored
      Fix some bugs in coercion logic and pg_dump; more comment cleanup;
      minor cosmetic improvements.
      b985d487
  7. 19 Nov, 2011 1 commit
    • Tom Lane's avatar
      Avoid floating-point underflow while tracking buffer allocation rate. · 40d35036
      Tom Lane authored
      When the system is idle for awhile after activity, the "smoothed_alloc"
      state variable in BgBufferSync converges slowly to zero.  With standard
      IEEE float arithmetic this results in several iterations with denormalized
      values, which causes kernel traps and annoying log messages on some
      poorly-designed platforms.  There's no real need to track such small values
      of smoothed_alloc, so we can prevent the kernel traps by forcing it to zero
      as soon as it's too small to be interesting for our purposes.  This issue
      is purely cosmetic, since the iterations don't happen fast enough for the
      kernel traps to pose any meaningful performance problem, but still it seems
      worth shutting up the log messages.
      
      The kernel log messages were previously reported by a number of people,
      but kudos to Greg Matthews for tracking down exactly where they were coming
      from.
      40d35036
  8. 18 Nov, 2011 5 commits
  9. 17 Nov, 2011 4 commits
    • Tom Lane's avatar
      Declare range inclusion operators as taking anyelement not anynonarray. · 709aca59
      Tom Lane authored
      Use of anynonarray was a crude hack to get around ambiguity versus the
      array inclusion operators of the same names.  My previous patch to extend
      the parser's type resolution heuristics makes that unnecessary, so use
      the more general declaration instead.  This eliminates a wart that these
      operators couldn't be used with ranges over arrays, which are otherwise
      supported just fine.
      
      Also, mark range_before and range_after as commutator operators,
      per discussion with Jeff Davis.
      709aca59
    • Tom Lane's avatar
      Extend the unknowns-are-same-as-known-inputs type resolution heuristic. · 1a8b9fb5
      Tom Lane authored
      For a very long time, one of the parser's heuristics for resolving
      ambiguous operator calls has been to assume that unknown-type literals are
      of the same type as the other input (if it's known).  However, this was
      only used in the first step of quickly checking for an exact-types match,
      and thus did not help in resolving matches that require coercion, such as
      matches to polymorphic operators.  As we add more polymorphic operators,
      this becomes more of a problem.  This patch adds another use of the same
      heuristic as a last-ditch check before failing to resolve an ambiguous
      operator or function call.  In particular this will let us define the range
      inclusion operator in a less limited way (to come in a follow-on patch).
      1a8b9fb5
    • Tom Lane's avatar
      Fix range_cmp_bounds for the case of equal-valued exclusive bounds. · bf4f96b5
      Tom Lane authored
      Also improve its comments and related regression tests.
      
      Jeff Davis, with some further adjustments by Tom
      bf4f96b5
    • Alvaro Herrera's avatar
      Don't quote language name · ef27c81d
      Alvaro Herrera authored
      Same as previous patch, but give it actual thought this time
      ef27c81d