1. 03 Mar, 2008 11 commits
  2. 02 Mar, 2008 2 commits
  3. 01 Mar, 2008 3 commits
    • Tom Lane's avatar
      Fix another place that was assuming that a local variable declared as · d50e256b
      Tom Lane authored
      "struct varlena" would be at least word-aligned.  Per buildfarm results
      from gypsy_moth.  I did a little bit of trawling for other instances of
      this coding pattern, and didn't find any; but if we turn up any more
      of them I think we'd better revert the "char [4]" patch and find another
      way of making tuptoaster.c alignment-safe.
      d50e256b
    • Tom Lane's avatar
      Fix unportable usages of tolower(). On signed-char machines, it is necessary · e04fa58d
      Tom Lane authored
      to explicitly cast the output back to char before comparing it to a char
      value, else we get the wrong result for high-bit-set characters.  Found by
      Rolf Jentsch.  Also, fix several places where <ctype.h> functions were being
      called without casting the argument to unsigned char; this is likewise
      unportable, but we keep making that mistake :-(.  These found by buildfarm
      member salamander, which I will desperately miss if it ever goes belly-up.
      e04fa58d
    • Tom Lane's avatar
      Disable the undocumented xmlvalidate() function, which was unintentionally · 3bf822c4
      Tom Lane authored
      left in the code though it was not meant to be provided.  It represents a
      security hole because unprivileged users could use it to look at (at least the
      first line of) any file readable by the backend.  Fortunately, this is only
      possible if the backend was built with XML support, so the damage is at least
      mitigated; and 8.3 probably hasn't propagated into any security-critical uses
      yet anyway.  Per report from Sergey Burladyan.
      3bf822c4
  4. 29 Feb, 2008 7 commits
    • Andrew Dunstan's avatar
      Don't call AddUserToDacl on Cygwin · 64f30bb2
      Andrew Dunstan authored
      64f30bb2
    • Alvaro Herrera's avatar
      Remove long-unused and broken TCL_ARRAYS. · 7157114d
      Alvaro Herrera authored
      7157114d
    • Tom Lane's avatar
      Reducing the assumed alignment of struct varlena means that the compiler · c67f6f2f
      Tom Lane authored
      is also licensed to put a local variable declared that way at an unaligned
      address.  Which will not work if the variable is then manipulated with
      SET_VARSIZE or other macros that assume alignment.  So the previous patch
      is not an unalloyed good, but on balance I think it's still a win, since
      we have very few places that do that sort of thing.  Fix the one place in
      tuptoaster.c that does it.  Per buildfarm results from gypsy_moth
      (I'm a bit surprised that only one machine showed a failure).
      c67f6f2f
    • Magnus Hagander's avatar
      Fix handling of restricted processes for Windows Vista (mainly), · 2d2b0222
      Magnus Hagander authored
      by explicitly adding back the user to the DACL of the new process.
      This fixes the failure case when executing as the Administrator
      user, which had no permissions left at all after we dropped the
      Administrators group.
      
      Dave Page with some modifications from me
      2d2b0222
    • Bruce Momjian's avatar
      Update wording: · 4db0d87c
      Bruce Momjian authored
      < * Add Oracle-style packages  (Pavel)
      > * Add features of Oracle-style packages  (Pavel)
      4db0d87c
    • Peter Eisentraut's avatar
      02504dfd
    • Neil Conway's avatar
      Fix several memory leaks when rescanning SRFs. Arrange for an SRF's · ff428cde
      Neil Conway authored
      "multi_call_ctx" to be a distinct sub-context of the EState's per-query
      context, and delete the multi_call_ctx as soon as the SRF finishes
      execution. This avoids leaking SRF memory until the end of the current
      query, which is particularly egregious when the SRF is scanned
      multiple times. This change also fixes a leak of the fields of the
      AttInMetadata struct in shutdown_MultiFuncCall().
      
      Also fix a leak of the SRF result TupleDesc when rescanning a
      FunctionScan node. The TupleDesc is allocated in the per-query context
      for every call to ExecMakeTableFunctionResult(), so we should free it
      after calling that function. Since the SRF might choose to return
      a non-expendable TupleDesc, we only free the TupleDesc if it is
      not being reference-counted.
      
      Backpatch to 8.3 and 8.2 stable branches.
      ff428cde
  5. 28 Feb, 2008 1 commit
  6. 27 Feb, 2008 2 commits
  7. 26 Feb, 2008 13 commits
  8. 25 Feb, 2008 1 commit
    • Tom Lane's avatar
      Reject year zero during datetime input, except when it's a 2-digit year · bc93919b
      Tom Lane authored
      (then it means 2000 AD).  Formerly we silently interpreted this as 1 BC,
      which at best is unwarranted familiarity with the implementation.
      It's barely possible that some app somewhere expects the old behavior,
      though, so we won't back-patch this into existing release branches.
      bc93919b