1. 10 Oct, 2012 3 commits
    • Bruce Momjian's avatar
      a9701a1d
    • Tom Lane's avatar
      Set procost to 10 for each of the pg_foo_is_visible() functions. · a80889a7
      Tom Lane authored
      The idea here is to make sure the planner will evaluate these functions
      last not first among the filter conditions in psql pattern search and
      tab-completion queries.  We've discussed this several times, and there
      was consensus to do it back in August, but we didn't want to do it just
      before a release.  Now seems like a safer time.
      
      No catversion bump, since this catalog change doesn't create a backend
      incompatibility nor any regression test result changes.
      a80889a7
    • Tom Lane's avatar
      Fix PGXS support for building loadable modules on AIX. · 3f88fa97
      Tom Lane authored
      Building a shlib on AIX requires use of the mkldexport.sh script, but we
      failed to install that, preventing its use from non-source-tree contexts.
      Also, Makefile.aix had the wrong idea about where to find the installed
      copy of the postgres.imp symbol file used by AIX.
      
      Per report from John Pierce.  Patch all the way back, since this has been
      broken since the beginning of PGXS.
      3f88fa97
  2. 09 Oct, 2012 12 commits
    • Tom Lane's avatar
      Remove unnecessary overhead in backend's large-object operations. · 7e0cce02
      Tom Lane authored
      Do read/write permissions checks at most once per large object descriptor,
      not once per lo_read or lo_write call as before.  The repeated tests were
      quite useless in the read case since the snapshot-based tests were
      guaranteed to produce the same answer every time.  In the write case,
      the extra tests could in principle detect revocation of write privileges
      after a series of writes has started --- but there's a race condition there
      anyway, since we'd check privileges before performing and certainly before
      committing the write.  So there's no real advantage to checking every
      single time, and we might as well redefine it as "only check the first
      time".
      
      On the same reasoning, remove the LargeObjectExists checks in inv_write
      and inv_truncate.  We already checked existence when the descriptor was
      opened, and checking again doesn't provide any real increment of safety
      that would justify the cost.
      7e0cce02
    • Heikki Linnakangas's avatar
      Fix silly bug in previous refactoring. · 2d8c81ac
      Heikki Linnakangas authored
      I extracted the refactoring patch from a larger patch that contained other
      changes too, but missed one unintentional change and didn't test enough...
      2d8c81ac
    • Heikki Linnakangas's avatar
      Put the logic to wait for WAL in standby mode to a separate function. · ff8f160b
      Heikki Linnakangas authored
      This is just refactoring with no user-visible effect, to make the code more
      readable.
      ff8f160b
    • Alvaro Herrera's avatar
      restore permission bits · f7491616
      Alvaro Herrera authored
      f7491616
    • Alvaro Herrera's avatar
      Rename USE_INLINE to PG_USE_INLINE · f46baf60
      Alvaro Herrera authored
      The former name was too likely to conflict with symbols from external
      headers; and, as seen in recent buildfarm failures in member spoonbill,
      it has now happened at least in plpython.
      f46baf60
    • Heikki Linnakangas's avatar
      Remove stray newline in comment. · 0b77aeba
      Heikki Linnakangas authored
      0b77aeba
    • Simon Riggs's avatar
      Use tablespace_option consistently on doc page · 21903771
      Simon Riggs authored
      Fujii Masao
      21903771
    • Simon Riggs's avatar
      Add microsecs/op display to pg_test_fsync utility · 82e42979
      Simon Riggs authored
      e.g. fsync  2103.613 ops/sec (   475 microsecs/op)
      
      Peter Geoghegan
      82e42979
    • Tom Lane's avatar
      Fix lo_import and lo_export to return useful error messages more often. · bc433317
      Tom Lane authored
      I found that these functions tend to return -1 while leaving an empty error
      message string in the PGconn, if they suffer some kind of I/O error on the
      file.  The reason is that lo_close, which thinks it's executed a perfectly
      fine SQL command, clears the errorMessage.  The minimum-change workaround
      is to reorder operations here so that we don't fill the errorMessage until
      after lo_close.
      bc433317
    • Tom Lane's avatar
      Fix lo_export usage in example programs. · f52c5165
      Tom Lane authored
      lo_export returns -1, not zero, on failure.
      f52c5165
    • Tom Lane's avatar
      Fix lo_read, lo_write, lo_truncate to cope with "size_t" length parameters. · 0e924c00
      Tom Lane authored
      libpq defines these functions as accepting "size_t" lengths ... but the
      underlying backend functions expect signed int32 length parameters, and so
      will misinterpret any value exceeding INT_MAX.  Fix the libpq side to throw
      error rather than possibly doing something unexpected.
      
      This is a bug of long standing, but I doubt it's worth back-patching.  The
      problem is really pretty academic anyway with lo_read/lo_write, since any
      caller expecting sane behavior would have to have provided a multi-gigabyte
      buffer.  It's slightly more pressing with lo_truncate, but still we haven't
      supported large objects over 2GB until now.
      0e924c00
    • Peter Eisentraut's avatar
      Remove generation of repl_gram.h · b6d45222
      Peter Eisentraut authored
      It was apparently never necessary.
      b6d45222
  3. 08 Oct, 2012 7 commits
    • Tom Lane's avatar
      Code review for 64-bit-large-object patch. · 26fe5648
      Tom Lane authored
      Fix broken-on-bigendian-machines byte-swapping functions, add missed update
      of alternate regression expected file, improve error reporting, remove some
      unnecessary code, sync testlo64.c with current testlo.c (it seems to have
      been cloned from a very old copy of that), assorted cosmetic improvements.
      26fe5648
    • Alvaro Herrera's avatar
      Fix thinko in previous commit · 878daf2e
      Alvaro Herrera authored
      Since postgres.h includes palloc.h, definitions that affect the latter
      must be present before the former is included.
      
      Per buildfarm results
      878daf2e
    • Alvaro Herrera's avatar
      Add support for easily declaring static inline functions · 976fa10d
      Alvaro Herrera authored
      We already had those, but they forced modules to spell out the function
      bodies twice.  Eliminate some duplicates we had already grown.
      
      Extracted from a somewhat larger patch from Andres Freund.
      976fa10d
    • Robert Haas's avatar
      Add #define for UUIDOID. · 08c8058c
      Robert Haas authored
      Phil Sorber and Thom Brown. Reviewed by Albe Laurenz.
      08c8058c
    • Heikki Linnakangas's avatar
      b28cc92d
    • Heikki Linnakangas's avatar
      Fix walsender handling of postmaster shutdown, to not go into endless loop. · 9c0e2b91
      Heikki Linnakangas authored
      This bug was introduced by my patch to use the regular die/quickdie signal
      handlers in walsender processes. I tried to make walsender exit at next
      CHECK_FOR_INTERRUPTS() by setting ProcDiePending, but that's not enough, you
      need to set InterruptPending too. On second thoght, it was not a very good
      way to make walsender exit anyway, so use proc_exit(0) instead.
      
      Also, send a CommandComplete message before exiting; that's what we did
      before, and you get a nicer error message in the standby that way.
      
      Reported by Thom Brown.
      9c0e2b91
    • Tom Lane's avatar
      Autoconfiscate selection of 64-bit int type for 64-bit large object API. · 95d035e6
      Tom Lane authored
      Get rid of the fundamentally indefensible assumption that "long long int"
      exists and is exactly 64 bits wide on every platform Postgres runs on.
      Instead let the configure script select the type to use for "pg_int64".
      
      This is a bit of a pain in the rear since we do not want to pollute client
      namespace with all the random symbols that pg_config.h defines; instead
      we have to create a separate generated header file, "pg_config_ext.h".
      But now that the infrastructure is there, we might have the ability to
      add some other stuff that's long been wanting in this area.
      95d035e6
  4. 07 Oct, 2012 5 commits
  5. 06 Oct, 2012 2 commits
    • Tatsuo Ishii's avatar
      Add API for 64-bit large object access. Now users can access up to · 461ef73f
      Tatsuo Ishii authored
      4TB large objects (standard 8KB BLCKSZ case).  For this purpose new
      libpq API lo_lseek64, lo_tell64 and lo_truncate64 are added.  Also
      corresponding new backend functions lo_lseek64, lo_tell64 and
      lo_truncate64 are added. inv_api.c is changed to handle 64-bit
      offsets.
      
      Patch contributed by Nozomi Anzai (backend side) and Yugo Nagata
      (frontend side, docs, regression tests and example program). Reviewed
      by Kohei Kaigai. Committed by Tatsuo Ishii with minor editings.
      461ef73f
    • Peter Eisentraut's avatar
      Improve LDAP authentication documentation · ae835c7d
      Peter Eisentraut authored
      Use the terms "simple bind" and "search+bind" consistently do
      distinguish the two modes (better than first mode and second mode in
      any case).  They were already used in some places, now it's just more
      prominent.
      
      Split up the list of options into one for common options and one for
      each mode, for clarity.
      
      Add configuration examples for either mode.
      ae835c7d
  6. 05 Oct, 2012 6 commits
  7. 04 Oct, 2012 4 commits
    • Tom Lane's avatar
      Make CREATE AGGREGATE complain if the initcond is invalid for the datatype. · e1e60694
      Tom Lane authored
      The initial transition value is stored as a text string and not fed to the
      transition type's input function until runtime (so that values such as
      "now" don't get frozen at creation time).  Previously, CREATE AGGREGATE
      didn't do anything with it but that, which meant that even erroneous values
      would be accepted and not complained of until the aggregate is used.  This
      seems unhelpful, and it's confused at least one user, as in Rhys Stewart's
      recent report.  It seems worth taking a few more cycles to invoke the input
      function and verify that the value is acceptable.  We can't do this if the
      transition type is polymorphic, but in normal aggregates we know the actual
      transition type so we can call the right input function.
      e1e60694
    • Tom Lane's avatar
      Fix parse location tracking for lists that can be empty. · 70726354
      Tom Lane authored
      The previous coding of the YYLLOC_DEFAULT macro behaved strangely for empty
      productions, assigning the previous nonterminal's location as the parse
      location of the result.  The usefulness of that was (at best) debatable
      already, but the real problem is that in list-generating nonterminals like
      	OptFooList: /* EMPTY */ { ... } | OptFooList Foo { ... } ;
      the initially-identified location would get copied up, so that even a
      nonempty list would be given a bogus parse location.  Document how to work
      around that, and do so for OptSchemaEltList, so that the error condition
      just added for CREATE SCHEMA IF NOT EXISTS produces a sane error cursor.
      So far as I can tell, there are currently no other cases where the
      situation arises, so we don't need other instances of this coding yet.
      70726354
    • Tom Lane's avatar
      Fix permissions explanations in CREATE DATABASE and CREATE SCHEMA docs. · 7e389f73
      Tom Lane authored
      These reference pages still claimed that you have to be superuser to create
      a database or schema owned by a different role.  That was true before 8.1,
      but it was changed in commits aa111062 and
      f91370cd to allow assignment of ownership
      to any role you are a member of.  However, at the time we were thinking of
      that primarily as a change to the ALTER OWNER rules, so the need to touch
      these two CREATE ref pages got missed.
      7e389f73
    • Heikki Linnakangas's avatar
  8. 03 Oct, 2012 1 commit
    • Tom Lane's avatar
      Support CREATE SCHEMA IF NOT EXISTS. · fb34e94d
      Tom Lane authored
      Per discussion, schema-element subcommands are not allowed together with
      this option, since it's not very obvious what should happen to the element
      objects.
      
      Fabrízio de Royes Mello
      fb34e94d