1. 17 Jun, 2011 8 commits
    • Tom Lane's avatar
      Don't use "cp -i" in the example WAL archive_command. · a2624c68
      Tom Lane authored
      This is a dangerous example to provide because on machines with GNU cp,
      it will silently do the wrong thing and risk archive corruption.  Worse,
      during the 9.0 cycle somebody "improved" the discussion by removing the
      warning that used to be there about that, and instead leaving the
      impression that the command would work as desired on most Unixen.
      It doesn't.  Try to rectify the damage by providing an example that is safe
      most everywhere, and then noting that you can try cp -i if you want but
      you'd better test that.
      
      In back-patching this to all supported branches, I also added an example
      command for Windows, which wasn't provided before 9.0.
      a2624c68
    • Andrew Dunstan's avatar
      Set FLEXIBLE_ARRAY_MEMBER to empty for MSVC. · ddef31c1
      Andrew Dunstan authored
      Per gripe from Tom Lane. I have tested this with VC 2008, and assume
      it will work with earlier versions.
      ddef31c1
    • Tom Lane's avatar
      Obtain table locks as soon as practical during pg_dump. · 68d977a7
      Tom Lane authored
      For some reason, when we (I) added table lock acquisition to pg_dump,
      we didn't think about making it happen as soon as possible after the
      start of the transaction.  What with subsequent additions, there was
      actually quite a lot going on before we got around to that; which sort
      of defeats the purpose.  Rearrange the order of calls in dumpSchema()
      to close the risk window as much as we easily can.  Back-patch to all
      supported branches.
      68d977a7
    • Robert Haas's avatar
      Add overflow checks to int4 and int8 versions of generate_series(). · 062780ec
      Robert Haas authored
      The previous code went into an infinite loop after overflow.  In fact,
      an overflow is not really an error; it just means that the current
      value is the last one we need to return.  So, just arrange to stop
      immediately when overflow is detected.
      
      Back-patch all the way.
      062780ec
    • Robert Haas's avatar
      Fix crash in CREATE UNLOGGED TABLE. · bf347c60
      Robert Haas authored
      The code that created the init fork neglected to make sure that the
      relation was open at the smgr level before attempting to invoke smgr.
      This didn't happen every time; only when the relcache entry was rebuilt
      along the way.
      
      Per report from Garick Hamlin.
      bf347c60
    • Robert Haas's avatar
      Fix minor thinko in ProcGlobalShmemSize(). · c573486c
      Robert Haas authored
      There's no need to add space for startupBufferPinWaitBufId, because
      it's part of the PROC_HDR object for which this function already
      allocates space.
      
      This has been wrong for a while, but the only consequence is that our
      shared memory allocation is increased by 4 bytes, so no back-patch.
      c573486c
    • Robert Haas's avatar
      Fix typo. · d61ec7c7
      Robert Haas authored
      Per Josh Kupershmidt and Tom Lane.
      d61ec7c7
    • Andrew Dunstan's avatar
      Define FLEXIBLE_ARRAY_MEMBER for MSVC. · 236a11dc
      Andrew Dunstan authored
      236a11dc
  2. 16 Jun, 2011 9 commits
  3. 15 Jun, 2011 6 commits
    • Tom Lane's avatar
      Rework parsing of ConstraintAttributeSpec to improve NOT VALID handling. · e1ccaff6
      Tom Lane authored
      The initial commit of the ALTER TABLE ADD FOREIGN KEY NOT VALID feature
      failed to support labeling such constraints as deferrable.  The best fix
      for this seems to be to fold NOT VALID into ConstraintAttributeSpec.
      That's a bit more general than the documented syntax, but it allows
      better-targeted syntax error messages.
      
      In addition, do some mostly-but-not-entirely-cosmetic code review for
      the whole NOT VALID patch.
      e1ccaff6
    • Bruce Momjian's avatar
    • Tom Lane's avatar
      Fix failure to account for memory used by tuplestore_putvalues(). · 10db3de6
      Tom Lane authored
      This oversight could result in a tuplestore using much more than the
      intended amount of memory.  It would only happen in a code path that loaded
      a tuplestore via tuplestore_putvalues(), and many of those won't emit huge
      amounts of data; but cases such as holdable cursors and plpgsql's RETURN
      NEXT command could have the problem.  The fix ensures that the tuplestore
      will switch to write-to-disk mode when it overruns work_mem.
      
      The potential overrun was finite, because we would still count the space
      used by the tuple pointer array, so the tuplestore code would eventually
      flip into write-to-disk mode anyway.  When storing wide tuples we would
      go far past the expected work_mem usage before that happened; but this
      may account for the lack of prior reports.
      
      Back-patch to 8.4, where tuplestore_putvalues was introduced.
      
      Per bug #6061 from Yann Delorme.
      10db3de6
    • Tom Lane's avatar
      Fix oversights in pg_basebackup's -z (compression) option. · 31156ce8
      Tom Lane authored
      The short-form -z switch didn't work, for lack of telling getopt_long
      about it; and even if specified long-form, it failed to do anything,
      because the various tests elsewhere in the file would take
      Z_DEFAULT_COMPRESSION (which is -1) as meaning "don't compress".
      
      Per bug #6060 from Shigehiro Honda, though I editorialized on his patch
      a bit.
      31156ce8
    • Heikki Linnakangas's avatar
      The rolled-back flag on serializable xacts was pointless and redundant with · 264a6b12
      Heikki Linnakangas authored
      the marked-for-death flag. It was only set for a fleeting moment while a
      transaction was being cleaned up at rollback. All the places that checked
      for the rolled-back flag should also check the marked-for-death flag, as
      both flags mean that the transaction will roll back. I also renamed the
      marked-for-death into "doomed", which is a lot shorter name.
      264a6b12
    • Heikki Linnakangas's avatar
      Make non-MVCC snapshots exempt from predicate locking. Scans with non-MVCC · 0a0e2b52
      Heikki Linnakangas authored
      snapshots, like in REINDEX, are basically non-transactional operations. The
      DDL operation itself might participate in SSI, but there's separate
      functions for that.
      
      Kevin Grittner and Dan Ports, with some changes by me.
      0a0e2b52
  4. 14 Jun, 2011 14 commits
  5. 13 Jun, 2011 3 commits