1. 07 Sep, 2001 19 commits
  2. 06 Sep, 2001 21 commits
    • Bruce Momjian's avatar
      >Well, if it is that easy, I can do it. Patch attached and applied. · 0059c421
      Bruce Momjian authored
      >
      >> On Mon, 3 Sep 2001 22:01:17 -0500, you wrote:
      >>     public boolean isWritable(int column) throws SQLException
      >>     {
      >>         return !isReadOnly(column);
      >>     }
      
      Actually, I think this change has a consequence for this method
      in the same class:
      
          public boolean isDefinitelyWritable(int column)
              throws SQLException
          {
              return isWritable(column);
          }
      
      This is from the JDBC spec
      (http://java.sun.com/j2se/1.3/docs/api/java/sql/ResultSetMetaData.html):
      
        isReadOnly() - Indicates whether the designated column is
      definitely not writable.
      
        isWritable() - Indicates whether it is possible for a write on
      the designated column to succeed.
      
        isDefinitelyWritable() - Indicates whether a write on the
      designated column will definitely succeed.
      
      At this time we don't really implement the fine semantics of
      these methods. I would suggest the following defaults:
      
        isReadOnly()             false
        isWritable()             true
        isDefinitelyWritable()   false
      
      And that would mean that your patch is correct, but
      isDefinitelyWritable() would need to be patched accordingly:
      
          public boolean isDefinitelyWritable(int column)
              throws SQLException
          {
              return false;
          }
      
      Again, both in jdbc1 and jdbc2.
      
      Regards,
      Ren? Pijlman <rene@lab.applinet.nl>
      0059c421
    • Bruce Momjian's avatar
      Update transactions for nested idea. · 1fbb2d9c
      Bruce Momjian authored
      1fbb2d9c
    • Bruce Momjian's avatar
      Update TODO list. · 68a3d2ef
      Bruce Momjian authored
      68a3d2ef
    • Bruce Momjian's avatar
      Update TODO list. · e64ca057
      Bruce Momjian authored
      e64ca057
    • Bruce Momjian's avatar
      Update TODO list. · e2b668bb
      Bruce Momjian authored
      e2b668bb
    • Bruce Momjian's avatar
      On Mon, 3 Sep 2001 22:01:17 -0500, you wrote: · afa178e7
      Bruce Momjian authored
      >public boolean isWritable(int column) throws SQLException
      >{
      >        if (isReadOnly(column))
      >                return true;
      >        else
      >                return false;
      >}
      
      The author probably intended:
      
          public boolean isWritable(int column) throws SQLException
          {
              return !isReadOnly(column);
          }
      
      And if he would have coded it this way he wouldn't have made
      this mistake :-)
      
      >hence, isWritable() will always return false. this is something
      >of a problem :)
      
      Why exactly? In a way, true is just as incorrect as false, and
      perhaps it should throw "not implemented". But I guess that
      would be too non-backwardly-compatible.
      
      >let me know if i can provide further information.
      
      Will you submit a patch?
      
      Regards,
      Ren? Pijlman <rene@lab.applinet.nl>
      afa178e7
    • Bruce Momjian's avatar
      Update TODO list. · e4cfff65
      Bruce Momjian authored
      e4cfff65
    • Bruce Momjian's avatar
      Add mutex test. · e9dc342e
      Bruce Momjian authored
      e9dc342e
    • Bruce Momjian's avatar
      Update TODO list. · 11808a9f
      Bruce Momjian authored
      11808a9f
    • Bruce Momjian's avatar
      Add to syntax error reporting. · 4f952aaa
      Bruce Momjian authored
      4f952aaa
    • Bruce Momjian's avatar
      > The win32.mak and libpgtcl.def files had been lost (patch doesn't handle · 343e38a9
      Bruce Momjian authored
      > new files). I'm attaching those two files below.
      >
      > Regards
      > Mikhail Terekhov
      343e38a9
    • Bruce Momjian's avatar
      Add -rpath for BSD/OS, from Peter E. · 495e264f
      Bruce Momjian authored
      495e264f
    • Bruce Momjian's avatar
      > Patch applied. Thanks. · f57477e6
      Bruce Momjian authored
      Thanks. However, I seem to have left a single debug statement in there :-(
      
      Here's a patch to remove it.
      
      Vianen, Jeroen van
      f57477e6
    • Peter Eisentraut's avatar
      Russian translation from Serguei Mokhov · 88371647
      Peter Eisentraut authored
      88371647
    • Peter Eisentraut's avatar
      To fix the perpetually broken makefiles in the contrib tree, I have · 17cc78ef
      Peter Eisentraut authored
      written a generic framework of rules that the contrib makefiles can
      use instead of writing their own each time.  You only need to set a few
      variables and off you go.
      17cc78ef
    • Peter Eisentraut's avatar
      Move the "how to write a PL call handler" parts from the CREATE LANGUAGE · 22ae53d4
      Peter Eisentraut authored
      man page to the Programmer's Guide.
      22ae53d4
    • Tatsuo Ishii's avatar
      Fix Karel's patch. Suggested by Eiji Tokuya · f25ed23c
      Tatsuo Ishii authored
      f25ed23c
    • Tatsuo Ishii's avatar
      Commit Karel's patch. · 22776711
      Tatsuo Ishii authored
      -------------------------------------------------------------------
      Subject: Re: [PATCHES] encoding names
      From: Karel Zak <zakkr@zf.jcu.cz>
      To: Peter Eisentraut <peter_e@gmx.net>
      Cc: pgsql-patches <pgsql-patches@postgresql.org>
      Date: Fri, 31 Aug 2001 17:24:38 +0200
      
      On Thu, Aug 30, 2001 at 01:30:40AM +0200, Peter Eisentraut wrote:
      > > 		- convert encoding 'name' to 'id'
      >
      > I thought we decided not to add functions returning "new" names until we
      > know exactly what the new names should be, and pending schema
      
       Ok, the patch not to add functions.
      
      > better
      >
      >     ...(): encoding name too long
      
       Fixed.
      
       I found new bug in command/variable.c in parse_client_encoding(), nobody
      probably never see this error:
      
      if (pg_set_client_encoding(encoding))
      {
      	elog(ERROR, "Conversion between %s and %s is not supported",
                           value, GetDatabaseEncodingName());
      }
      
      because pg_set_client_encoding() returns -1 for error and 0 as true.
      It's fixed too.
      
       IMHO it can be apply.
      
      		Karel
      PS:
      
          * following files are renamed:
      
      src/utils/mb/Unicode/KOI8_to_utf8.map  -->
              src/utils/mb/Unicode/koi8r_to_utf8.map
      
      src/utils/mb/Unicode/WIN_to_utf8.map  -->
              src/utils/mb/Unicode/win1251_to_utf8.map
      
      src/utils/mb/Unicode/utf8_to_KOI8.map -->
              src/utils/mb/Unicode/utf8_to_koi8r.map
      
      src/utils/mb/Unicode/utf8_to_WIN.map -->
              src/utils/mb/Unicode/utf8_to_win1251.map
      
         * new file:
      
      src/utils/mb/encname.c
      
         * removed file:
      
      src/utils/mb/common.c
      
      --
       Karel Zak  <zakkr@zf.jcu.cz>
       http://home.zf.jcu.cz/~zakkr/
      
       C, PostgreSQL, PHP, WWW, http://docs.linux.cz, http://mape.jcu.cz
      22776711
    • Bruce Momjian's avatar
      Add missing files. · 50aa3020
      Bruce Momjian authored
      50aa3020
    • Bruce Momjian's avatar
      Update TODO list. · 311eef41
      Bruce Momjian authored
      311eef41
    • Bruce Momjian's avatar
      PAM authentication: · 04c1f729
      Bruce Momjian authored
      > pam_strerror() should be used a few more times, rather than just saying
      > "Error!".  Also, the configure.in snippet seems wrong.  You add
      > -I$pam_prefix/include/security to $INCLUDES and then you #include
      > <security/pam_appl.h>.  This whole thing is probably unnecessary, since
      > PAM is a system library on the systems where it exists, so the headers
      > and libraries are found automatically, unlike OpenSSL and
      > Kerberos.
      
      See attached revised patch. (I'm sure the configure.in stuff can be done
      right/better, I'm just not enough of a autoconf guru to know what to
      change it to.)
      
      Dominic J. Eidson
      04c1f729