1. 19 May, 2000 4 commits
    • Tom Lane's avatar
      pg_dump barfs on negative values for index column numbers --- like, say, · 8b5b3e00
      Tom Lane authored
      an index on a table's OID column.  Mea maxima culpa ... but how'd we get
      through beta with no one noticing this?
      8b5b3e00
    • Bruce Momjian's avatar
      Update TODO list. · 4763cdda
      Bruce Momjian authored
      4763cdda
    • Tom Lane's avatar
      Revise FlushRelationBuffers/ReleaseRelationBuffers per discussion with · f923260e
      Tom Lane authored
      Hiroshi.  ReleaseRelationBuffers now removes rel's buffers from pool,
      instead of merely marking them nondirty.  The old code would leave valid
      buffers for a deleted relation, which didn't cause any known problems
      but can't possibly be a good idea.  There were several places which called
      ReleaseRelationBuffers *and* FlushRelationBuffers, which is now
      unnecessary; but there were others that did not.  FlushRelationBuffers
      no longer emits a warning notice if it finds dirty buffers to flush,
      because with the current bufmgr behavior that's not an unexpected
      condition.  Also, FlushRelationBuffers will flush out all dirty buffers
      for the relation regardless of block number.  This ensures that
      pg_upgrade's expectations are met about tuple on-row status bits being
      up-to-date on disk.  Lastly, tweak BufTableDelete() to clear the
      buffer's tag so that no one can mistake it for being a still-valid
      buffer for the page it once held.  Formerly, the buffer would not be
      found by buffer hashtable searches after BufTableDelete(), but it would
      still be thought to belong to its old relation by the routines that
      sequentially scan the shared-buffer array.  Again I know of no bugs
      caused by that, but it still can't be a good idea.
      f923260e
    • Tom Lane's avatar
      db90fdf9
  2. 18 May, 2000 7 commits
  3. 17 May, 2000 6 commits
  4. 16 May, 2000 5 commits
  5. 15 May, 2000 7 commits
  6. 14 May, 2000 8 commits
  7. 13 May, 2000 1 commit
  8. 12 May, 2000 2 commits
    • Bruce Momjian's avatar
      Fix the off by one errors in ResultSet from 6.5.3, and more. · 2cfb14e8
      Bruce Momjian authored
      I'm including a diff of
      postgresql-7.0/src/interfaces/jdbc/org/postgresql/jdbc2/ResultSet.java.
      I've clearly marked all the fixes I did. Would *someone* who has access
      to the cvs please put this in?
      
      Joseph Shraibman
      2cfb14e8
    • Bruce Momjian's avatar
      This is the second time I've answered this exact same problem in two · a28f1177
      Bruce Momjian authored
      days.  It seems to be a FAQ, and I think I know why. When creating a 'c'
      language function, CREATE FUNCTION is fed the shared object filename,
      and seems to succeed. Only when trying to use the function is an error
      thrown, by which time the coder thinks something's wrong with executing
      the code, not with loading it.
      
      I think I once saw it proposed to load shared objects at function creation
      time, but that idea was shot down on the grounds of resident memory bloat,
      ISTR. Here's a patch for a compromise: all it does is stat() the file,
      just like the loader code does, so that the errors caused by non existent
      files, and no directory 'x' permissions (the most common ones, it seems),
      get caught while the developer is still thinking about code loading. It
      doesn't catch all errors (like the code not being readable by the postgres
      user) but seems to catch the most common, without actually opening the file.
      
      What do you think?
      
      Ross
      a28f1177