1. 08 Oct, 2009 2 commits
  2. 07 Oct, 2009 2 commits
    • Alvaro Herrera's avatar
      Make it possibly to specify GUC params per user and per database. · 2eda8dfb
      Alvaro Herrera authored
      Create a new catalog pg_db_role_setting where they are now stored, and better
      encapsulate the code that deals with settings into its realm.  The old
      datconfig and rolconfig columns are removed.
      
      psql has gained a \drds command to display the settings.
      
      Backwards compatibility warning: while the backwards-compatible system views
      still have the config columns, they no longer completely represent the
      configuration for a user or database.
      
      Catalog version bumped.
      2eda8dfb
    • Alvaro Herrera's avatar
      Fix snapshot management, take two. · 07cefdfb
      Alvaro Herrera authored
      Partially revert the previous patch I installed and replace it with a more
      general fix: any time a snapshot is pushed as Active, we need to ensure that it
      will not be modified in the future.  This means that if the same snapshot is
      used as CurrentSnapshot, it needs to be copied separately.  This affects
      serializable transactions only, because CurrentSnapshot has already been copied
      by RegisterSnapshot and so PushActiveSnapshot does not think it needs another
      copy.  However, CommandCounterIncrement would modify CurrentSnapshot, whereas
      ActiveSnapshots must not have their command counters incremented.
      
      I say "partially" because the regression test I added for the previous bug
      has been kept.
      
      (This restores 8.3 behavior, because before snapmgr.c existed, any snapshot set
      as Active was copied.)
      
      Per bug report from Stuart Bishop in
      6bc73d4c0910042358k3d1adff3qa36f8df75198ecea@mail.gmail.com
      07cefdfb
  3. 06 Oct, 2009 3 commits
    • Peter Eisentraut's avatar
      Clean up the clean rules of the documentation · 603e72b0
      Peter Eisentraut authored
      Most things should be cleaned by "make clean", except the parts that are
      shipped in the tarball.  These rules had gotten a bit out of whack after
      the various restructurings of the documentation build rules.
      603e72b0
    • Tom Lane's avatar
      Change CREATE TABLE so that column default expressions coming from different · e0c433c4
      Tom Lane authored
      inheritance parent tables are compared using equal(), instead of doing
      strcmp() on the nodeToString representation.  The old implementation was
      always a tad cheesy, and it finally fails completely as of 8.4, now that the
      node tree might contain syntax location information.  equal() knows it's
      supposed to ignore those fields, but strcmp() hardly can.  Per recent
      report from Scott Ribe.
      e0c433c4
    • Alvaro Herrera's avatar
      Really unbreak maintainer-clean. · 051168b6
      Alvaro Herrera authored
      (Or rather, unbreak what the previous commit broke)
      051168b6
  4. 05 Oct, 2009 2 commits
  5. 03 Oct, 2009 3 commits
  6. 02 Oct, 2009 4 commits
    • Tom Lane's avatar
      Fix an oversight in an 8.3-era patch: pgstat_initstats should allow stats · 66a8417f
      Tom Lane authored
      to be collected for sequences.
      
      Report and fix by Akira Kurosawa
      66a8417f
    • Tom Lane's avatar
      Make sure that GIN fast-insert and regular code paths enforce the same · e66d7143
      Tom Lane authored
      tuple size limit.  Improve the error message for index-tuple-too-large
      so that it includes the actual size, the limit, and the index name.
      Sync with the btree occurrences of the same error.
      
      Back-patch to 8.4 because it appears that the out-of-sync problem
      is occurring in the field.
      
      Teodor and Tom
      e66d7143
    • Tom Lane's avatar
      Fix erroneous handling of shared dependencies (ie dependencies on roles) · d691cb91
      Tom Lane authored
      in CREATE OR REPLACE FUNCTION.  The original code would update pg_shdepend
      as if a new function was being created, even if it wasn't, with two bad
      consequences: pg_shdepend might record the wrong owner for the function,
      and any dependencies for roles mentioned in the function's ACL would be lost.
      The fix is very easy: just don't touch pg_shdepend at all when doing a
      function replacement.
      
      Also update the CREATE FUNCTION reference page, which never explained
      exactly what changes and doesn't change in a function replacement.
      In passing, fix the CREATE VIEW reference page similarly; there's no
      code bug there, but the docs didn't say what happens.
      d691cb91
    • Alvaro Herrera's avatar
      Ensure that a cursor has an immutable snapshot throughout its lifespan. · caa4cfa3
      Alvaro Herrera authored
      The old coding was using a regular snapshot, referenced elsewhere, that was
      subject to having its command counter updated.  Fix by creating a private copy
      of the snapshot exclusively for the cursor.
      
      Backpatch to 8.4, which is when the bug was introduced during the snapshot
      management rewrite.
      caa4cfa3
  7. 01 Oct, 2009 2 commits
  8. 30 Sep, 2009 2 commits
    • Tom Lane's avatar
      Fix bogus Assert, per buildfarm results. · f7082f26
      Tom Lane authored
      f7082f26
    • Tom Lane's avatar
      Assorted improvements in contrib/hstore. · 172eacba
      Tom Lane authored
      Remove the 64K limit on the lengths of keys and values within an hstore.
      (This changes the on-disk format, but the old format can still be read.)
      Add support for btree/hash opclasses for hstore --- this is not so much
      for actual indexing purposes as to allow use of GROUP BY, DISTINCT, etc.
      Add various other new functions and operators.
      
      Andrew Gierth
      172eacba
  9. 29 Sep, 2009 3 commits
  10. 28 Sep, 2009 2 commits
  11. 27 Sep, 2009 6 commits
  12. 26 Sep, 2009 4 commits
    • Tom Lane's avatar
      Hmm, seems a lot of the buildfarm is running versions of awk that · 23cf415a
      Tom Lane authored
      don't have gensub().  Use sub() instead, tedious though it be.
      23cf415a
    • Tom Lane's avatar
      Revert my ill-considered change that made formrdesc not insert the correct · ca70c3cf
      Tom Lane authored
      relation rowtype OID into the relcache entries it builds.  This ensures
      that catcache copies of the relation tupdescs will be fully correct.
      While the deficiency doesn't seem to have any effect in the current
      sources, we have been bitten by not-quite-right catcache tupdescs before,
      so it seems like a good idea to maintain the rule that they should be right.
      ca70c3cf
    • Tom Lane's avatar
      Extend the BKI infrastructure to allow system catalogs to be given · 49856352
      Tom Lane authored
      hand-assigned rowtype OIDs, even when they are not "bootstrapped" catalogs
      that have handmade type rows in pg_type.h.  Give pg_database such an OID.
      Restore the availability of C macros for the rowtype OIDs of the bootstrapped
      catalogs.  (These macros are now in the individual catalogs' .h files,
      though, not in pg_type.h.)
      
      This commit doesn't do anything especially useful by itself, but it's
      necessary infrastructure for reverting some ill-considered changes in
      relcache.c.
      49856352
    • Tom Lane's avatar
      Fix RelationCacheInitializePhase2 (Phase3, in HEAD) to cope with the · c2e228d4
      Tom Lane authored
      possibility of shared-inval messages causing a relcache flush while it tries
      to fill in missing data in preloaded relcache entries.  There are actually
      two distinct failure modes here:
      
      1. The flush could delete the next-to-be-processed cache entry, causing
      the subsequent hash_seq_search calls to go off into the weeds.  This is
      the problem reported by Michael Brown, and I believe it also accounts
      for bug #5074.  The simplest fix is to restart the hashtable scan after
      we've read any new data from the catalogs.  It appears that pre-8.4
      branches have not suffered from this failure, because by chance there were
      no other catalogs sharing the same hash chains with the catalogs that
      RelationCacheInitializePhase2 had work to do for.  However that's obviously
      pretty fragile, and it seems possible that derivative versions with
      additional system catalogs might be vulnerable, so I'm back-patching this
      part of the fix anyway.
      
      2. The flush could delete the *current* cache entry, in which case the
      pointer to the newly-loaded data would end up being stored into an
      already-deleted Relation struct.  As long as it was still deleted, the only
      consequence would be some leaked space in CacheMemoryContext.  But it seems
      possible that the Relation struct could already have been recycled, in
      which case this represents a hard-to-reproduce clobber of cached data
      structures, with unforeseeable consequences.  The fix here is to pin the
      entry while we work on it.
      
      In passing, also change RelationCacheInitializePhase2 to Assert that
      formrdesc() set up the relation's cached TupleDesc (rd_att) with the
      correct type OID and hasoids values.  This is more appropriate than
      silently updating the values, because the original tupdesc might already
      have been copied into the catcache.  However this part of the patch is
      not in HEAD because it fails due to some questionable recent changes in
      formrdesc :-(.  That will be cleaned up in a subsequent patch.
      c2e228d4
  13. 25 Sep, 2009 2 commits
  14. 23 Sep, 2009 1 commit
  15. 22 Sep, 2009 2 commits
    • Peter Eisentraut's avatar
      Unicode escapes in E'...' strings · c2bb0378
      Peter Eisentraut authored
      Author: Marko Kreen <markokr@gmail.com>
      c2bb0378
    • Tom Lane's avatar
      Implement the DO statement to support execution of PL code without having · 9048b731
      Tom Lane authored
      to create a function for it.
      
      Procedural languages now have an additional entry point, namely a function
      to execute an inline code block.  This seemed a better design than trying
      to hide the transient-ness of the code from the PL.  As of this patch, only
      plpgsql has an inline handler, but probably people will soon write handlers
      for the other standard PLs.
      
      In passing, remove the long-dead LANCOMPILER option of CREATE LANGUAGE.
      
      Petr Jelinek
      9048b731