1. 23 Sep, 2010 5 commits
  2. 22 Sep, 2010 7 commits
  3. 21 Sep, 2010 9 commits
  4. 20 Sep, 2010 1 commit
  5. 19 Sep, 2010 3 commits
  6. 18 Sep, 2010 2 commits
    • Tom Lane's avatar
      Make sure we wait for protocol-level EOF when ending binary COPY IN. · f906e078
      Tom Lane authored
      The previous coding just terminated the COPY immediately after seeing
      the EOF marker (-1 where a row field count is expected).  The expected
      CopyDone or CopyFail message just got thrown away later, since we weren't
      in COPY mode anymore.  This behavior complicated matters for the JDBC
      driver, and arguably was the wrong thing in any case since a CopyFail
      message after the marker wouldn't be honored.
      
      Note that there is a behavioral change here: extra data after the EOF
      marker was silently ignored before, but now it will cause an error.
      Hence not back-patching, although this is arguably a bug.
      
      Per report and patch by Kris Jurka.
      f906e078
    • Tom Lane's avatar
      Give a suitable HINT when an INSERT's data source is a RowExpr containing · af0161e5
      Tom Lane authored
      the same number of columns expected by the insert.  This suggests that there
      were extra parentheses that converted the intended column list into a row
      expression.
      
      Original patch by Marko Tiikkaja, rather heavily editorialized by me.
      af0161e5
  7. 17 Sep, 2010 3 commits
  8. 16 Sep, 2010 4 commits
    • Magnus Hagander's avatar
      Treat exit code 128 (ERROR_WAIT_NO_CHILDREN) as non-fatal on Win32, · 594419e7
      Magnus Hagander authored
      since it can happen when a process fails to start when the system
      is under high load.
      
      Per several bug reports and many peoples investigation.
      
      Back-patch to 8.4, which is as far back as the "deadman-switch"
      for shared memory access exists.
      594419e7
    • Tom Lane's avatar
      f7270a65
    • Tom Lane's avatar
      Fix bad grammar. · 7acf6f9b
      Tom Lane authored
      7acf6f9b
    • Tom Lane's avatar
      Fix two new-in-9.0 bugs in hstore. · cd55aa2e
      Tom Lane authored
      There was an incorrect Assert in hstoreValidOldFormat(), which would cause
      immediate core dumps when attempting to work with pre-9.0 hstore data,
      but of course only in an assert-enabled build.
      
      Also, ghstore_decompress() incorrectly applied DatumGetHStoreP() to a datum
      that wasn't actually an hstore, but rather a ghstore (ie, a gist signature
      bitstring).  That used to be harmless, but could now result in misbehavior
      if the hstore format conversion code happened to trigger.  In reality,
      since ghstore is not marked toastable (and doesn't need to be), this
      function is useless anyway; we can lobotomize it down to returning the
      passed-in pointer.
      
      Both bugs found by Andrew Gierth, though this isn't exactly his proposed
      patch.
      cd55aa2e
  9. 15 Sep, 2010 5 commits
  10. 14 Sep, 2010 1 commit
    • Tom Lane's avatar
      Fix join-removal logic for pseudoconstant and outerjoin-delayed quals. · 4e97631e
      Tom Lane authored
      In these cases a qual can get marked with the removable rel in its
      required_relids, but this is just to schedule its evaluation correctly, not
      because it really depends on the rel.  We were assuming that, in effect,
      we could throw away *all* quals so marked, which is nonsense.  Tighten up
      the logic to be a little more paranoid about which quals belong to the
      outer join being considered for removal, and arrange for all quals that
      don't belong to be updated so they will still get evaluated correctly.
      
      Also fix another problem that happened to be exposed by this test case,
      which was that make_join_rel() was failing to notice some cases where
      a constant-false qual could be used to prove a join relation empty.  If it's
      a pushed-down constant false, then the relation is empty even if it's an
      outer join, because the qual applies after the outer join expansion.
      
      Per report from Nathan Grange.  Back-patch into 9.0.
      4e97631e