- 26 Jun, 2008 6 commits
-
-
Bruce Momjian authored
postmaster.opts.
-
Bruce Momjian authored
-
Bruce Momjian authored
> > * Improve LDAP authentication configuration options > > http://archives.postgresql.org/pgsql-hackers/2008-04/msg01745.php
-
Bruce Momjian authored
-
Bruce Momjian authored
patterns, for clarity.
-
Bruce Momjian authored
-
- 24 Jun, 2008 3 commits
-
-
Tom Lane authored
to suppress zero-padding of "name" entries in indexes. The alignment change is unlikely to save any space, but it is really needed anyway to make the world safe for our widespread practice of passing plain old C strings to functions that are declared as taking Name. In the previous coding, the C compiler was entitled to assume that a Name pointer was word-aligned; but we were failing to guarantee that. I think the reason we'd not seen failures is that usually the only thing that gets done with such a pointer is strcmp(), which is hard to optimize in a way that exploits word-alignment. Still, some enterprising compiler guy will probably think of a way eventually, or we might change our code in a way that exposes more-obvious optimization opportunities. The padding change is accomplished in one-liner fashion by declaring the "name" index opclasses to use storage type "cstring" in pg_opclass.h. Normally btree and hash don't allow a nondefault storage type, because they don't have any provisions for converting the input datum to another type. However, because name and cstring are effectively the same thing except for padding, no conversion is needed --- we only need index_form_tuple() to treat the datum as being cstring not name, and this is sufficient. This seems to make for about a one-third reduction in the typical sizes of system catalog indexes that involve "name" columns, of which we have many. These two changes are only weakly related, but the alignment change makes me feel safer that the padding change won't introduce problems, so I'm committing them together.
-
Bruce Momjian authored
< o Prevent pg_dump/pg_restore from being affected by > o -Prevent pg_dump/pg_restore from being affected by
-
Tom Lane authored
Per buildfarm results.
-
- 23 Jun, 2008 9 commits
-
-
Bruce Momjian authored
> > o Allow COPY to report errors sooner > > http://archives.postgresql.org/pgsql-hackers/2008-04/msg01169.php
-
Bruce Momjian authored
-
Bruce Momjian authored
Joshua D. Drake
-
Bruce Momjian authored
> * Allow custom variables to appear in pg_settings()
-
Bruce Momjian authored
* Implement a module capability for loading /contrib-style extensions http://archives.postgresql.org/pgsql-patches/2008-04/msg00164.php
-
Bruce Momjian authored
binary values. Add comments to libpq C function for parameter passing.
-
Bruce Momjian authored
* Consider whether duplicate keys should be sorted by block/offset http://archives.postgresql.org/pgsql-hackers/2008-03/msg00558.php Create new "Sorting" TODO section.
-
Bruce Momjian authored
formatting.c to use common code; remove duplicate functions and support routines that are no longer needed.
-
Tom Lane authored
in pg_proc. Also make it not emit duplicate extern declarations, and make it a bit more bulletproof in some other small ways. Likewise fix the equally hard-wired, and utterly undocumented, knowledge in the MSVC build scripts. For testing purposes and perhaps other uses in future, pull out that portion of the MSVC scripts into a standalone perl script equivalent to Gen_fmgrtab.sh, and make it generate actually identical output, rather than just more-or-less-the-same output. Motivated by looking at Pavel's variadic function patch. Whether or not that gets accepted, we can be sure that pg_proc's column set will change again in the future; it's time to not have to deal with this gotcha.
-
- 20 Jun, 2008 1 commit
-
-
Tom Lane authored
read and written without a lock. The value itself is atomic, sure, but on processors with weak memory ordering it's possible for a reader to see the value change before it sees the associated message written into the buffer array. Fix by introducing a spinlock that's used just to read and write maxMsgNum. (We could do this with less overhead if we recognized a concept of "memory access barrier"; is it worth introducing such a thing? At the moment probably not --- I can't measure any clear slowdown from adding the spinlock, so this solution is probably fine.) Per buildfarm results.
-
- 19 Jun, 2008 4 commits
-
-
Tom Lane authored
unnecessary cache resets. The major changes are: * When the queue overflows, we only issue a cache reset to the specific backend or backends that still haven't read the oldest message, rather than resetting everyone as in the original coding. * When we observe backend(s) falling well behind, we signal SIGUSR1 to only one backend, the one that is furthest behind and doesn't already have a signal outstanding for it. When it finishes catching up, it will in turn signal SIGUSR1 to the next-furthest-back guy, if there is one that is far enough behind to justify a signal. The PMSIGNAL_WAKEN_CHILDREN mechanism is removed. * We don't attempt to clean out dead messages after every message-receipt operation; rather, we do it on the insertion side, and only when the queue fullness passes certain thresholds. * Split SInvalLock into SInvalReadLock and SInvalWriteLock so that readers don't block writers nor vice versa (except during the infrequent queue cleanout operations). * Transfer multiple sinval messages for each acquisition of a read or write lock.
-
Tom Lane authored
parsing. Per bug #4253 from Giorgio Valoti.
-
Bruce Momjian authored
o Allow pg_hba.conf to specify host names along with IP addresses > http://archives.postgresql.org/pgsql-hackers/2008-06/msg00569.php
-
Alvaro Herrera authored
corresponding struct definitions. This allows other headers to avoid including certain highly-loaded headers such as rel.h and relscan.h, instead using just relcache.h, heapam.h or genam.h, which are more lightweight and thus cause less unnecessary dependencies.
-
- 18 Jun, 2008 4 commits
-
-
Tom Lane authored
-
Tom Lane authored
by installing an error context subroutine that will provide the file name and line number for all errors detected while reading a config file. Some of the reader routines were already doing that in an ad-hoc way for errors detected directly in the reader, but it didn't help for problems detected in subroutines, such as encoding violations. Back-patch to 8.3 because 8.3 is where people will be trying to debug configuration files.
-
Bruce Momjian authored
use for other modules; also move pnstrdup(). Clean up code slightly.
-
Neil Conway authored
along with an additional typo I noticed along the way.
-
- 17 Jun, 2008 6 commits
-
-
Tom Lane authored
use it to help enforce superuser_reserved_backends, but since 8.1 it's just been dead weight.
-
Tom Lane authored
int2-and-int8 implementations of the basic arithmetic operators +, -, *, /. This doesn't really add any new functionality, but it avoids "operator is not unique" failures that formerly occurred in these cases because the parser couldn't decide whether to promote the int2 to int4 or int8. We could alternatively have removed the existing cross-type operators, but experimentation shows that the cost of an additional type coercion expression node is noticeable compared to such cheap operators; so let's not give up any performance here. On the other hand, I removed the int2-and-int4 modulo (%) operators since they didn't seem as important from a performance standpoint. Per a complaint last January from ykhuang.
-
Bruce Momjian authored
-
Bruce Momjian authored
USE_WIDE_UPPER_LOWER instead.
-
Tom Lane authored
that it depends on for replan-forcing purposes. We need to consider plain OID constants too, because eval_const_expressions folds a RelabelType atop a Const to just a Const. This change could result in OID values that aren't really for tables getting added to the dependency list, but the worst-case consequence would be occasional useless replans. Per report from Gabriele Messineo.
-
Tom Lane authored
1. Directly reading interp->result is deprecated in Tcl 8.0 and later; you're supposed to use Tcl_GetStringResult. This code finally broke with Tcl 8.5, because Tcl_GetVar can now have side-effects on interp->result even though it preserves the logical state of the result. (There's arguably a Tcl issue here, because Tcl_GetVar could invalidate the pointer result of a just-preceding Tcl_GetStringResult, but I doubt the Tcl guys will see it as a bug.) 2. We were being sloppy about the encoding of the result: some places would push database-encoding data into the Tcl result, which should not happen, and we were assuming that any error result coming back from Tcl was in the database encoding, which is not a good assumption. 3. There were a lot of calls of Tcl_SetResult that uselessly specified TCL_VOLATILE for constant strings. This is only a minor performance issue, but I fixed it in passing since I had to look at all the calls anyway. #2 is a live bug regardless of which Tcl version you are interested in, so back-patch even to branches that are unlikely to be used with Tcl 8.5. I went back as far as 8.0, which is as far as the patch applied easily; 7.4 was using a different error processing scheme that has got its own problems :-(
-
- 16 Jun, 2008 1 commit
-
-
Tom Lane authored
late, with lots of redundancy, bad grammar, and just plain poor exposition. Make it clear that autovacuum is now considered the normal solution.
-
- 15 Jun, 2008 5 commits
-
-
Andrew Dunstan authored
-
Andrew Dunstan authored
and add them. Avoids third party files or those that would cause regression failures.
-
Tom Lane authored
is necessary to avoid deadlock against ordinary queries, but we'd broken it with recent changes that made the DROP machinery lock the index before arriving at index_drop. Per intermittent buildfarm failures.
-
Tom Lane authored
-
Tom Lane authored
grammar allows ALTER TABLE/INDEX/SEQUENCE/VIEW interchangeably for all subforms of those commands, and then we sort out what's really legal at execution time. This allows the ALTER SEQUENCE/VIEW reference pages to fully document all the ALTER forms available for sequences and views respectively, and eliminates a longstanding cause of confusion for users. The net effect is that the following forms are allowed that weren't before: ALTER SEQUENCE OWNER TO ALTER VIEW ALTER COLUMN SET/DROP DEFAULT ALTER VIEW OWNER TO ALTER VIEW SET SCHEMA (There's no actual functionality gain here, but formerly you had to say ALTER TABLE instead.) Interestingly, the grammar tables actually get smaller, probably because there are fewer special cases to keep track of. I did not disallow using ALTER TABLE for these operations. Perhaps we should, but there's a backwards-compatibility issue if we do; in fact it would break existing pg_dump scripts. I did however tighten up ALTER SEQUENCE and ALTER VIEW to reject non-sequences and non-views in the new cases as well as a couple of cases where they didn't before. The patch doesn't change pg_dump to use the new syntaxes, either.
-
- 14 Jun, 2008 1 commit
-
-
Alvaro Herrera authored
expand the pattern specifier. Per gripe from Josh Drake.
-