- 08 Mar, 2010 4 commits
-
-
Michael Meskes authored
-
Magnus Hagander authored
the GSSAPI libraries crash. Noted by Zdenek Kotala
-
Magnus Hagander authored
requires a hostname to function. Noted by Zdenek Kotala
-
Tom Lane authored
Bangladesh, Mexico, Paraguay.
-
- 07 Mar, 2010 1 commit
-
-
Magnus Hagander authored
-
- 06 Mar, 2010 3 commits
-
-
Tom Lane authored
when warning about column-level privileges. This is more useful than before and makes the apparent duplication complained of by Piyush Newe not so duplicate. Also fix lack of quote marks in a related message text. Back-patch to 8.4, where column-level privileges were introduced. Stephen Frost
-
Magnus Hagander authored
file instead of ~/.psqlrc on startup.
-
Tom Lane authored
unless (1) the @ isn't quoted and (2) the filename isn't empty. This guards against unexpectedly treating usernames or other strings in "flat files" as inclusion requests, as seen in a recent trouble report from Ed L. The empty-filename case would be guaranteed to misbehave anyway, because our subsequent path-munging behavior results in trying to read the directory containing the current input file. I think this might finally explain the report at http://archives.postgresql.org/pgsql-bugs/2004-05/msg00132.php of a crash after printing "authentication file token too long, skipping", since I was able to duplicate that message (though not a crash) on a platform where stdio doesn't refuse to read directories. We never got far in investigating that problem, but now I'm suspicious that the trigger condition was an @ in the flat password file. Back-patch to all active branches since the problem can be demonstrated in all branches except HEAD. The test case, creating a user named "@", doesn't cause a problem in HEAD since we got rid of the flat password file. Nonetheless it seems like a good idea to not consider quoted @ as a file inclusion spec, so I changed HEAD too.
-
- 05 Mar, 2010 1 commit
-
-
Michael Meskes authored
error sqlstate. This change makes it return a correct value..
-
- 04 Mar, 2010 1 commit
-
-
Heikki Linnakangas authored
with binary compatibility. Backpatch to 8.4 where INOUT casts were introduced.
-
- 03 Mar, 2010 10 commits
-
-
Bruce Momjian authored
-
Bruce Momjian authored
about the behavior. Document that quotes in to_date, to_timestamp, to_number skip input characters.
-
Tom Lane authored
set ferror() but never set feof(). This is known to be the case for recent glibc when trying to read a directory as a file, and might be true for other platforms/cases too. Per report from Ed L. (There is more that we ought to do about his report, but this is one easily identifiable issue.)
-
Heikki Linnakangas authored
privileges of foreign servers is "GRANT ... ON *FOREIGN* SERVER ...".
-
Tom Lane authored
in versions >= 8.3). The core code is more robust and efficient than what was there before, and this also reduces risks involved in swapping different libxml error handler settings. Before 8.3, there is still some risk of problems if add-on modules such as Perl invoke libxml without setting their own error handler. Given the lack of reports I'm not sure there's a risk in practice, so I didn't take the step of actually duplicating the core code into older contrib/xml2 branches. Instead I just tweaked the existing code to ensure it didn't leave a dangling pointer to short-lived memory when throwing an error.
-
Tom Lane authored
too, instead of duplicating the functionality (badly). I renamed xml_init to pg_xml_init, because the former seemed just a bit too generic to be safe as a global symbol. I considered likewise renaming xml_ereport to pg_xml_ereport, but felt that the reference to ereport probably made it sufficiently PG-centric already.
-
Andrew Dunstan authored
-
Bruce Momjian authored
-
Bruce Momjian authored
into proper sections, per suggestion from Tom.
-
Tom Lane authored
section, throw an error message saying explicitly that the label must go before DECLARE. Per investigation of a recent pgsql-novice question, this code did not work as intended in any modern PG version, maybe not ever. Allowing such a thing would only create ambiguity anyway, so it seems better to remove it than fix it.
-
- 02 Mar, 2010 7 commits
-
-
Bruce Momjian authored
two adjacent long-running queries have much less than max_standby_delay before query cancel is possible.
-
Andrew Dunstan authored
-
Bruce Momjian authored
from master to slave, and discourage its use during slave/master keep-xid-alive connections.
-
Peter Eisentraut authored
-
Andrew Dunstan authored
-
Tom Lane authored
Per bug #5352, this helps to provide a useful error message if the user tries to do something presently unsupported, namely use a rowtype variable as a member of a multiple-item INTO list.
-
Andrew Dunstan authored
-
- 01 Mar, 2010 7 commits
-
-
Heikki Linnakangas authored
but not in cells).
-
Heikki Linnakangas authored
formats; a null string must not be formatted as a numeric. The more exotic formats latex and troff also incorrectly formatted all strings as numerics when numericlocale was on. Backpatch to 8.1 where numericlocale option was added. This fixes bug #5355 reported by Andy Lester.
-
Tom Lane authored
This involves modifying the module to have a stable ABI, that is, the xslt_process() function still exists even without libxslt. It throws a runtime error if called, but doesn't prevent executing the CREATE FUNCTION call. This is a good thing anyway to simplify cross-version upgrades.
-
Magnus Hagander authored
since we released a version without it, so remove the comment that says we might want to do that.
-
Tom Lane authored
-
Tom Lane authored
These are unnecessary and probably dangerous. I don't see any immediate risk situations in the core XML support or contrib/xml2 itself, but there could be issues with external uses of libxml2, and in any case it's an accident waiting to happen.
-
Greg Stark authored
-
- 28 Feb, 2010 5 commits
-
-
Tom Lane authored
Get rid of the code that attempted to funnel libxml2's memory allocations into palloc. We already knew from experience with the core xml datatype that trying to do this is simply not reliable. Unlike the core code, I did not bother adding a lot of PG_TRY/PG_CATCH logic to try to ensure that everything is cleaned up on error exit. Hence, we might leak some memory if one of these functions fails partway through. Given the deprecated status of this contrib module and the fact that errors partway through the functions shouldn't be too common, it doesn't seem worth worrying about. Also fix a separate bug in xpath_table, that it did the wrong things if given a result tuple descriptor with less than 2 columns. While such a case isn't very useful in practice, we shouldn't fail or stomp memory when it occurs. Add some simple regression tests based on all the reported crash cases that I have on hand. This should be back-patched, but let's see if the buildfarm likes it first.
-
Greg Stark authored
Second try at fsyncing directories in CREATE DATABASE. Let's see what the build farm says of opening directories read-only and ignoring EBADF from fsync of directories
-
Tom Lane authored
just make it a bit less ugly in places.
-
Bruce Momjian authored
-
Bruce Momjian authored
-
- 27 Feb, 2010 1 commit
-
-
Michael Meskes authored
-