- 24 Sep, 2008 1 commit
-
-
Magnus Hagander authored
with situtations when the file contains an EOF maker (0x1A) on Windows. ITAGAKI Takahiro
-
- 23 Sep, 2008 5 commits
-
-
Magnus Hagander authored
security level with other parts of the system. Per gripe from Tom
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Heikki Linnakangas authored
matches the encoding of the locale. LC_COLLATE is now checked in addition to LC_CTYPE.
-
Heikki Linnakangas authored
ctype are now more like encoding, stored in new datcollate and datctype columns in pg_database. This is a stripped-down version of Radek Strnad's patch, with further changes by me.
-
- 22 Sep, 2008 2 commits
-
-
Tom Lane authored
that presence of the password in the conninfo string must be checked *before* risking a connection attempt, there is no point in checking it afterwards. This makes the specification of PQconnectionUsedPassword() a bit simpler and perhaps more generally useful, too.
-
Tom Lane authored
conninfo string *before* trying to connect to the remote server, not after. As pointed out by Marko Kreen, in certain not-very-plausible situations this could result in sending a password from the postgres user's .pgpass file, or other places that non-superusers shouldn't have access to, to an untrustworthy remote server. The cleanest fix seems to be to expose libpq's conninfo-string-parsing code so that dblink can check for a password option without duplicating the parsing logic. Joe Conway, with a little cleanup by Tom Lane
-
- 21 Sep, 2008 1 commit
-
-
Tom Lane authored
instead of listing all the columns returned by the underlying function. initdb not forced since this patch doesn't actually change anything about the stored form of the views. It just means there's one less place to change if someone wants to add columns to them.
-
- 19 Sep, 2008 6 commits
-
-
Tom Lane authored
sequence of operations that libpq goes through while creating a PGresult. Also, remove ill-considered "const" decoration on parameters passed to event procedures.
-
Tom Lane authored
Jan Urbanski
-
Tom Lane authored
guarantees about whether event procedures will receive DESTROY events. They no longer need to defend themselves against getting a DESTROY without a successful prior CREATE. Andrew Chernow
-
Magnus Hagander authored
can be used from Slony functions. Per report from Hiroshi Saito.
-
Peter Eisentraut authored
bison output. Without these, make can sometimes be tempted to invoke its built-in rules using lex and yacc, which can fail if those commands are not available. This was a main cause for the NLS web site breakage.
-
Alvaro Herrera authored
there are FD_XACT_TEMPORARY files to clean up at transaction end. Per performance profiling results on AWeber's huge systems. Patch by me after an idea suggested by Simon Riggs.
-
- 17 Sep, 2008 4 commits
-
-
Tom Lane authored
-
Tom Lane authored
Argentina, Bahamas, Brazil, Mauritius, Morocco, Pakistan, Palestine, Paraguay).
-
Tom Lane authored
occurred to temporary files. This replaces the unused NDirectFileRead/NDirectFileWrite counters. Itagaki Takahiro
-
Tom Lane authored
enable them to manage private data associated with PGconns and PGresults. Andrew Chernow and Merlin Moncure
-
- 16 Sep, 2008 3 commits
-
-
Tom Lane authored
interpreted as expected (the sign should affect months too), and get rid of hard-wired assumption that unmarked signed values must be hours (if integers) or seconds (if floats). The former was just a bug in my previous patch, while the latter may have made sense at one time but seems illogical now that we support determination of the units from typmod information. Ron Mayer and myself.
-
Tom Lane authored
forestalls potential overflow when the same table (or other object, but usually tables) is accessed by very many successive queries within a single transaction. Per report from Michael Milligan. Back-patch to 8.0, which is as far back as the patch conveniently applies. There have been no reports of overflow in pre-8.3 releases, but clearly the risk existed all along. (Michael's report suggests that 8.3 may consume lock counts faster than prior releases, but with no test case to look at it's hard to be sure about that. Widening the counts seems a good future-proofing measure in any event.)
-
Tom Lane authored
-
- 15 Sep, 2008 8 commits
-
-
Tom Lane authored
we regenerate the SQL query text not merely the plan derived from it. This is needed to handle contingencies such as renaming of a table or column used in an FK. Pre-8.3, such cases worked despite the lack of replanning (because the cached plan needn't actually change), so this is a regression. Per bug #4417 from Benjamin Bihler.
-
Magnus Hagander authored
to indicate where the error occurred.
-
Tom Lane authored
value. This means that hash index lookups are always lossy and have to be rechecked when the heap is visited; however, the gain in index compactness outweighs this when the indexed values are wide. Also, we only need to perform datatype comparisons when the hash codes match exactly, rather than for every entry in the hash bucket; so it could also win for datatypes that have expensive comparison functions. A small additional win is gained by keeping hash index pages sorted by hash code and using binary search to reduce the number of index tuples we have to look at. Xiao Meng This commit also incorporates Zdenek Kotala's patch to isolate hash metapages and hash bitmaps a bit better from the page header datastructures.
-
Magnus Hagander authored
-
Magnus Hagander authored
each connection. This makes it possible to catch errors in the pg_hba file when it's being reloaded, instead of silently reloading a broken file and failing only when a user tries to connect. This patch also makes the "sameuser" argument to ident authentication optional.
-
Peter Eisentraut authored
-
Magnus Hagander authored
-
Magnus Hagander authored
-
- 12 Sep, 2008 3 commits
-
-
Tom Lane authored
per David Wheeler.
-
Tom Lane authored
btree. We can't easily tell whether clauses generated from the equivalence class could be used with such an index, so just assume that they might be. This bit of over-optimization prevented use of non-btree indexes for nestloop inner indexscans, in any case where the join uses an equality operator that is also a btree operator --- which in particular is typically true for hash indexes. Noted while trying to test the current hash index patch.
-
Peter Eisentraut authored
-
- 11 Sep, 2008 4 commits
-
-
Tom Lane authored
instead of by number of transactions to run. Takahiro Itagaki
-
Tom Lane authored
erroneous input, rather than silently producing bizarre results as formerly happened. Brendan Jurd
-
Tom Lane authored
and the literal syntax INTERVAL 'string' ... SECOND(n), as required by the SQL standard. Our old syntax put (n) directly after INTERVAL, which was a mistake, but will still be accepted for backward compatibility as well as symmetry with the TIMESTAMP cases. Change intervaltypmodout to show it in the spec's way, too. (This could potentially affect clients, if there are any that analyze the typmod of an INTERVAL in any detail.) Also fix interval input to handle 'min:sec.frac' properly; I had overlooked this case in my previous patch. Document the use of the interval fields qualifier, which up to now we had never mentioned in the docs. (I think the omission was intentional because it didn't work per spec; but it does now, or at least close enough to be credible.)
-
Alvaro Herrera authored
GetOldestXmin() instead of RecentGlobalXmin; this is safer because we do not depend on the latter being correctly set elsewhere, and while it is more expensive, this code path is not performance-critical. This is a real risk for autovacuum, because it can execute whole cycles without doing a single vacuum, which would mean that RecentGlobalXmin would stay at its initialization value, FirstNormalTransactionId, causing a bogus value to be inserted in pg_database. This bug could explain some recent reports of failure to truncate pg_clog. At the same time, change the initialization of RecentGlobalXmin to InvalidTransactionId, and ensure that it's set to something else whenever it's going to be used. Using it as FirstNormalTransactionId in HOT page pruning could incur in data loss. InitPostgres takes care of setting it to a valid value, but the extra checks are there to prevent "special" backends from behaving in unusual ways. Per Tom Lane's detailed problem dissection in 29544.1221061979@sss.pgh.pa.us
-
- 10 Sep, 2008 3 commits
-
-
Tom Lane authored
isn't left corrupt if guc_strdup should fail.
-
Tom Lane authored
a lot closer than it was before). To do this, tweak coerce_type() to pass through the typmod information when invoking interval_in() on an UNKNOWN constant; then fix DecodeInterval to pay attention to the typmod when deciding how to interpret a units-less integer value. I changed one or two other details as well. I believe the code now reacts as expected by spec for all the literal syntaxes that are specifically enumerated in the spec. There are corner cases involving strings that don't exactly match the set of fields called out by the typmod, for which we might want to tweak the behavior some more; but I think this is an area of user friendliness rather than spec compliance. There remain some non-compliant details about the SQL syntax (as opposed to what's inside the literal string); but at least we'll throw error rather than silently doing the wrong thing in those cases.
-
Alvaro Herrera authored
initdb forced due to changes in the pg_settings view. Magnus Hagander and Alvaro Herrera.
-