1. 13 Oct, 2013 2 commits
  2. 11 Oct, 2013 8 commits
    • Kevin Grittner's avatar
      Fix several possibly non-portable gaffs in record_image_ops. · 4cbb6463
      Kevin Grittner authored
      Sparc machines in the buildfarm were made happy by the previous
      fix, but PowerPC machines still are still failing.  Hopefully this
      will cure that.
      4cbb6463
    • Alvaro Herrera's avatar
      Use $(PERL) to invoke duplicate_oids · ada01014
      Alvaro Herrera authored
      Per buildfarm failure reported by smilodon
      ada01014
    • Alvaro Herrera's avatar
      Rework SSL renegotiation code · 31cf1a1a
      Alvaro Herrera authored
      The existing renegotiation code was home for several bugs: it might
      erroneously report that renegotiation had failed; it might try to
      execute another renegotiation while the previous one was pending; it
      failed to terminate the connection if the renegotiation never actually
      took place; if a renegotiation was started, the byte count was reset,
      even if the renegotiation wasn't completed (this isn't good from a
      security perspective because it means continuing to use a session that
      should be considered compromised due to volume of data transferred.)
      
      The new code is structured to avoid these pitfalls: renegotiation is
      started a little earlier than the limit has expired; the handshake
      sequence is retried until it has actually returned successfully, and no
      more than that, but if it fails too many times, the connection is
      closed.  The byte count is reset only when the renegotiation has
      succeeded, and if the renegotiation byte count limit expires, the
      connection is terminated.
      
      This commit only touches the master branch, because some of the changes
      are controversial.  If everything goes well, a back-patch might be
      considered.
      
      Per discussion started by message
      20130710212017.GB4941@eldon.alvh.no-ip.org
      31cf1a1a
    • Peter Eisentraut's avatar
      doc: Move check-tabs target into html target · 956f2db4
      Peter Eisentraut authored
      The previous plan of having the check-tabs target a prerequisite of
      "all" and "distprep" caused make distcheck to fail because make -q
      distprep would never be satisfied.  Put check-tabs into the html target
      instead, so it is only called when a build actually happens.
      956f2db4
    • Peter Eisentraut's avatar
      8238d1ed
    • Peter Eisentraut's avatar
    • Peter Eisentraut's avatar
      Remove maintainer-check target, fold into normal build · 5dd41f35
      Peter Eisentraut authored
      make maintainer-check was obscure and rarely called in practice, and
      many breakages were missed.  Fold everything that make maintainer-check
      used to do into the normal build.  Specifically:
      
      - Call duplicate_oids when genbki.pl is called.
      
      - Check for tabs in SGML files when the documentation is built.
      
      - Run msgfmt with the -c option during the regular build.  Add an
        additional configure check to see whether we are using the GNU
        version.  (make maintainer-check probably used to fail with non-GNU
        msgfmt.)
      
      Keep maintainer-check as around as phony target for the time being in
      case anyone is calling it.  But it won't do anything anymore.
      5dd41f35
    • Peter Eisentraut's avatar
      Replace duplicate_oids with Perl implementation · 3dc543b3
      Peter Eisentraut authored
      It is more portable, more robust, and more readable.
      
      From: Andrew Dunstan <andrew@dunslane.net>
      3dc543b3
  3. 10 Oct, 2013 8 commits
  4. 09 Oct, 2013 6 commits
  5. 08 Oct, 2013 10 commits
  6. 07 Oct, 2013 6 commits
    • Heikki Linnakangas's avatar
      TYPEALIGN doesn't work on int64 on 32-bit platforms. · 5962519b
      Heikki Linnakangas authored
      The TYPEALIGN macro, and the related ones like MAXALIGN, don't work with
      values larger than intptr_t, because TYPEALIGN casts the argument to
      intptr_t to do the arithmetic. That's not a problem when dealing with
      pointers or lengths or offsets related to pointers, but the XLogInsert
      scaling patch added a call to MAXALIGN with an XLogRecPtr argument.
      
      To fix, add wider variants of the macros, called TYPEALIGN64 and MAXALIGN64,
      which are just like the existing variants but work with uint64 instead of
      intptr_t.
      
      Report and patch by David Rowley, analysis by Andres Freund.
      5962519b
    • Heikki Linnakangas's avatar
      Fix bugs in SSI tuple locking. · 81fbbfe3
      Heikki Linnakangas authored
      1. In heap_hot_search_buffer(), the PredicateLockTuple() call is passed
      wrong offset number. heapTuple->t_self is set to the tid of the first
      tuple in the chain that's visited, not the one actually being read.
      
      2. CheckForSerializableConflictIn() uses the tuple's t_ctid field
      instead of t_self to check for exiting predicate locks on the tuple. If
      the tuple was updated, but the updater rolled back, t_ctid points to the
      aborted dead tuple.
      
      Reported by Hannu Krosing. Backpatch to 9.1.
      81fbbfe3
    • Peter Eisentraut's avatar
      Translation updates · 0b109c82
      Peter Eisentraut authored
      0b109c82
    • Robert Haas's avatar
      Make DISCARD SEQUENCES also discard the last used sequence. · 16a906f5
      Robert Haas authored
      Otherwise, we access already-freed memory.  Oops.
      
      Report by Michael Paquier.  Fix by me.
      16a906f5
    • Robert Haas's avatar
      plpgsql: Add new option print_strict_params. · 689746c0
      Robert Haas authored
      This option provides more detailed error messages when STRICT is used
      and the number of rows returned is not one.
      
      Marko Tiikkaja, reviewed by Ian Lawrence Barwick
      689746c0
    • Kevin Grittner's avatar
      Eliminate xmin from hash tag for predicate locks on heap tuples. · c01262a8
      Kevin Grittner authored
      If a tuple was frozen while its predicate locks mattered,
      read-write dependencies could be missed, resulting in failure to
      detect conflicts which could lead to anomalies in committed
      serializable transactions.
      
      This field was added to the tag when we still thought that it was
      necessary to carry locks forward to a new version of an updated
      row.  That was later proven to be unnecessary, which allowed
      simplification of the code, but elimination of xmin from the tag
      was missed at the time.
      
      Per report and analysis by Heikki Linnakangas.
      Backpatch to 9.1.
      c01262a8