1. 04 Dec, 2010 1 commit
    • Tom Lane's avatar
      KNNGIST, otherwise known as order-by-operator support for GIST. · 55450687
      Tom Lane authored
      This commit represents a rather heavily editorialized version of
      Teodor's builtin_knngist_itself-0.8.2 and builtin_knngist_proc-0.8.1
      patches.  I redid the opclass API to add a separate Distance method
      instead of turning the Consistent method into an illogical mess,
      fixed some bit-rot in the rbtree interfaces, and generally worked over
      the code style and comments.
      
      There's still no non-code documentation to speak of, but I'll work on
      that separately.  Some contrib-module changes are also yet to come
      (right now, point <-> point is the only KNN-ified operator).
      
      Teodor Sigaev and Tom Lane
      55450687
  2. 03 Dec, 2010 6 commits
  3. 02 Dec, 2010 5 commits
  4. 01 Dec, 2010 1 commit
    • Tom Lane's avatar
      Prevent inlining a SQL function with multiple OUT parameters. · 225f0aa3
      Tom Lane authored
      There were corner cases in which the planner would attempt to inline such
      a function, which would result in a failure at runtime due to loss of
      information about exactly what the result record type is.  Fix by disabling
      inlining when the function's recorded result type is RECORD.  There might
      be some sub-cases where inlining could still be allowed, but this is a
      simple and backpatchable fix, so leave refinements for another day.
      Per bug #5777 from Nate Carson.
      
      Back-patch to all supported branches.  8.1 happens to avoid a core-dump
      here, but it still does the wrong thing.
      225f0aa3
  5. 29 Nov, 2010 4 commits
    • Tom Lane's avatar
      Simplify and speed up mapping of index opfamilies to pathkeys. · c0b5fac7
      Tom Lane authored
      Formerly we looked up the operators associated with each index (caching
      them in relcache) and then the planner looked up the btree opfamily
      containing such operators in order to build the btree-centric pathkey
      representation that describes the index's sort order.  This is quite
      pointless for btree indexes: we might as well just use the index's opfamily
      information directly.  That saves syscache lookup cycles during planning,
      and furthermore allows us to eliminate the relcache's caching of operators
      altogether, which may help in reducing backend startup time.
      
      I added code to plancat.c to perform the same type of double lookup
      on-the-fly if it's ever faced with a non-btree amcanorder index AM.
      If such a thing actually becomes interesting for production, we should
      replace that logic with some more-direct method for identifying the
      corresponding btree opfamily; but it's not worth spending effort on now.
      
      There is considerably more to do pursuant to my recent proposal to get rid
      of sort-operator-based representations of sort orderings, but this patch
      grabs some of the low-hanging fruit.  I'll look at the remainder of that
      work after the current commitfest.
      c0b5fac7
    • Heikki Linnakangas's avatar
      3c42efce
    • Robert Haas's avatar
      Fix typo. · fab7fdb9
      Robert Haas authored
      Fujii Masao
      fab7fdb9
    • Simon Riggs's avatar
      Move call to GetTopTransactionId() earlier in LockAcquire(), · ed78384a
      Simon Riggs authored
      removing an infrequently occurring race condition in Hot Standby.
      An xid must be assigned before a lock appears in shared memory,
      rather than immediately after, else GetRunningTransactionLocks()
      may see InvalidTransactionId, causing assertion failures during
      lock processing on standby.
      
      Bug report and diagnosis by Fujii Masao, fix by me.
      ed78384a
  6. 27 Nov, 2010 7 commits
  7. 26 Nov, 2010 11 commits
  8. 25 Nov, 2010 5 commits