1. 28 Oct, 2011 9 commits
  2. 27 Oct, 2011 3 commits
    • Heikki Linnakangas's avatar
      Fix the number of lwlocks needed by the "fast path" lock patch. It needs · cbf65509
      Heikki Linnakangas authored
      one lock per backend or auxiliary process - the need for a lock for each
      aux processes was not accounted for in NumLWLocks(). No-one noticed,
      because the three locks needed for the three aux processes fit into the
      few extra lwlocks we allocate for 3rd party modules that don't call
      RequestAddinLWLocks() (NUM_USER_DEFINED_LWLOCKS, 4 by default).
      cbf65509
    • Tom Lane's avatar
      Avoid recursion while processing ELSIF lists in plpgsql. · 051d1ba7
      Tom Lane authored
      The original implementation of ELSIF in plpgsql converted the construct
      into nested simple IF statements.  This was prone to stack overflow with
      long ELSIF lists, in two different ways.  First, it's difficult to generate
      the parsetree without using right-recursion in the bison grammar, and
      that's prone to parser stack overflow since nothing can be reduced until
      the whole list has been read.  Second, we'd recurse during execution, thus
      creating an unnecessary risk of execution-time stack overflow.  Rewrite
      so that the ELSIF list is represented as a flat list, scanned via iteration
      not recursion, and generated through left-recursion in the grammar.
      Per a gripe from Håvard Kongsgård.
      051d1ba7
    • Tom Lane's avatar
      Add simple script to check for right recursion in Bison grammars. · 756a4ed5
      Tom Lane authored
      We should generally use left-recursion not right-recursion to parse lists.
      Bison hasn't got any built-in way to check for this type of inefficiency,
      and I didn't find anything on the net in a quick search, so I wrote a
      little Perl script to do it.  Add to src/tools/ so we don't have to
      re-invent this wheel next time we wonder if we're doing anything stupid.
      
      Currently, the only place that seems to need fixing is plpgsql's stmt_else
      production, so the problem doesn't appear to be common enough to warrant
      trying to include such a test in our standard build process.  If we did
      want to do that, we'd need a way to ignore some false positives, such as
      a_expr := '-' a_expr
      756a4ed5
  3. 26 Oct, 2011 7 commits
    • Tom Lane's avatar
      Typo fixes. · bf820136
      Tom Lane authored
      expect -> except, noted by Andrew Dunstan.  Also, "cannot" seems more
      readable here than "can not", per David Wheeler.
      bf820136
    • Tom Lane's avatar
      Improve planner's ability to recognize cases where an IN's RHS is unique. · 3e4b3465
      Tom Lane authored
      If the right-hand side of a semijoin is unique, then we can treat it like a
      normal join (or another way to say that is: we don't need to explicitly
      unique-ify the data before doing it as a normal join).  We were recognizing
      such cases when the RHS was a sub-query with appropriate DISTINCT or GROUP
      BY decoration, but there's another way: if the RHS is a plain relation with
      unique indexes, we can check if any of the indexes prove the output is
      unique.  Most of the infrastructure for that was there already in the join
      removal code, though I had to rearrange it a bit.  Per reflection about a
      recent example in pgsql-performance.
      3e4b3465
    • Bruce Momjian's avatar
      Fix pg_bsd_indent bug where newlines were not being trimmed from typedef · 360429e1
      Bruce Momjian authored
      lines.  Update pg_bsd_indent required version to 1.1 (and update ftp
      site).
      
      Problem reported by Magnus.
      360429e1
    • Magnus Hagander's avatar
      Implement streaming xlog for backup tools · d9bae531
      Magnus Hagander authored
      Add option for parallel streaming of the transaction log while a
      base backup is running, to get the logfiles before the server has
      removed them.
      
      Also add a tool called pg_receivexlog, which streams the transaction
      log into files, creating a log archive without having to wait for
      segments to complete, thus decreasing the window of data loss without
      having to waste space using archive_timeout. This works best in
      combination with archive_command - suggested usage docs etc coming later.
      d9bae531
    • Magnus Hagander's avatar
      MingW doesn't support wcstombs_s()... · 2b64f3f1
      Magnus Hagander authored
      2b64f3f1
    • Tom Lane's avatar
      Change FK trigger naming convention to fix self-referential FKs. · 1e3b21dd
      Tom Lane authored
      Use names like "RI_ConstraintTrigger_a_NNNN" for FK action triggers and
      "RI_ConstraintTrigger_c_NNNN" for FK check triggers.  This ensures the
      action trigger fires first in self-referential cases where the very same
      row update fires both an action and a check trigger.  This change provides
      a non-probabilistic solution for bug #6268, at the risk that it could break
      client code that is making assumptions about the exact names assigned to
      auto-generated FK triggers.  Hence, change this in HEAD only.  No need for
      forced initdb since old triggers continue to work fine.
      1e3b21dd
    • Tom Lane's avatar
      Change FK trigger creation order to better support self-referential FKs. · 58958726
      Tom Lane authored
      When a foreign-key constraint references another column of the same table,
      row updates will queue both the PK's ON UPDATE action and the FK's CHECK
      action in the same event.  The ON UPDATE action must execute first, else
      the CHECK will check a non-final state of the row and possibly throw an
      inappropriate error, as seen in bug #6268 from Roman Lytovchenko.
      
      Now, the firing order of multiple triggers for the same event is determined
      by the sort order of their pg_trigger.tgnames, and the auto-generated names
      we use for FK triggers are "RI_ConstraintTrigger_NNNN" where NNNN is the
      trigger OID.  So most of the time the firing order is the same as creation
      order, and so rearranging the creation order fixes it.
      
      This patch will fail to fix the problem if the OID counter wraps around or
      adds a decimal digit (eg, from 99999 to 100000) while we are creating the
      triggers for an FK constraint.  Given the small odds of that, and the low
      usage of self-referential FKs, we'll live with that solution in the back
      branches.  A better fix is to change the auto-generated names for FK
      triggers, but it seems unwise to do that in stable branches because there
      may be client code that depends on the naming convention.  We'll fix it
      that way in HEAD in a separate patch.
      
      Back-patch to all supported branches, since this bug has existed for a long
      time.
      58958726
  4. 25 Oct, 2011 5 commits
  5. 24 Oct, 2011 1 commit
  6. 23 Oct, 2011 3 commits
    • Tom Lane's avatar
      Make psql support tab completion of EXECUTE <prepared-statement-name>. · 8140c1bc
      Tom Lane authored
      Andreas Karlsson, reviewed by Josh Kupershmidt
      8140c1bc
    • Tom Lane's avatar
      Improve git_changelog's handling of inconsistent commit orderings. · 7299778a
      Tom Lane authored
      Use the CommitDate not the AuthorDate, as the former is representative of
      the order in which things went into the main repository, and the latter
      isn't very; we now have instances where the AuthorDate is as much as a
      month before the patch really went in.  Also, get rid of the "commit order
      inversions" heuristic, which turns out not to do anything very desirable.
      Instead we just print commits in strict timestamp order, interpreting the
      "timestamp" of a merged commit as its timestamp on the newest branch it
      appears in.  This fixes some cases where very ancient commits were being
      printed relatively early in the report.
      7299778a
    • Tom Lane's avatar
      Don't trust deferred-unique indexes for join removal. · 0f39d505
      Tom Lane authored
      The uniqueness condition might fail to hold intra-transaction, and assuming
      it does can give incorrect query results.  Per report from Marti Raudsepp,
      though this is not his proposed patch.
      
      Back-patch to 9.0, where both these features were introduced.  In the
      released branches, add the new IndexOptInfo field to the end of the struct,
      to try to minimize ABI breakage for third-party code that may be examining
      that struct.
      0f39d505
  7. 22 Oct, 2011 2 commits
    • Tom Lane's avatar
      Support synchronization of snapshots through an export/import procedure. · bb446b68
      Tom Lane authored
      A transaction can export a snapshot with pg_export_snapshot(), and then
      others can import it with SET TRANSACTION SNAPSHOT.  The data does not
      leave the server so there are not security issues.  A snapshot can only
      be imported while the exporting transaction is still running, and there
      are some other restrictions.
      
      I'm not totally convinced that we've covered all the bases for SSI (true
      serializable) mode, but it works fine for lesser isolation modes.
      
      Joachim Wieland, reviewed by Marko Tiikkaja, and rather heavily modified
      by Tom Lane
      bb446b68
    • Heikki Linnakangas's avatar
      Fix overly-complicated usage of errcode_for_file_access(). · b436c72f
      Heikki Linnakangas authored
      No need to do  "errcode(errcode_for_file_access())", just
      "errcode_for_file_access()" is enough. The extra errcode() call is useless
      but harmless, so there's no user-visible bug here. Nevertheless, backpatch
      to 9.1 where this code were added.
      b436c72f
  8. 21 Oct, 2011 4 commits
    • Tom Lane's avatar
      Code review for pgstat_get_crashed_backend_activity patch. · f9c92a5a
      Tom Lane authored
      Avoid possibly dumping core when pgstat_track_activity_query_size has a
      less-than-default value; avoid uselessly searching for the query string
      of a successfully-exited backend; don't bother putting out an ERRDETAIL if
      we don't have a query to show; some other minor stylistic improvements.
      f9c92a5a
    • Tom Lane's avatar
      More cleanup after failed reduced-lock-levels-for-DDL feature. · 5ac59807
      Tom Lane authored
      Turns out that use of ShareUpdateExclusiveLock or ShareRowExclusiveLock
      to protect DDL changes had gotten copied into several places that were
      not touched by either of Simon's original patches for the feature, and
      thus neither he nor I thought to revert them.  (Indeed, it appears that
      two of these uses were committed *after* the reversion, which just goes
      to show that git merging is no panacea.)  Change these places to use
      AccessExclusiveLock again.  If we ever manage to resurrect that feature,
      we're going to have to think a bit harder about how to keep lock level
      usage in sync for DDL operations that aren't within the AlterTable
      infrastructure.
      
      Two of these bugs are only in HEAD, but one is in the 9.1 branch too.
      Alvaro found one of them, I found the other two.
      5ac59807
    • Robert Haas's avatar
      Try to log current the query string when a backend crashes. · c8e8b5a6
      Robert Haas authored
      To avoid minimize risk inside the postmaster, we subject this feature
      to a number of significant limitations.  We very much wish to avoid
      doing any complex processing inside the postmaster, due to the
      posssibility that the crashed backend has completely corrupted shared
      memory.  To that end, no encoding conversion is done; instead, we just
      replace anything that doesn't look like an ASCII character with a
      question mark.  We limit the amount of data copied to 1024 characters,
      and carefully sanity check the source of that data.  While these
      restrictions would doubtless be unacceptable in a general-purpose
      logging facility, even this limited facility seems like an improvement
      over the status quo ante.
      
      Marti Raudsepp, reviewed by PDXPUG and myself
      c8e8b5a6
    • Robert Haas's avatar
      Fix DROP OPERATOR FAMILY IF EXISTS. · 98026192
      Robert Haas authored
      Essentially, the "IF EXISTS" portion was being ignored, and an error
      thrown anyway if the opfamily did not exist.
      
      I broke this in commit fd1843ff; so
      backpatch to 9.1.X.
      
      Report and diagnosis by KaiGai Kohei.
      98026192
  9. 20 Oct, 2011 6 commits
    • Tom Lane's avatar
      Simplify and improve ProcessStandbyHSFeedbackMessage logic. · b4a0223d
      Tom Lane authored
      There's no need to clamp the standby's xmin to be greater than
      GetOldestXmin's result; if there were any such need this logic would be
      hopelessly inadequate anyway, because it fails to account for
      within-database versus cluster-wide values of GetOldestXmin.  So get rid of
      that, and just rely on sanity-checking that the xmin is not wrapped around
      relative to the nextXid counter.  Also, don't reset the walsender's xmin if
      the current feedback xmin is indeed out of range; that just creates more
      problems than we already had.  Lastly, don't bother to take the
      ProcArrayLock; there's no need to do that to set xmin.
      
      Also improve the comments about this in GetOldestXmin itself.
      b4a0223d
    • Tom Lane's avatar
      Rewrite tab completion's previous-word fetching for more sanity. · dce92c6d
      Tom Lane authored
      Make it return empty strings when there are no more words to the left of
      the current position, instead of sometimes returning NULL and other times
      returning copies of the leftmost word.  Also, fetch the words in one scan,
      rather than the previous wasteful approach of starting from scratch for
      each word.  Make the code a bit harder to break when someone decides we
      need more words of context, too.  (There was actually a memory leak here,
      because whoever added prev6_wd neglected to free it.)
      dce92c6d
    • Robert Haas's avatar
      Fix get_object_namespace() not to think extensions are "in" a schema. · 8f3362d4
      Robert Haas authored
      extnamespace means something altogether different in this context.
      Mostly by accident, this coding error (introduced in my commit
      82a4a777) broke the buildfarm instead
      of just silently doing the wrong thing.
      8f3362d4
    • Robert Haas's avatar
      Add "skipping" to the NOTICE produced by DROP OPERATOR CLASS IF EXISTS. · 1d751018
      Robert Haas authored
      This makes this message consistent with all the other similar notices
      produced by other DROP IF EXISTS commands.
      
      Noted by KaiGai Kohei
      1d751018
    • Robert Haas's avatar
      Remove a few of the new DROP-IF-EXISTS regression tests. · 0bf08994
      Robert Haas authored
      Commit 3301c835 broke the build farm.
      Let's try to fix that.
      0bf08994
    • Robert Haas's avatar
      Consolidate DROP handling for some object types. · 82a4a777
      Robert Haas authored
      This gets rid of a significant amount of duplicative code.
      
      KaiGai Kohei, reviewed in earlier versions by Dimitri Fontaine, with
      further review and cleanup by me.
      82a4a777