1. 28 Dec, 2007 1 commit
    • Tom Lane's avatar
      Improve consistency of error reporting in GUC assign_hook routines. Some · 5233dc15
      Tom Lane authored
      were reporting ERROR for interactive assignments and LOG for other cases,
      some were saying nothing for non-interactive cases, and a few did yet other
      things.  Make them use a new function GUC_complaint_elevel() to establish
      a reasonably uniform policy about how to report.  There are still a few
      edge cases such as assign_search_path(), but it's much better than before.
      Per gripe from Devrim Gunduz and subsequent discussion.
      
      As noted by Alvaro, it'd be better to fold these custom messages into the
      standard "invalid parameter value" complaint from guc.c, perhaps as the DETAIL
      field.  However that will require more redesign than seems prudent for 8.3.
      This is a relatively safe, low-impact change that we can afford to risk now.
      5233dc15
  2. 27 Dec, 2007 4 commits
    • Tom Lane's avatar
      Disallow digits and lower-case ASCII letters as the delimiter in non-CSV · 2e4cb708
      Tom Lane authored
      COPY.  We need a restriction here because when the delimiter occurs as a
      data character, it is emitted with a backslash, and that will only work
      as desired if CopyReadAttributesText() will interpret the backslash sequence
      as representing the second character literally.  This is currently untrue
      for 'b', 'f', 'n', 'r', 't', 'v', 'x', and octal digits.  For future-proofing
      and simplicity of explanation, it seems best to disallow a-z and 0-9.
      We must also disallow dot, since "\." by itself would look like copy EOF.
      Note: "\N" is by default the null print string, so N would also cause a
      problem, but that is already tested for.
      2e4cb708
    • Tom Lane's avatar
      Fix ill-advised usage of x?y:z expressions in errmsg() and errhint() calls. · f1d1ca9a
      Tom Lane authored
      This prevented gettext from recognizing the strings that need to be
      translated.
      f1d1ca9a
    • Tom Lane's avatar
      Swap the order of testing for control characters and for column delimiter in · 16adaf1b
      Tom Lane authored
      CopyAttributeOutText(), so that control characters are converted to the
      C-style escape sequences even if they happen to be equal to the column
      delimiter (as is true by default for tab, for example).  Oversight in my
      previous patch to restore pre-8.3 behavior of COPY OUT escaping.  Per report
      from Tomas Szepe.
      16adaf1b
    • Peter Eisentraut's avatar
      Wording improvements · f5f1355d
      Peter Eisentraut authored
      f5f1355d
  3. 25 Dec, 2007 3 commits
  4. 23 Dec, 2007 1 commit
  5. 22 Dec, 2007 1 commit
  6. 21 Dec, 2007 6 commits
  7. 20 Dec, 2007 2 commits
  8. 19 Dec, 2007 2 commits
  9. 18 Dec, 2007 3 commits
  10. 17 Dec, 2007 8 commits
  11. 16 Dec, 2007 9 commits