1. 12 Mar, 2013 5 commits
    • Tom Lane's avatar
      Fix contrib/postgres_fdw's handling of column defaults. · 50c19fc7
      Tom Lane authored
      Adopt the position that only locally-defined defaults matter.  Any defaults
      defined in the remote database do not affect insertions performed through
      a foreign table (unless they are for columns not known to the foreign
      table).  While it'd arguably be more useful to permit remote defaults to be
      used, making that work in a consistent fashion requires far more work than
      seems possible for 9.3.
      50c19fc7
    • Tom Lane's avatar
      Allow default expressions to be attached to columns of foreign tables. · a0c6dfee
      Tom Lane authored
      There's still some discussion about exactly how postgres_fdw ought to
      handle this case, but there seems no debate that we want to allow defaults
      to be used for inserts into foreign tables.  So remove the core-code
      restrictions that prevented it.
      
      While at it, get rid of the special grammar productions for CREATE FOREIGN
      TABLE, and instead add explicit FEATURE_NOT_SUPPORTED error checks for the
      disallowed cases.  This makes the grammar a shade smaller, and more
      importantly results in much more intelligible error messages for
      unsupported cases.  It's also one less thing to fix if we ever start
      supporting constraints on foreign tables.
      a0c6dfee
    • Alvaro Herrera's avatar
      Fix orthotypographical mistake · 1ba01193
      Alvaro Herrera authored
      Apparently I lost some of the edits I had done on this page for commit
      0ac5ad51.
      
      Per note from Etsuro Fujita, although I didn't use his patch.
      
      Make some of the wording in the affected section a bit more complete,
      too.
      1ba01193
    • Tom Lane's avatar
      Avoid row-processing-order dependency in postgres_fdw regression test. · 0247d43d
      Tom Lane authored
      A test intended to provoke an error on the remote side was coded in such
      a way that multiple rows should be updated, so the output would vary
      depending on which one was processed first.  Per buildfarm.
      0247d43d
    • Tom Lane's avatar
      Fix postgres_fdw's issues with inconsistent interpretation of data values. · cc3f281f
      Tom Lane authored
      For datatypes whose output formatting depends on one or more GUC settings,
      we have to worry about whether the other server will interpret the value
      the same way it was meant.  pg_dump has been aware of this hazard for a
      long time, but postgres_fdw needs to deal with it too.  To fix data
      retrieval from the remote server, set the necessary remote GUC settings at
      connection startup.  (We were already assuming that settings made then
      would persist throughout the remote session.)  To fix data transmission to
      the remote server, temporarily force the relevant GUCs to the right values
      when we're about to convert any data values to text for transmission.
      
      This is all pretty grotty, and not very cheap either.  It's tempting to
      think of defining one uber-GUC that would override any settings that might
      render printed data values unportable.  But of course, older remote servers
      wouldn't know any such thing and would still need this logic.
      
      While at it, revert commit f7951eef, since
      this provides a real fix.  (The timestamptz given in the error message
      returned from the "remote" server will now reliably be shown in UTC.)
      cc3f281f
  2. 11 Mar, 2013 2 commits
  3. 10 Mar, 2013 7 commits
    • Andrew Dunstan's avatar
      JSON generation improvements. · 38fb4d97
      Andrew Dunstan authored
      This adds the following:
      
          json_agg(anyrecord) -> json
          to_json(any) -> json
          hstore_to_json(hstore) -> json (also used as a cast)
          hstore_to_json_loose(hstore) -> json
      
      The last provides heuristic treatment of numbers and booleans.
      
      Also, in json generation, if any non-builtin type has a cast to json,
      that function is used instead of the type's output function.
      
      Andrew Dunstan, reviewed by Steve Singer.
      
      Catalog version bumped.
      38fb4d97
    • Peter Eisentraut's avatar
      doc: Add note about checkpoint_warning vs checkpoint_timeout · dd28c410
      Peter Eisentraut authored
      suggested by Tianyin Xu
      dd28c410
    • Peter Eisentraut's avatar
      31531325
    • Peter Eisentraut's avatar
    • Tom Lane's avatar
      Band-aid for regression test expected-results problem with timestamptz. · f7951eef
      Tom Lane authored
      We probably need to tell the remote server to use specific timezone and
      datestyle settings, and maybe other things.  But for now let's just hack
      the postgres_fdw regression test to not provoke failures when run in
      non-EST5EDT environments.  Per buildfarm.
      f7951eef
    • Tom Lane's avatar
      Support writable foreign tables. · 21734d2f
      Tom Lane authored
      This patch adds the core-system infrastructure needed to support updates
      on foreign tables, and extends contrib/postgres_fdw to allow updates
      against remote Postgres servers.  There's still a great deal of room for
      improvement in optimization of remote updates, but at least there's basic
      functionality there now.
      
      KaiGai Kohei, reviewed by Alexander Korotkov and Laurenz Albe, and rather
      heavily revised by Tom Lane.
      21734d2f
    • Magnus Hagander's avatar
      Report pg_hba line number and contents when users fail to log in · 7f49a67f
      Magnus Hagander authored
      Instead of just reporting which user failed to log in, log both the
      line number in the active pg_hba.conf file (which may not match reality
      in case the file has been edited and not reloaded) and the contents of
      the matching line (which will always be correct), to make it easier
      to debug incorrect pg_hba.conf files.
      
      The message to the client remains unchanged and does not include this
      information, to prevent leaking security sensitive information.
      
      Reviewed by Tom Lane and Dean Rasheed
      7f49a67f
  4. 08 Mar, 2013 3 commits
  5. 07 Mar, 2013 7 commits
  6. 06 Mar, 2013 7 commits
  7. 05 Mar, 2013 2 commits
    • Tom Lane's avatar
      Fix to_char() to use ASCII-only case-folding rules where appropriate. · 80b011ef
      Tom Lane authored
      formatting.c used locale-dependent case folding rules in some code paths
      where the result isn't supposed to be locale-dependent, for example
      to_char(timestamp, 'DAY').  Since the source data is always just ASCII
      in these cases, that usually didn't matter ... but it does matter in
      Turkish locales, which have unusual treatment of "i" and "I".  To confuse
      matters even more, the misbehavior was only visible in UTF8 encoding,
      because in single-byte encodings we used pg_toupper/pg_tolower which
      don't have locale-specific behavior for ASCII characters.  Fix by providing
      intentionally ASCII-only case-folding functions and using these where
      appropriate.  Per bug #7913 from Adnan Dursun.  Back-patch to all active
      branches, since it's been like this for a long time.
      80b011ef
    • Kevin Grittner's avatar
  8. 04 Mar, 2013 6 commits
    • Tom Lane's avatar
      Fix overflow check in tm2timestamp (this time for sure). · 542eeba2
      Tom Lane authored
      I fixed this code back in commit 841b4a2d, but didn't think carefully
      enough about the behavior near zero, which meant it improperly rejected
      1999-12-31 24:00:00.  Per report from Magnus Hagander.
      542eeba2
    • Peter Eisentraut's avatar
      psql: Let \l accept a pattern · 0ea1f6e9
      Peter Eisentraut authored
      reviewed by Satoshi Nagayasu
      0ea1f6e9
    • Kevin Grittner's avatar
      Remove accidentally-committed .orig file. · 54d6706d
      Kevin Grittner authored
      54d6706d
    • Tom Lane's avatar
      Fix map_sql_value_to_xml_value() to treat domains like their base types. · bc618786
      Tom Lane authored
      This was already the case for domains over arrays, but not for domains
      over certain built-in types such as boolean.  The special formatting
      rules for those types should apply to domains over them as well.
      Per discussion.
      
      While this is a bug fix, it's also a behavioral change that seems likely
      to trip up some applications.  So no back-patch.
      
      Pavel Stehule
      bc618786
    • Kevin Grittner's avatar
      Add a materialized view relations. · 3bf3ab8c
      Kevin Grittner authored
      A materialized view has a rule just like a view and a heap and
      other physical properties like a table.  The rule is only used to
      populate the table, references in queries refer to the
      materialized data.
      
      This is a minimal implementation, but should still be useful in
      many cases.  Currently data is only populated "on demand" by the
      CREATE MATERIALIZED VIEW and REFRESH MATERIALIZED VIEW statements.
      It is expected that future releases will add incremental updates
      with various timings, and that a more refined concept of defining
      what is "fresh" data will be developed.  At some point it may even
      be possible to have queries use a materialized in place of
      references to underlying tables, but that requires the other
      above-mentioned features to be working first.
      
      Much of the documentation work by Robert Haas.
      Review by Noah Misch, Thom Brown, Robert Haas, Marko Tiikkaja
      Security review by KaiGai Kohei, with a decision on how best to
      implement sepgsql still pending.
      3bf3ab8c
    • Tom Lane's avatar
      Get rid of any toast table when converting a table to a view. · b15a6da2
      Tom Lane authored
      Also make sure other fields of the view's pg_class entry are appropriate
      for a view; it shouldn't have relfrozenxid set for instance.
      
      This ancient omission isn't believed to have any serious consequences in
      versions 8.4-9.2, so no backpatch.  But let's fix it before it does bite
      us in some serious way.  It's just luck that the case doesn't cause
      problems for autovacuum.  (It did cause problems in 8.3, but that's out
      of support.)
      
      Andres Freund
      b15a6da2
  9. 03 Mar, 2013 1 commit
    • Tom Lane's avatar
      Fix SQL function execution to be safe with long-lived FmgrInfos. · 2b78d101
      Tom Lane authored
      fmgr_sql had been designed on the assumption that the FmgrInfo it's called
      with has only query lifespan.  This is demonstrably unsafe in connection
      with range types, as shown in bug #7881 from Andrew Gierth.  Fix things
      so that we re-generate the function's cache data if the (sub)transaction
      it was made in is no longer active.
      
      Back-patch to 9.2.  This might be needed further back, but it's not clear
      whether the case can realistically arise without range types, so for now
      I'll desist from back-patching further.
      2b78d101