1. 26 Jan, 2013 3 commits
  2. 25 Jan, 2013 15 commits
  3. 24 Jan, 2013 12 commits
    • Tom Lane's avatar
      Fix SPI documentation for new handling of ExecutorRun's count parameter. · 2ddc600f
      Tom Lane authored
      Since 9.0, the count parameter has only limited the number of tuples
      actually returned by the executor.  It doesn't affect the behavior of
      INSERT/UPDATE/DELETE unless RETURNING is specified, because without
      RETURNING, the ModifyTable plan node doesn't return control to execMain.c
      for each tuple.  And we only check the limit at the top level.
      
      While this behavioral change was unintentional at the time, discussion of
      bug #6572 led us to the conclusion that we prefer the new behavior anyway,
      and so we should just adjust the docs to match rather than change the code.
      Accordingly, do that.  Back-patch as far as 9.0 so that the docs match the
      code in each branch.
      2ddc600f
    • Andrew Dunstan's avatar
      Use correct output device for Windows prompts. · 1068771a
      Andrew Dunstan authored
      This ensures that mapping of non-ascii prompts
      to the correct code page occurs.
      
      Bug report and original patch from Alexander Law,
      reviewed and reworked by Noah Misch.
      
      Backpatch to all live branches.
      1068771a
    • Bruce Momjian's avatar
      pg_upgrade: detect stale postmaster.pid lock files · a9ceaa53
      Bruce Momjian authored
      If the postmaster.pid lock file exists, try starting/stopping the
      cluster to check if the lock file is valid.
      
      Per request from Tom.
      a9ceaa53
    • Alvaro Herrera's avatar
      Redefine HEAP_XMAX_IS_LOCKED_ONLY · 74ebba84
      Alvaro Herrera authored
      Tuples marked SELECT FOR UPDATE in a cluster that's later processed by
      pg_upgrade would have a different infomask bit pattern than those
      produced by 9.3dev; that bit pattern was being seen as "dead" by HEAD
      (because they would fail the "is this tuple locked" test, and so the
      visibility rules would thing they're updated, even though there's no
      HEAP_UPDATED version of them).  In other words, some rows could silently
      disappear after pg_upgrade.
      
      With this new definition, those tuples become visible again.
      
      This is breakage resulting from my commit 0ac5ad51.
      74ebba84
    • Alvaro Herrera's avatar
      Use the catversion to distinguish old/new clusters · 34da7004
      Alvaro Herrera authored
      This makes 9.3 -> 9.3 upgrades work when they cross the commit that
      added persistent multixacts; early 9.3 pg_controldata did not have the
      required oldestMultiXact line, and so would fail to upgrade.
      
      per Bruce Momjian
      34da7004
    • Alvaro Herrera's avatar
      2494a9af
    • Alvaro Herrera's avatar
      Make output identical to pg_resetxlog's · 6772c1e5
      Alvaro Herrera authored
      6772c1e5
    • Simon Riggs's avatar
      Fix rare missing cancellations in Hot Standby. · 5c54f63f
      Simon Riggs authored
      The machinery around XLOG_HEAP2_CLEANUP_INFO failed
      to correctly pass through the necessary information
      on latestRemovedXid, avoiding cancellations in some
      infrequent concurrent update/cleanup scenarios.
      
      Backpatchable fix to 9.0
      
      Detailed bug report and fix by Noah Misch,
      backpatchable version by me.
      5c54f63f
    • Bruce Momjian's avatar
      pg_upgrade: report failed cluster name · bd6aca8a
      Bruce Momjian authored
      When pg_upgrade can't find required pg_controldata information, report
      _which_ cluster is failing, with this message:
      
      	The %s cluster lacks some required control information:
      bd6aca8a
    • Heikki Linnakangas's avatar
      Also fix rotation of csvlog on Windows. · 168d3157
      Heikki Linnakangas authored
      Backpatch to 9.2, like the previous fix.
      168d3157
    • Simon Riggs's avatar
      Docs shouldn't say HOT Standby. · f64315c6
      Simon Riggs authored
      Not an acronym.
      
      Jeff Janes
      f64315c6
    • Tom Lane's avatar
      Fix failure to rotate postmaster log file for size reasons on Windows. · 8556869f
      Tom Lane authored
      When we eliminated "unnecessary" wakeups of the syslogger process, we
      broke size-based logfile rotation on Windows, because on that platform
      data transfer is done in a separate thread.  While non-Windows platforms
      would recheck the output file size after every log message, Windows only
      did so when the control thread woke up for some other reason, which might
      be quite infrequent.  Per bug #7814 from Tsunezumi.  Back-patch to 9.2
      where the problem was introduced.
      
      Jeff Janes
      8556869f
  4. 23 Jan, 2013 10 commits
    • Alvaro Herrera's avatar
      isolationtester: add a few fflush(stderr) calls · ca5db759
      Alvaro Herrera authored
      The lack of them is causing failures in some BF members.
      
      Per Andrew Dunstan.
      ca5db759
    • Robert Haas's avatar
      Clarify that connection parameters aren't totally meaningless for PQping. · 40ed59b2
      Robert Haas authored
      Per discussion with Phil Sorber.
      40ed59b2
    • Robert Haas's avatar
      pg_isready · ac2e9673
      Robert Haas authored
      New command-line utility to test whether a server is ready to
      accept connections.
      
      Phil Sorber, reviewed by Michael Paquier and Peter Eisentraut
      ac2e9673
    • Alvaro Herrera's avatar
      Improve concurrency of foreign key locking · 0ac5ad51
      Alvaro Herrera authored
      This patch introduces two additional lock modes for tuples: "SELECT FOR
      KEY SHARE" and "SELECT FOR NO KEY UPDATE".  These don't block each
      other, in contrast with already existing "SELECT FOR SHARE" and "SELECT
      FOR UPDATE".  UPDATE commands that do not modify the values stored in
      the columns that are part of the key of the tuple now grab a SELECT FOR
      NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently
      with tuple locks of the FOR KEY SHARE variety.
      
      Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this
      means the concurrency improvement applies to them, which is the whole
      point of this patch.
      
      The added tuple lock semantics require some rejiggering of the multixact
      module, so that the locking level that each transaction is holding can
      be stored alongside its Xid.  Also, multixacts now need to persist
      across server restarts and crashes, because they can now represent not
      only tuple locks, but also tuple updates.  This means we need more
      careful tracking of lifetime of pg_multixact SLRU files; since they now
      persist longer, we require more infrastructure to figure out when they
      can be removed.  pg_upgrade also needs to be careful to copy
      pg_multixact files over from the old server to the new, or at least part
      of multixact.c state, depending on the versions of the old and new
      servers.
      
      Tuple time qualification rules (HeapTupleSatisfies routines) need to be
      careful not to consider tuples with the "is multi" infomask bit set as
      being only locked; they might need to look up MultiXact values (i.e.
      possibly do pg_multixact I/O) to find out the Xid that updated a tuple,
      whereas they previously were assured to only use information readily
      available from the tuple header.  This is considered acceptable, because
      the extra I/O would involve cases that would previously cause some
      commands to block waiting for concurrent transactions to finish.
      
      Another important change is the fact that locking tuples that have
      previously been updated causes the future versions to be marked as
      locked, too; this is essential for correctness of foreign key checks.
      This causes additional WAL-logging, also (there was previously a single
      WAL record for a locked tuple; now there are as many as updated copies
      of the tuple there exist.)
      
      With all this in place, contention related to tuples being checked by
      foreign key rules should be much reduced.
      
      As a bonus, the old behavior that a subtransaction grabbing a stronger
      tuple lock than the parent (sub)transaction held on a given tuple and
      later aborting caused the weaker lock to be lost, has been fixed.
      
      Many new spec files were added for isolation tester framework, to ensure
      overall behavior is sane.  There's probably room for several more tests.
      
      There were several reviewers of this patch; in particular, Noah Misch
      and Andres Freund spent considerable time in it.  Original idea for the
      patch came from Simon Riggs, after a problem report by Joel Jacobson.
      Most code is from me, with contributions from Marti Raudsepp, Alexander
      Shulgin, Noah Misch and Andres Freund.
      
      This patch was discussed in several pgsql-hackers threads; the most
      important start at the following message-ids:
      	AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com
      	1290721684-sup-3951@alvh.no-ip.org
      	1294953201-sup-2099@alvh.no-ip.org
      	1320343602-sup-2290@alvh.no-ip.org
      	1339690386-sup-8927@alvh.no-ip.org
      	4FE5FF020200002500048A3D@gw.wicourts.gov
      	4FEAB90A0200002500048B7D@gw.wicourts.gov
      0ac5ad51
    • Robert Haas's avatar
      Further documentation tweaks for event triggers. · f925c79b
      Robert Haas authored
      Per discussion between Dimitri Fontaine, myself, and others.
      f925c79b
    • Robert Haas's avatar
    • Heikki Linnakangas's avatar
      Implement pg_unreachable() on MSVC. · 52906f17
      Heikki Linnakangas authored
      52906f17
    • Andrew Dunstan's avatar
      Gitignore vcxproj files. · eaf76484
      Andrew Dunstan authored
      Per request from Craig Ringer.
      eaf76484
    • Heikki Linnakangas's avatar
      Fix more issues with cascading replication and timeline switches. · 990fe3c4
      Heikki Linnakangas authored
      When a standby server follows the master using WAL archive, and it chooses
      a new timeline (recovery_target_timeline='latest'), it only fetches the
      timeline history file for the chosen target timeline, not any other history
      files that might be missing from pg_xlog. For example, if the current
      timeline is 2, and we choose 4 as the new recovery target timeline, the
      history file for timeline 3 is not fetched, even if it's part of this
      server's history. That's enough for the standby itself - the history file
      for timeline 4 includes timeline 3 as well - but if a cascading standby
      server wants to recover to timeline 3, it needs the history file. To fix,
      when a new recovery target timeline is chosen, try to copy any missing
      history files from the archive to pg_xlog between the old and new target
      timeline.
      
      A second similar issue was with the WAL files. When a standby recovers from
      archive, and it reaches a segment that contains a switch to a new timeline,
      recovery fetches only the WAL file labelled with the new timeline's ID. The
      file from the new timeline contains a copy of the WAL from the old timeline
      up to the point where the switch happened, and recovery recovers it from the
      new file. But in streaming replication, walsender only tries to read it
      from the old timeline's file. To fix, change walsender to read it from the
      new file, so that it behaves the same as recovery in that sense, and doesn't
      try to open the possibly nonexistent file with the old timeline's ID.
      990fe3c4
    • Bruce Momjian's avatar
      pg_upgrade: remove --single-transaction usage · 861ad67b
      Bruce Momjian authored
      With AtEOXact applied, --single-transaction makes pg_restore slower, and
      has the potential to require lock table configuration, so remove the
      argument.
      
      Per suggestion from Tom.
      861ad67b